From: "Gupta, Pankaj" <pankaj.gupta@amd.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Naveen N Rao <naveen@kernel.org>,
Kim Phillips <kim.phillips@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Alexey Kardashevskiy <aik@amd.com>
Subject: Re: [PATCH v2 07/10] KVM: SVM: Use guard(mutex) to simplify SNP AP Creation error handling
Date: Thu, 27 Feb 2025 17:51:23 +0100 [thread overview]
Message-ID: <8e9b3db1-2b74-4db1-8daf-3b66b407ad9a@amd.com> (raw)
In-Reply-To: <20250227012541.3234589-8-seanjc@google.com>
On 2/27/2025 2:25 AM, Sean Christopherson wrote:
> Use guard(mutex) in sev_snp_ap_creation() and modify the error paths to
> return directly instead of jumping to a common exit point.
>
> No functional change intended.
>
> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>
> ---
> arch/x86/kvm/svm/sev.c | 22 ++++++----------------
> 1 file changed, 6 insertions(+), 16 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index ccac840ee7be..dd9511a2254b 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -3938,7 +3938,6 @@ static int sev_snp_ap_creation(struct vcpu_svm *svm)
> struct vcpu_svm *target_svm;
> unsigned int request;
> unsigned int apic_id;
> - int ret;
>
> request = lower_32_bits(svm->vmcb->control.exit_info_1);
> apic_id = upper_32_bits(svm->vmcb->control.exit_info_1);
> @@ -3951,11 +3950,9 @@ static int sev_snp_ap_creation(struct vcpu_svm *svm)
> return -EINVAL;
> }
>
> - ret = 0;
> -
> target_svm = to_svm(target_vcpu);
>
> - mutex_lock(&target_svm->sev_es.snp_vmsa_mutex);
> + guard(mutex)(&target_svm->sev_es.snp_vmsa_mutex);
>
> switch (request) {
> case SVM_VMGEXIT_AP_CREATE_ON_INIT:
> @@ -3963,15 +3960,13 @@ static int sev_snp_ap_creation(struct vcpu_svm *svm)
> if (vcpu->arch.regs[VCPU_REGS_RAX] != sev->vmsa_features) {
> vcpu_unimpl(vcpu, "vmgexit: mismatched AP sev_features [%#lx] != [%#llx] from guest\n",
> vcpu->arch.regs[VCPU_REGS_RAX], sev->vmsa_features);
> - ret = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
>
> if (!page_address_valid(vcpu, svm->vmcb->control.exit_info_2)) {
> vcpu_unimpl(vcpu, "vmgexit: invalid AP VMSA address [%#llx] from guest\n",
> svm->vmcb->control.exit_info_2);
> - ret = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
>
> /*
> @@ -3985,8 +3980,7 @@ static int sev_snp_ap_creation(struct vcpu_svm *svm)
> vcpu_unimpl(vcpu,
> "vmgexit: AP VMSA address [%llx] from guest is unsafe as it is 2M aligned\n",
> svm->vmcb->control.exit_info_2);
> - ret = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
>
> target_svm->sev_es.snp_vmsa_gpa = svm->vmcb->control.exit_info_2;
> @@ -3997,8 +3991,7 @@ static int sev_snp_ap_creation(struct vcpu_svm *svm)
> default:
> vcpu_unimpl(vcpu, "vmgexit: invalid AP creation request [%#x] from guest\n",
> request);
> - ret = -EINVAL;
> - goto out;
> + return -EINVAL;
> }
>
> target_svm->sev_es.snp_ap_waiting_for_reset = true;
> @@ -4012,10 +4005,7 @@ static int sev_snp_ap_creation(struct vcpu_svm *svm)
> kvm_vcpu_kick(target_vcpu);
> }
>
> -out:
> - mutex_unlock(&target_svm->sev_es.snp_vmsa_mutex);
> -
> - return ret;
> + return 0;
> }
>
> static int snp_handle_guest_req(struct vcpu_svm *svm, gpa_t req_gpa, gpa_t resp_gpa)
next prev parent reply other threads:[~2025-02-27 16:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 1:25 [PATCH v2 00/10] KVM: SVM: Attempt to cleanup SEV_FEATURES Sean Christopherson
2025-02-27 1:25 ` [PATCH v2 01/10] KVM: SVM: Save host DR masks on CPUs with DebugSwap Sean Christopherson
2025-02-27 1:25 ` [PATCH v2 02/10] KVM: SVM: Don't rely on DebugSwap to restore host DR0..DR3 Sean Christopherson
2025-02-27 1:25 ` [PATCH v2 03/10] KVM: SVM: Refuse to attempt VRMUN if an SEV-ES+ guest has an invalid VMSA Sean Christopherson
2025-02-27 16:03 ` Tom Lendacky
2025-02-27 16:56 ` Gupta, Pankaj
2025-02-27 1:25 ` [PATCH v2 04/10] KVM: SVM: Don't change target vCPU state on AP Creation VMGEXIT error Sean Christopherson
2025-02-27 10:25 ` Gupta, Pankaj
2025-02-27 1:25 ` [PATCH v2 05/10] KVM: SVM: Require AP's "requested" SEV_FEATURES to match KVM's view Sean Christopherson
2025-02-27 7:12 ` Gupta, Pankaj
2025-02-27 14:33 ` Sean Christopherson
2025-02-27 15:18 ` Gupta, Pankaj
2025-02-27 15:42 ` Sean Christopherson
2025-02-27 1:25 ` [PATCH v2 06/10] KVM: SVM: Simplify request+kick logic in SNP AP Creation handling Sean Christopherson
2025-02-27 1:25 ` [PATCH v2 07/10] KVM: SVM: Use guard(mutex) to simplify SNP AP Creation error handling Sean Christopherson
2025-02-27 16:51 ` Gupta, Pankaj [this message]
2025-02-27 1:25 ` [PATCH v2 08/10] KVM: SVM: Mark VMCB dirty before processing incoming snp_vmsa_gpa Sean Christopherson
2025-02-27 1:25 ` [PATCH v2 09/10] KVM: SVM: Use guard(mutex) to simplify SNP vCPU state updates Sean Christopherson
2025-02-27 1:25 ` [PATCH v2 10/10] KVM: SVM: Invalidate "next" SNP VMSA GPA even on failure Sean Christopherson
2025-03-05 1:05 ` [PATCH v2 00/10] KVM: SVM: Attempt to cleanup SEV_FEATURES Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e9b3db1-2b74-4db1-8daf-3b66b407ad9a@amd.com \
--to=pankaj.gupta@amd.com \
--cc=aik@amd.com \
--cc=kim.phillips@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen@kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®