From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: (EXT) Re: [PATCH] arm: dts: imx7: add QSPI
Date: Tue, 28 Jul 2020 16:05:47 +0200 [thread overview]
Message-ID: <8ea0b3f655b60be02384f22c0aa4dfee9d788d71.camel@ew.tq-group.com> (raw)
In-Reply-To: <20200728135155.aqz3xkcwpgqmvzro@pengutronix.de>
On Tue, 2020-07-28 at 15:51 +0200, Marco Felsch wrote:
> Hi Matthias,
>
> thanks for the patch.
>
> On 20-07-28 13:28, Matthias Schiffer wrote:
> > In preparation for an update of the TQ-Systems TQMa7x/MBa7x DTS,
> > add the
> > QSPI controller to imx7s.dtsi.
> >
> > Based-on-patch-by: Han Xu <han.xu@nxp.com>
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com
> > >
> > ---
> > arch/arm/boot/dts/imx7s.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7s.dtsi
> > b/arch/arm/boot/dts/imx7s.dtsi
> > index 1cfaf410aa43..e45683e61593 100644
> > --- a/arch/arm/boot/dts/imx7s.dtsi
> > +++ b/arch/arm/boot/dts/imx7s.dtsi
> > @@ -1162,6 +1162,19 @@
> > status = "disabled";
> > };
> >
> > + qspi1: spi@30bb0000 {
>
> Are there more controllers and why not using "qspi@30bb0000" as node
> name?
The vast majority of QSPI controllers use spi@ node names, qspi@ only
appears in a single example in Documentation/devicetree/bindings/, and
in no actual DTS(I) files.
There is only one controller. The label "qspi1" is chosen as this has
been in use in the linux-imx vendor kernels for years; IMHO, switching
to "qspi" would just cause unnecessary churn for dependent device
trees. I have no strong opinions on this though.
>
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "fsl,imx7d-qspi";
> > + reg = <0x30bb0000 0x10000>, <0x60000000
> > 0x10000000>;
> > + reg-names = "QuadSPI", "QuadSPI-
> > memory";
>
> The node should begin with compatible, reg, reg-names properties.
> Pls check the current .dtsi file for examples.
Thanks, will fix.
>
> > + interrupts = <GIC_SPI 107
> > IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clks IMX7D_QSPI_ROOT_CLK>,
> > + <&clks IMX7D_QSPI_ROOT_CLK>;
> > + clock-names = "qspi_en", "qspi";
> > + status = "disabled";
> > + };
> > +
> > sdma: sdma@30bd0000 {
> > compatible = "fsl,imx7d-sdma",
> > "fsl,imx35-sdma";
> > reg = <0x30bd0000 0x10000>;
>
> Regards,
> Marco
next prev parent reply other threads:[~2020-07-28 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 11:28 Matthias Schiffer
2020-07-28 13:51 ` Marco Felsch
2020-07-28 14:05 ` Matthias Schiffer [this message]
2020-07-28 14:31 ` (EXT) " Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea0b3f655b60be02384f22c0aa4dfee9d788d71.camel@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®