From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66E7848C401 for ; Mon, 18 May 2026 16:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779122680; cv=none; b=F9bM44Tvg7Xlte0FiSw6VyoHoGD1ry00ZZbH5hzB7I/R1bq0P6Hjp6jQEkDoFP250qPrUTpNacc5UfF4fPPPA9L3q++SoDKew3ObsaIeGhC0e1JzHbfu1IioI2pQYhBdFkYOkCleZkPcqjIGTgCe0cDCkVbmKFKdGsLgnV2g4K0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779122680; c=relaxed/simple; bh=YE3HoIFb8FxWqSA+l6qK/mJkb4FDgYWDmcyId5B2F2E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jVTT+9F984Rf8a5k8EQfpNLDmkh+mMGRQoekRo6/s73rjyQ+qdAlGhbqQDv8m4oks3H9i1U4mbNcrcppOd05viyB8OV/0ZwE+mqW8CMK9FG9u23W9lB0tCZ99QUVaxCQIHOLUVAW0SB5vayH4QH4xz3g+5jy6sDdxiwpKUIsKP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com; spf=pass smtp.mailfrom=arista.com; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b=hn8mHaf3; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=arista.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arista.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="hn8mHaf3" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48e6db3ff7eso12530815e9.0 for ; Mon, 18 May 2026 09:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; t=1779122677; x=1779727477; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7UJetEPl8iEmaBxBdu9lhTExkMb01pXnVK0wWC0qPWM=; b=hn8mHaf3nN/G3EfwPa024Vkd8ONlhvOtFgR13hg6s3HBfpKyLg3EiGeajgfqb5LM// F4A1NE5/ifh87TIiq+vXf2rTQ3axPqO3W5i3xjGbeNFKjFxg7eSZ06xODR7nVuICYPEK HrpDkNYU3IbSWSw/peRlcTTqgnKOL/rxmyQ6fQI0NaVe4xbkK+Ozdmn3DOr85h4LQbgl uU8sYFaMxJFZJiELk/y9ddDlI9sWPVgENRvadCts3btR1xF5rD2W5qsCPGgIQhrmehgC WHFyzrmtB5P72wQABnR3Qni5pJRO5xsICPmiuLNrbFBthvZum1/C5Ho+p2OmSgTYB0QS i5YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779122677; x=1779727477; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7UJetEPl8iEmaBxBdu9lhTExkMb01pXnVK0wWC0qPWM=; b=jk5Ork1sStBQ6V90D2u/jPZxPgvaR8AgBIGHjSgFxOO1EPyzGZYxOZdODL+BapP7Jm hnj2iQMIh/W5d2odc2ye200JAx6WHgsMxBQebSkiJzG23YBxNSFAvntPw6I4IBh7RkNP U+J73MoZryMx6gOcojTQr2dYmfWatPHYIpaO8DG5dwK3fbGGFEG0r3DvO0PlHJ6PVj6u wdupzDV4wRHle/Hmd26nrHJrQkO8vxZW/VGnrIE8yychg5jYDZ60iDzO2Q221lqNLZbm voZcQQE7EvDFsSdgFWnypxSuDK8FacMbDemhbFFo3egoBOuDF44VEaQKuewlaPJqJZNC 8m6w== X-Forwarded-Encrypted: i=1; AFNElJ+fR23QAzFcxfqPCz+5Iz/xcOsIhjdNKc2xBeHdwxtqI8HlerA8FO0SVsjIKZrmvguIiWekrU2cnhBshbU=@vger.kernel.org X-Gm-Message-State: AOJu0YyknWRJmFvJNyxhN+Ngtn7nse3JVrH6kxoBH46iOozblxzOZxDd 0oxt/Ptn9Ficwc/t9dDpkFeP2DsPFwx9yEB1DJvz8WCBOnhUq3oY+iyl+YthDsSNjYxiKJWzHqO 4oO3hYA== X-Gm-Gg: Acq92OFoTiOMU4Znda6vcjyg9KpAehI5cs/q4AgI4mQU1BJEYrHIKB0Av+aax72UU5E aoJVzhFB66kLlng2QlS2TIrdN2Jl0/U6aDd6pxsF64hB92LHT8gbfzY0G3gMpaJIzVloxpE87QB dT0wUaRp11HKxpWWJ3V6LZl9w0sZ3WY29w7Jk0wMakDnzw5r1kFaB6vvAq1Lhkq8nmTzB03L69K RBybQjGv1SShj8k19IG0kXpjmNEFLtmNZZGDYvQTa41v2YmwA242GEfPsldFSl4Yd6ETCZvkhzK DvosmIZShUobtkJT1smNjA1z+dIifidz+Px5gudD4pe6XUO18LxHI3uURaJaKhl2/MO/E6r6Xdp g27hbVA4Oz6IVaPWHSlsgH9eTkLcMvIeqL+Bb04mudbBJnwf53VT8McIWwU4/g2JnBjHZSIho7r 3gMvSHHpBR0hHmY5qnn+Z4sBIsTNBneA3veg== X-Received: by 2002:a05:600c:870c:b0:490:320:949 with SMTP id 5b1f17b1804b1-490032009f3mr115980855e9.27.1779122676802; Mon, 18 May 2026 09:44:36 -0700 (PDT) Received: from [10.83.43.186] ([159.134.255.34]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe6aff4sm86122385e9.25.2026.05.18.09.44.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 09:44:36 -0700 (PDT) Message-ID: <8ea0f79a-a8b0-4d1e-85dc-6f5b8fd3c135@arista.com> Date: Mon, 18 May 2026 17:44:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tg3: guard napi_disable and pci_disable_device calls To: Michael Chan , Pavan Chebbi Cc: mchan@broadcom.com, netdev@vger.kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org References: Content-Language: en-US From: "Yury M." In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Yes, mostly this patch is about adding a flag to track the NAPI status to avoid a double release. On 5/18/26 17:27, Michael Chan wrote: > On Mon, May 18, 2026 at 8:43 AM Pavan Chebbi wrote: > >> I am not sure if we should allow this fix for what I think is a >> situation arising out of an unsupported topology.. >> I will defer this to Michael or netdev maintainers for their feedback. > If the question is about adding a driver flag to keep track of the > NAPI state, I think it should be ok. bnxt has a similar > BNXT_STATE_NAPI_DISABLED flag for this purpose.