mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Waiman Long <longman@redhat.com>
To: Yang Shi <yang.s@alibaba-inc.com>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] lib: debugobjects: export max loops counter
Date: Mon, 27 Nov 2017 13:08:31 -0500	[thread overview]
Message-ID: <8ea5263b-6733-78fa-f6bd-331eedb39da5@redhat.com> (raw)
In-Reply-To: <a2eb8d2c-34b9-6027-66da-d8e8184285f1@alibaba-inc.com>

On 11/27/2017 12:53 PM, Yang Shi wrote:
> Hi Waiman & tglx,
>
> I'm not sure who is the maintainer for lib/debugobjects.c now, I'm
> supposed tglx still is, however, get_maintainer.pl told me Waiman is
> the most active developer of this, so added Waiman in this loop in
> case he didn't see the patches on LKML.
>
> Thanks,
> Yang
>
> On 11/17/17 11:43 AM, Yang Shi wrote:
>> Currently max chain counter is exported to sysfs, it just record the

It is the debugfs, which is different from sysfs.

>> counter of inner loop, however, there might be significant iterations of
>> external loop then it may take significant amount of time to finish all
>> of the checks. This may cuase lockup on !CONFIG_PREEMPT kernel build
>> occasionally.
>>
>> Record the counter of the max loops then export to sysfs so that the
>> user can be aware of the real overhead.
>>
>> Then the output of /sys/kernel/debug/debug_objects/stats looks like:
>>
>> max_chain     :121
>> max_loops     :543267
>> warnings      :0
>> fixups        :0
>> pool_free     :1764
>> pool_min_free :341
>> pool_used     :86438
>> pool_max_used :268887
>> objs_allocated:6068254
>> objs_freed    :5981076
>>
>> Signed-off-by: Yang Shi <yang.s@alibaba-inc.com>

I have no objection to adding one more tracking count.

Cheers,
Longman

  reply	other threads:[~2017-11-27 18:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 19:43 Yang Shi
2017-11-17 19:43 ` [RFC PATCH 2/2] lib: debugobjects: touch watchdog to avoid softlockup when !CONFIG_PREEMPT Yang Shi
2017-11-27 17:54   ` Yang Shi
2017-11-27 18:18     ` Waiman Long
2017-11-27 18:52       ` Yang Shi
2017-11-27 19:36         ` Waiman Long
2017-11-28  0:28           ` Yang Shi
2017-11-27 17:53 ` [RFC PATCH 1/2] lib: debugobjects: export max loops counter Yang Shi
2017-11-27 18:08   ` Waiman Long [this message]
2017-11-27 18:53     ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ea5263b-6733-78fa-f6bd-331eedb39da5@redhat.com \
    --to=longman@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yang.s@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®