From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>, linux-spi@vger.kernel.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Baolin Wang <baolin.wang7@gmail.com>,
Mark Brown <broonie@kernel.org>, Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: sprd: call pm_runtime_put if pm_runtime_get_sync fails
Date: Tue, 2 Jun 2020 11:05:07 +0200 [thread overview]
Message-ID: <8ea80af8-e964-4488-25c6-837f2ac88493@web.de> (raw)
> Call to pm_runtime_get_sync increments counter even in case of
> failure leading to incorrect ref count.
> Call pm_runtime_put_noidle if pm_runtime_get_sync fails.
How do you think about a wording variant like the following?
Change description:
The PM runtime reference counter is generally incremented by a call of
the function “pm_runtime_get_sync”.
Thus call the function “pm_runtime_put_noidle” also in one error case
to keep the reference counting consistent.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
next reply other threads:[~2020-06-02 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 9:05 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-02 5:19 Navid Emamdoost
2020-06-02 13:59 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea80af8-e964-4488-25c6-837f2ac88493@web.de \
--to=markus.elfring@web.de \
--cc=baolin.wang7@gmail.com \
--cc=broonie@kernel.org \
--cc=dinghao.liu@zju.edu.cn \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=orsonzhai@gmail.com \
--cc=smccaman@umn.edu \
--cc=wu000273@umn.edu \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®