From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94F8B377568 for ; Fri, 6 Mar 2026 08:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787519; cv=none; b=rbRlWTm3BSeIYUb21Ui0jFMkXrQIkR4tMw3Vx/QXm01H9rD41LWFkHEKNZ9bR/FrUosubNT3C1VdYucgjFuEixzx97czqeYF8ezrUU0L1L8AigOu1ssJ+eJMSUej9y/kE8FFIB1BuhD5mDzbreYDaixc+yk9C+Fp+X5qWNZ0Ck4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772787519; c=relaxed/simple; bh=RhVdbEPaiW0BdxCAvcmtO1IcBHJrfE4QhT/YMxENVSM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=SP3m24yWPWmhG468EkKRLPof9PBYU72uVP/EQV/r1uFPBghAQ79e9scTVSygv4mr2FsWbUMRn/MKgAxnLWHMWsumG2zgwuOt76et6efVVaI2OD2KutLk6tfEmCXCiUIbrhk3Id0fqQZF/Gp7T+UKjT4pAybCYd2qo2q/hpxviOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RsoI39s4; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=S2UdyweP; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RsoI39s4"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="S2UdyweP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772787515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TxrEfYB+045MQE9+euU6LuOafMviwFOmlDaX4FfzPLE=; b=RsoI39s4xmECxEr+lney12Uz3HHRkPm5gwyGWBwbRhCuoWYhZNOx93pn662Kq0wr3dOFKt vtBvZ7iO7Oir/HRm0iGTewopb/E7QC/GKzhYBj8RsiMY3XMc6vZNb/Up070Fsk5Qp1g7uA e4gre2BaZ4EQlobaOo+Q5JS02KJgE/Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-46abvjGbOniKxll4_sOBcA-1; Fri, 06 Mar 2026 03:58:33 -0500 X-MC-Unique: 46abvjGbOniKxll4_sOBcA-1 X-Mimecast-MFC-AGG-ID: 46abvjGbOniKxll4_sOBcA_1772787512 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4837246211bso117391505e9.0 for ; Fri, 06 Mar 2026 00:58:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1772787512; x=1773392312; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TxrEfYB+045MQE9+euU6LuOafMviwFOmlDaX4FfzPLE=; b=S2UdywePzo/RUw1ImUIKzkxqa/6Nbbb1ZFZfor+NF/+mIrZQj/l91A0c2s4OYp3SYg TPjd8TBidt7GDw/9K0sCD2feidQJ2APZzq88jXHY9dOIIN4wXypgu3/AIRFFGx8VnnUy TqwM0WbTKzODg1AyLIXtnotGV5L43cLjG5NIqQbTvpCsGoD2pDeXWBu2E4ZHHQhFuNqI DjMiwA9H1ltw90/KgiWCJrDvC2Evs0j0/oLs1dWo+HHv56L7oYTP9F5Y07kIrJ09XMIn ZT/qUrDKIcPkUI1irA40w8gADLdSPbLMYqQ7eXMhF+31hA7uflljSyduDBmIXDZOEEN6 m0EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772787512; x=1773392312; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TxrEfYB+045MQE9+euU6LuOafMviwFOmlDaX4FfzPLE=; b=GaGSE9JOsrFQnnFix4V6aXFkzOmJ9foe/vNDtjkkH/XjEhKw7Kw6N3iYc4HviUiE/r Xa/yl/7xijiQOx+0IURotX9zPpUlKZ0Y8Ut0uABrC3G2Jx2lmiZKUE1CjEpwpyOieWzP 1IJwdVaYskbc5Gw+qBvBXf7fEwzFD50D2PqozlkZKWrRqZ3oB2yDawlPaYZQN4dA77QG 9ZLBPJSRz5/X0h4hmACoDtKNaADoiVHPgSkJgFdp8eWMhihaK+BL4zMTcuE6YuNrg5z1 rQv/43Nq/IFLmIzKwZta1Kv+4Nkc1M9EocGK1R4vEdDAnIUUZbh2wClGZs6mdJjvgmb7 S4vg== X-Gm-Message-State: AOJu0YzRM/Anv+3ZvMx+6tO5/Kz+8WlPV1GbsqfFm+UZbvX/phuumEZm DvAqkgTE76FNqyJEROcuj27Onxdu3Egv0sH46vWOgSoTK0vuHHPs3lk52nZ9y4gVNVikXbkJaqG jR6UlBaJSQHm3H/yk8XN3aGnc6REqJUifjfMGBcFaxvHAKrzqqJl/RtXSraBuisrGRQ== X-Gm-Gg: ATEYQzyTb0iJ/XnPGtQAbk5roYXZLz0Ebl0LvkmGvBJZfEIRJKFO5EljN4dF9GhWD9V swm2Nylm7/lrF9Z5W9BojxgC7RhFclMqQCEYNanSwebcjvG0u/PLkzE+wG2KLksUOQxzUQqgq7G 4COvYqG/x9R5q3rdc1NFVbtgwB6tRzP1BJFwXVDsZfIDkQzAEAQJlQRJZI3COCd6jQBRkuZ639T +mlXFNJyWNsoHkLxP5QhPNGCT3k0ln2vaAuzDLmx3DFiM1m3z2ur/J/jD4OPOyc9NhCmhuuNfDQ cuZBSxumPHwV14xHX+k1yC1+/cVwTGlukehBsnZa3gci/WD3H4ytftiCjRcvziwdHLZ3N++6HnJ h9CvtscWfT10TwIIw1PtpBbjzQmjbDWQNATbW2+zssqrPIAq2GCeVakM9O+xfyRcWHkkXZBOLQ+ 8U2BPJ/WEr/ine1g0= X-Received: by 2002:a05:600c:8b83:b0:477:fcb:2256 with SMTP id 5b1f17b1804b1-48526957be7mr22259825e9.17.1772787512142; Fri, 06 Mar 2026 00:58:32 -0800 (PST) X-Received: by 2002:a05:600c:8b83:b0:477:fcb:2256 with SMTP id 5b1f17b1804b1-48526957be7mr22259435e9.17.1772787511731; Fri, 06 Mar 2026 00:58:31 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48527681e3fsm19678165e9.6.2026.03.06.00.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 00:58:31 -0800 (PST) Message-ID: <8eb489498632b4e73ce116b59ce7d649453620ef.camel@redhat.com> Subject: Re: [PATCH v6 08/16] sched: Add task enqueue/dequeue trace points From: Gabriele Monaco To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Steven Rostedt , Nam Cao , Juri Lelli , Masami Hiramatsu , Ingo Molnar , K Prateek Nayak , linux-trace-kernel@vger.kernel.org Date: Fri, 06 Mar 2026 09:58:29 +0100 In-Reply-To: <20260225095122.80683-9-gmonaco@redhat.com> References: <20260225095122.80683-1-gmonaco@redhat.com> <20260225095122.80683-9-gmonaco@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Peter, On Wed, 2026-02-25 at 10:51 +0100, Gabriele Monaco wrote: > From: Nam Cao >=20 > Add trace points into enqueue_task() and dequeue_task(). >=20 > Signed-off-by: Nam Cao > Suggested-by: Peter Zijlstra > Reviewed-by: K Prateek Nayak > Co-developed-by: Gabriele Monaco > Signed-off-by: Gabriele Monaco Could I get your Ack to this? Thanks, Gabriele > --- >=20 > Notes: > =C2=A0=C2=A0=C2=A0 V5: > =C2=A0=C2=A0=C2=A0 * Do not fire enqueue tracepoint for delayed enqueues >=20 > =C2=A0include/trace/events/sched.h |=C2=A0 8 ++++++++ > =C2=A0kernel/sched/core.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 | 12 +++++++++++- > =C2=A0kernel/sched/sched.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0 2 ++ > =C2=A03 files changed, 21 insertions(+), 1 deletion(-) >=20 > diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h > index 7b2645b50e78..5844147ec5fd 100644 > --- a/include/trace/events/sched.h > +++ b/include/trace/events/sched.h > @@ -896,6 +896,14 @@ DECLARE_TRACE(sched_set_need_resched, > =C2=A0 TP_PROTO(struct task_struct *tsk, int cpu, int tif), > =C2=A0 TP_ARGS(tsk, cpu, tif)); > =C2=A0 > +DECLARE_TRACE(sched_enqueue, > + TP_PROTO(struct task_struct *tsk, int cpu), > + TP_ARGS(tsk, cpu)); > + > +DECLARE_TRACE(sched_dequeue, > + TP_PROTO(struct task_struct *tsk, int cpu), > + TP_ARGS(tsk, cpu)); > + > =C2=A0#endif /* _TRACE_SCHED_H */ > =C2=A0 > =C2=A0/* This part must be outside protection */ > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 759777694c78..4ca79ff58fca 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -122,6 +122,8 @@ EXPORT_TRACEPOINT_SYMBOL_GPL(sched_compute_energy_tp)= ; > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_entry_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_exit_tp); > =C2=A0EXPORT_TRACEPOINT_SYMBOL_GPL(sched_set_need_resched_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_enqueue_tp); > +EXPORT_TRACEPOINT_SYMBOL_GPL(sched_dequeue_tp); > =C2=A0 > =C2=A0DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); > =C2=A0DEFINE_PER_CPU(struct rnd_state, sched_rnd_state); > @@ -2094,6 +2096,9 @@ unsigned long get_wchan(struct task_struct *p) > =C2=A0 > =C2=A0void enqueue_task(struct rq *rq, struct task_struct *p, int flags) > =C2=A0{ > + if (trace_sched_enqueue_tp_enabled() && !(flags & ENQUEUE_DELAYED)) > + trace_sched_enqueue_tp(p, rq->cpu); > + > =C2=A0 if (!(flags & ENQUEUE_NOCLOCK)) > =C2=A0 update_rq_clock(rq); > =C2=A0 > @@ -2120,6 +2125,8 @@ void enqueue_task(struct rq *rq, struct task_struct= *p, > int flags) > =C2=A0 */ > =C2=A0inline bool dequeue_task(struct rq *rq, struct task_struct *p, int = flags) > =C2=A0{ > + int ret; > + > =C2=A0 if (sched_core_enabled(rq)) > =C2=A0 sched_core_dequeue(rq, p, flags); > =C2=A0 > @@ -2136,7 +2143,10 @@ inline bool dequeue_task(struct rq *rq, struct > task_struct *p, int flags) > =C2=A0 * and mark the task ->sched_delayed. > =C2=A0 */ > =C2=A0 uclamp_rq_dec(rq, p); > - return p->sched_class->dequeue_task(rq, p, flags); > + ret =3D p->sched_class->dequeue_task(rq, p, flags); > + if (trace_sched_dequeue_tp_enabled() && !(flags & DEQUEUE_SLEEP)) > + trace_sched_dequeue_tp(p, rq->cpu); > + return ret; > =C2=A0} > =C2=A0 > =C2=A0void activate_task(struct rq *rq, struct task_struct *p, int flags) > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index b82fb70a9d54..a83177742603 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -2944,6 +2944,8 @@ static inline void sub_nr_running(struct rq *rq, > unsigned count) > =C2=A0 > =C2=A0static inline void __block_task(struct rq *rq, struct task_struct *= p) > =C2=A0{ > + trace_sched_dequeue_tp(p, rq->cpu); > + > =C2=A0 if (p->sched_contributes_to_load) > =C2=A0 rq->nr_uninterruptible++; > =C2=A0