From: James Morse <james.morse@arm.com>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will@kernel.org, steve.capper@arm.com,
linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
vladimir.murzin@arm.com, mark.rutland@arm.com,
tglx@linutronix.de
Subject: Re: [PATCH] arm64: hibernate: check pgd table allocation
Date: Mon, 14 Oct 2019 18:58:09 +0100 [thread overview]
Message-ID: <8ebe7877-93d3-dfd0-8ea3-2a4815b4f154@arm.com> (raw)
In-Reply-To: <20191014144824.159061-1-pasha.tatashin@soleen.com>
Hi Pavel,
On 14/10/2019 15:48, Pavel Tatashin wrote:
> There is a bug in create_safe_exec_page(), when page table is allocated
> it is not checked that table is allocated successfully:
>
> But it is dereferenced in: pgd_none(READ_ONCE(*pgdp)). Check that
> allocation was successful.
>
> Fixes: 82869ac57b5d ("arm64: kernel: Add support for hibernate/suspend-to-disk")
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com>
> ---
Reviewed-by: James Morse <james.morse@arm.com>
Thanks,
James
prev parent reply other threads:[~2019-10-14 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 14:48 Pavel Tatashin
2019-10-14 14:53 ` Pavel Tatashin
2019-10-14 17:58 ` James Morse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ebe7877-93d3-dfd0-8ea3-2a4815b4f154@arm.com \
--to=james.morse@arm.com \
--cc=catalin.marinas@arm.com \
--cc=jmorris@namei.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pasha.tatashin@soleen.com \
--cc=sashal@kernel.org \
--cc=steve.capper@arm.com \
--cc=tglx@linutronix.de \
--cc=vladimir.murzin@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®