From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A123C0650E for ; Wed, 3 Jul 2019 13:58:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3DB1C218A3 for ; Wed, 3 Jul 2019 13:58:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="SpfH1iV5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbfGCN6e (ORCPT ); Wed, 3 Jul 2019 09:58:34 -0400 Received: from node.akkea.ca ([192.155.83.177]:59766 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725847AbfGCN6d (ORCPT ); Wed, 3 Jul 2019 09:58:33 -0400 Received: by node.akkea.ca (Postfix, from userid 33) id B606E4E204B; Wed, 3 Jul 2019 13:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1562162312; bh=UHIUaVsVDuz0yZjRB09x+PshwKLK6UHG+Qvlw7TIC58=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=SpfH1iV5gPGx0vLKUhzKfEvLCQNmPLkUyJlyLG3cW8wfWxKgAPFOR+aGMwiCtP5qV S+TSC/nxxbenLnoRMlQrsfUB2MXIUMeQmR2zwJ5dfti+3LJyKCNajnNEm6XcjeReqg E8fKNY+j2dOhPI2vMmPmQD/ssHXJFGIGur51ElBA= To: Daniel Baluta Subject: Re: [PATCH v3] arm64: dts: imx8mq: Add sai3 and sai6 nodes X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 03 Jul 2019 07:58:32 -0600 From: Angus Ainslie Cc: Andra Danciu , Shawn Guo , Rob Herring , Mark Rutland , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , Lucas Stach , Abel Vesa , Anson Huang , andrew.smirnov@gmail.com, Carlo Caione , =?UTF-8?Q?Guido_G=C3=BCnther?= , Devicetree List , linux-arm-kernel , Linux Kernel Mailing List In-Reply-To: References: <20190702132353.18632-1-andradanciu1997@gmail.com> <9ea5109f8645c3f27a9e350c5f9b2d4c@www.akkea.ca> <9e196ce51eac9ce9c327198c4a2911a8@www.akkea.ca> Message-ID: <8ebfeaae8541132ad39e4109d135cd5f@www.akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 2019-07-03 07:25, Daniel Baluta wrote: > On Wed, Jul 3, 2019 at 4:12 PM Angus Ainslie wrote: >> >> Hi Daniel, >> >> On 2019-07-03 07:10, Daniel Baluta wrote: >> > On Wed, Jul 3, 2019 at 4:01 PM Angus Ainslie wrote: >> >> >> >> Hi Andra, >> >> >> >> I tried this out on linux-next and I'm not able to record or play >> >> sound. >> >> >> >> I also added the sai2 entry to test out our devkit and get a PCM >> >> timeout >> >> with that. >> > >> > Hi Angus, >> > >> > There are still lots of SAI patches that need to be upstream. Me and >> > Andra >> > will be working on that over this summer. >> > >> >> >> >> On 2019-07-02 07:23, Andra Danciu wrote: >> >> > SAI3 and SAI6 nodes are used to connect to an external codec. >> >> > They have 1 Tx and 1 Rx dataline. >> >> > >> >> > Cc: Daniel Baluta >> >> > Signed-off-by: Andra Danciu >> >> > --- >> >> > Changes since v2: >> >> > - removed multiple new lines >> >> > >> >> > Changes since v1: >> >> > - Added sai3 node because we need it to enable audio on pico-pi-8m >> >> > - Added commit description >> >> > >> >> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 29 >> >> > +++++++++++++++++++++++++++++ >> >> > 1 file changed, 29 insertions(+) >> >> > >> >> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> >> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> >> > index d09b808eff87..736cf81b695e 100644 >> >> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> >> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> >> > @@ -278,6 +278,20 @@ >> >> > #size-cells = <1>; >> >> > ranges = <0x30000000 0x30000000 0x400000>; >> >> > >> >> > + sai6: sai@30030000 { >> >> > + compatible = "fsl,imx8mq-sai", >> >> >> >> I don't find this compatible string in sound/soc/fsl/fsl_sai.c. Aren't >> >> the registers at a different offset from "fsl,imx6sx-sai". >> > >> > Yes, you are right on this. We are trying to slowly push all our >> > internal-tree >> > patches to mainline. Obviously, with started with low hanging fruits, >> > DTS >> > nodes and small SAI fixes. >> > >> > Soon, we will start to send patches for SAI IP ipgrade for imx8. >> > >> >> >> >> How is this supposed to work ? >> >> >> > >> > For the moment it won't work unless we will upstream all our SAI >> > internal patches. >> > But we will get there hopefully this summer. >> > >> >> Shouldn't a working driver be upstream before enabling it in the >> devicetree ? > > I see your point here and maybe your suggestion is the ideal > way to do things. > > Anyhow, I don't see a problem with adding the node in dts > because CONFIG_FSL_SAI is not set in the default config. > I think the assumption is that devices in the devicetree are tested and working. That's not currently the case for sai on imx8mq. > We try to speedup the upstreaming process giving the fact > that SAI patches will go through audio maintainer's tree and > the DTS patches will most likely go through Shawn's tree. > Ok I can see them being committed concurrently but I haven't even seen a v1 of the sai patches. Thanks Angus > thanks, > Daniel.