From: Dave Hansen <dave.hansen@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, Thomas Huth <thuth@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Nicolas Schier <nicolas@fjasle.eu>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Remove the arch_calc_vm_prot_bits() macro from the uapi
Date: Thu, 6 Jul 2023 13:30:31 -0700 [thread overview]
Message-ID: <8ec7f329-a0a3-7631-ba05-225944b19771@intel.com> (raw)
In-Reply-To: <2d9bb146-e1ec-4fc2-a4bc-e1c67cfda723@app.fastmail.com>
On 7/6/23 13:22, Arnd Bergmann wrote:
> On Thu, Jul 6, 2023, at 21:02, Thomas Huth wrote:
>> The arch_calc_vm_prot_bits() macro uses VM_PKEY_BIT0 etc. which are
>> not part of the uapi, so the macro is completely useless for userspace.
>> It is also hidden behind the CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS
>> config switch which we shouldn't expose to userspace. Thus let's move
>> this macro into a new internal header instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Fixes: 8f62c883222c9 ("x86/mm/pkeys: Add arch-specific VMA protection bits")
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> It looks like this was introduced right after the uapi split,
> and probably is the result of an incorrect rebase.
Yeah, I bet I just glossed over the "uapi" in the path.
Is this causing any real problems? Or is it OK to just send it along
during the next merge window with other random cleanups?
next prev parent reply other threads:[~2023-07-06 20:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 19:02 Thomas Huth
2023-07-06 20:22 ` Arnd Bergmann
2023-07-06 20:30 ` Dave Hansen [this message]
2023-07-06 20:36 ` Arnd Bergmann
2023-07-07 6:48 ` Thomas Huth
2023-07-07 9:29 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ec7f329-a0a3-7631-ba05-225944b19771@intel.com \
--to=dave.hansen@intel.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=nicolas@fjasle.eu \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®