From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753105AbdLHUNA (ORCPT ); Fri, 8 Dec 2017 15:13:00 -0500 Received: from mout.web.de ([212.227.15.3]:55230 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbdLHUM5 (ORCPT ); Fri, 8 Dec 2017 15:12:57 -0500 Subject: [PATCH 2/3] serial: max3100: Improve a size determination in max3100_probe() From: SF Markus Elfring To: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML , kernel-janitors@vger.kernel.org References: <82c37f92-b4ee-8bea-bd10-de3b6691151d@users.sourceforge.net> Message-ID: <8eca9ac5-96c3-8825-5c2b-a74b3dafcf9c@users.sourceforge.net> Date: Fri, 8 Dec 2017 21:12:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <82c37f92-b4ee-8bea-bd10-de3b6691151d@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:YBPLQjvW6KZ+/zQitYRmQ8+OsE19YSdJv4fYt3CenhbryNVtwgX c6Naqr9VK5wd5W9osmRW2Oq2TqXnaCp388hbs/ofaB2t/yWhm/tmu/EzwTPE7jA2xAopKxi nXGNBoKIOun7jb92xot6OtvjKkKPuYeKxQ+QKzm8PwFjkWB5DP1Ff2NPdZShSlZQvJDRZEk 3wo8O8FexTgI8M3QmOqzQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:FySPfnsi+N0=:zXxZPOVFebW1qAqav+WiDE cBkxpv7fruRca9ClEdCILRtD4nNZodlRXeyxwoslQtM5xfHqM7bYgQXVp6qA0sz52pqxLOtIJ XOQ8a4v7j3EoO5fp8J1Wxnza28cjqF8y2HuuyJhL6xZbsrCxzk2R9r6EhxoUm3AQR+a5uCEqD 2uix+y43JPy95WLDdsPOB/W3d27WlWt53IHlm6Ur7t4sIgzJpuluEX68Ctkm7ixGZ60T+KbYb k/oygDkTEucuHxDCauGitlfHUOnOuHqpVaom1S+Q0Pjp+OZk+Kid5jamMPhxH0Qyr2Tx6jz/y PUi0gkwpNhAaIhXgdVlhpX74OZJmIb9ynyzs2+J1I5PoD/KWtmjIKSdtezax0YXWInpIojDko cSItuZpC5WTkrzfII8qecAY1VI4u8GQeFCh4a235DBEm1SLRky1o21qJ73Y6cHq+n3WptDsKJ tp5RSZFYJmvflpHZ5G7CtGnrkmaBoqH9wiIjITgB+1uaSsXfe8QED+k2J9QEMEOo1Do4AG5Ly dIhiw79BrZ3cCwMgmc2SdCb04i7ijicaQSl/xydc2cVujqZXqiceGwsET5DbzQX7gWkWjtVo5 JB5ewmEVfOXeWmHKR/8jtVUcGfutT2sn7EAOrpL4lkKRD2hzS2Luc3hKg0irNtAYwNo+//pqU qxlGoyCK70bVIM4V2PO16L5z8c8ZwHvpSFr9IHKjf9yvAM9Qc5kpxXXK2cnCrTA8mo0i8wCJ0 aaxbHFNeg4KdR/BViDKP/8IYGdZ45hYCC0GAv7FAwfPVOxHWqVE2tppCGdbzYeQTMJKyDbYIT hUPH36h82CkdZ9QKLEBJSjr5biIvTi47ysAr3GkUBSctn94U1E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 8 Dec 2017 20:32:09 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/serial/max3100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c index b7b7e6582f3f..00c0e650537d 100644 --- a/drivers/tty/serial/max3100.c +++ b/drivers/tty/serial/max3100.c @@ -761,7 +761,7 @@ static int max3100_probe(struct spi_device *spi) return -ENOMEM; } - max3100s[i] = kzalloc(sizeof(struct max3100_port), GFP_KERNEL); + max3100s[i] = kzalloc(sizeof(*max3100s[i]), GFP_KERNEL); if (!max3100s[i]) { mutex_unlock(&max3100s_lock); return -ENOMEM; -- 2.15.1