From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751209AbeAVQdk (ORCPT <rfc822;w@1wt.eu>);
        Mon, 22 Jan 2018 11:33:40 -0500
Received: from esa6.hgst.iphmx.com ([216.71.154.45]:42606 "EHLO
        esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751028AbeAVQdi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Jan 2018 11:33:38 -0500
X-IronPort-AV: E=Sophos;i="5.46,397,1511798400";
   d="scan'208";a="70160509"
Subject: Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros
To: Johannes Thumshirn <jthumshirn@suse.de>, Jens Axboe <axboe@fb.com>
Cc: Linux Block Layer Mailinglist <linux-block@vger.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
References: <20180122075348.6974-1-jthumshirn@suse.de>
From: Bart Van Assche <bart.vanassche@wdc.com>
Message-ID: <8ecbf7d2-b056-cd93-ebf3-b4eaf22f7abe@wdc.com>
Date: Mon, 22 Jan 2018 08:33:37 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180122075348.6974-1-jthumshirn@suse.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/21/18 23:53, Johannes Thumshirn wrote:
> -	dprintk("map hdr %llx/%u %llx/%u\n", (unsigned long long) hdr->dout_xferp,
> +	pr_debug("map hdr %llx/%u %llx/%u\n",
> +		 (unsigned long long) hdr->dout_xferp,
>   		hdr->dout_xfer_len, (unsigned long long) hdr->din_xferp,
>   		hdr->din_xfer_len);

Should the indentation of the arguments have been adjusted?

> @@ -299,7 +292,7 @@ static void bsg_rq_end_io(struct request *rq, blk_status_t status)
>   	struct bsg_device *bd = bc->bd;
>   	unsigned long flags;
>   
> -	dprintk("%s: finished rq %p bc %p, bio %p\n",
> +	pr_debug("%s: finished rq %p bc %p, bio %p\n",
>   		bd->name, rq, bc, bc->bio);

Same question here ...

Thanks,

Bart.