From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbdGDHcl (ORCPT ); Tue, 4 Jul 2017 03:32:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:49709 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751879AbdGDHck (ORCPT ); Tue, 4 Jul 2017 03:32:40 -0400 Subject: Re: [PATCH v6 14/18] xen/pvcalls: disconnect and module_exit To: Stefano Stabellini , xen-devel@lists.xen.org Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, Stefano Stabellini References: <1499116119-15638-1-git-send-email-sstabellini@kernel.org> <1499116119-15638-14-git-send-email-sstabellini@kernel.org> From: Juergen Gross Message-ID: <8ecc851e-0be2-6dde-6a25-1236acbf70c6@suse.com> Date: Tue, 4 Jul 2017 09:32:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499116119-15638-14-git-send-email-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/17 23:08, Stefano Stabellini wrote: > Implement backend_disconnect. Call pvcalls_back_release_active on active > sockets and pvcalls_back_release_passive on passive sockets. > > Implement module_exit by calling backend_disconnect on frontend > connections. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrovsky@oracle.com > CC: jgross@suse.com > --- > drivers/xen/pvcalls-back.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c > index 9f4247f..71a42fc 100644 > --- a/drivers/xen/pvcalls-back.c > +++ b/drivers/xen/pvcalls-back.c > @@ -807,6 +807,42 @@ static int backend_connect(struct xenbus_device *dev) > > static int backend_disconnect(struct xenbus_device *dev) > { > + struct pvcalls_fedata *fedata; > + struct sock_mapping *map, *n; > + struct sockpass_mapping *mappass; > + struct radix_tree_iter iter; > + void **slot; > + > + > + fedata = dev_get_drvdata(&dev->dev); > + > + down(&fedata->socket_lock); > + list_for_each_entry_safe(map, n, &fedata->socket_mappings, list) { > + list_del(&map->list); > + pvcalls_back_release_active(dev, fedata, map); > + } > + > + radix_tree_for_each_slot(slot, &fedata->socketpass_mappings, &iter, 0) { > + mappass = radix_tree_deref_slot(slot); > + if (!mappass) > + continue; > + if (radix_tree_exception(mappass)) { > + if (radix_tree_deref_retry(mappass)) > + slot = radix_tree_iter_retry(&iter); > + } else { > + radix_tree_delete(&fedata->socketpass_mappings, mappass->id); > + pvcalls_back_release_passive(dev, fedata, mappass); > + } > + } > + up(&fedata->socket_lock); > + > + xenbus_unmap_ring_vfree(dev, fedata->sring); > + unbind_from_irqhandler(fedata->irq, dev); Swap above two lines to avoid irq being handled after releasing ring? Juergen