From: Vaishnav Achath <vaishnav.a@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<mripard@kernel.org>, <mchehab@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<laurent.pinchart@ideasonboard.com>,
<sakari.ailus@linux.intel.com>, <tomi.valkeinen@ideasonboard.com>
Cc: <linux-kernel@vger.kernel.org>, <bparrot@ti.com>,
<niklas.soderlund+renesas@ragnatech.se>, <j-luthra@ti.com>,
<devarsht@ti.com>, <praneeth@ti.com>, <u-kumar1@ti.com>,
<vigneshr@ti.com>, <nm@ti.com>, <martyn.welch@collabora.com>
Subject: Re: [PATCH v7 13/13] media: dt-bindings: Convert Cadence CSI2RX binding to YAML
Date: Mon, 20 Mar 2023 11:04:24 +0530 [thread overview]
Message-ID: <8ed02bb8-b1a3-519f-d0c6-d36756e7e2c2@ti.com> (raw)
In-Reply-To: <f97ed61d-71d0-f05a-e4f8-abae8f9fbdd8@linaro.org>
Hi Krzysztof,
On 15/03/23 13:15, Krzysztof Kozlowski wrote:
> On 14/03/2023 12:55, Vaishnav Achath wrote:
>> From: Pratyush Yadav <p.yadav@ti.com>
>>
>> Convert the Cadence CSI2RX binding to use YAML schema.
>>
>> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
>> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> ---
>>
>> (no changes since v5)
>>
>
> So it seems your patchset is not bisectable. Fix this and test
> bisectability. All patchsets are expected to be fully bisectable.
>
Thank you for the review, I will fix for bisect and address the rest of your
feedback in next revision and fix the order of bindings vs driver changes (will
wait for few more days for more feedback on the main j721e-csirx driver).
--
Thanks and Regards,
Vaishnav
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-03-20 5:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 11:55 [PATCH v7 00/13] CSI2RX support on J721E Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 01/13] media: cadence: csi2rx: Unregister v4l2 async notifier Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 02/13] media: cadence: csi2rx: Cleanup media entity properly Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 03/13] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 04/13] media: cadence: csi2rx: Add external DPHY support Vaishnav Achath
2023-03-31 13:19 ` Sakari Ailus
2023-03-14 11:55 ` [PATCH v7 05/13] media: cadence: csi2rx: Soft reset the streams before starting capture Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 06/13] media: cadence: csi2rx: Set the STOP bit when stopping a stream Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 07/13] media: cadence: csi2rx: Fix stream data configuration Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 08/13] media: cadence: csi2rx: Populate subdev devnode Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 09/13] media: cadence: csi2rx: Add link validation Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 10/13] media: ti: Add CSI2RX support for J721E Vaishnav Achath
2023-03-20 12:51 ` Jai Luthra
2023-03-24 18:14 ` Laurent Pinchart
2023-03-28 8:19 ` Vaishnav Achath
2023-04-04 11:43 ` Tomi Valkeinen
2023-03-31 13:27 ` Sakari Ailus
2023-03-14 11:55 ` [PATCH v7 11/13] media: dt-bindings: Make sure items in data-lanes are unique Vaishnav Achath
2023-03-14 11:55 ` [PATCH v7 12/13] media: dt-bindings: Add DT bindings for TI J721E CSI2RX driver Vaishnav Achath
2023-03-14 14:10 ` Rob Herring
2023-03-15 7:44 ` Krzysztof Kozlowski
2023-03-14 11:55 ` [PATCH v7 13/13] media: dt-bindings: Convert Cadence CSI2RX binding to YAML Vaishnav Achath
2023-03-15 7:45 ` Krzysztof Kozlowski
2023-03-20 5:34 ` Vaishnav Achath [this message]
2023-03-23 19:36 ` [PATCH v7 00/13] CSI2RX support on J721E Martyn Welch
2023-03-28 6:01 ` Jai Luthra
2023-03-29 15:17 ` Martyn Welch
2023-04-04 8:44 ` Tomi Valkeinen
2023-06-22 9:18 ` Julien Massot
2023-06-22 11:04 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed02bb8-b1a3-519f-d0c6-d36756e7e2c2@ti.com \
--to=vaishnav.a@ti.com \
--cc=bparrot@ti.com \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martyn.welch@collabora.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®