From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A731634D91F for ; Sat, 26 Sep 2026 16:00:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790438449; cv=none; b=XAzf4HGkFBm3EkMi424B6BdTLFK4Xie9XtIqjmeHdZq3RAgopqBdhct8Ky7ysQbsnI8oR77Aorm8SSMHDo+TBtKVcGo2STusTBMOYMCrPvt8ndGEWyM9HSwm29F5Q1eOhSCBTKFJVpPnyFcBAvzj3bq7pdEuI49X/VJ7M1Js57w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790438449; c=relaxed/simple; bh=bVUzZjxHMO8CHtvlSqa0+RggUMRBNcvulOYT5UeurPQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iqfrO31LWq/FdTCQXdUWL4WJneRGctpsuo5fR0p7pig+j9kpijud+Wp+jXSfe1IBE8kBtY/9kDYFplQ8FF/eMUZejT5k8DLZro/D8QnB64Q1jD8EvxA9w68Pqe3Rm7xjq5QWdx3C0leuy1jum/X2qBUsVUnqHm/CXgzFjkx1cFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=1JjUSgZf; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="1JjUSgZf" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id CA1E21A0FD0; Sat, 26 Sep 2026 16:00:44 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 8E54260749; Sat, 26 Sep 2026 16:00:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3E4BD102F1E54; Sat, 26 Sep 2026 18:00:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1790438441; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=mF1te5gqabP+5Yeutw1bTB4Li95rX1u1z21hvfD/sjY=; b=1JjUSgZf+1Qlrz9yaHy7YnGvulxuyne9Db1Z3hoIbBILjgLKvagOMrh6zXm+LtmeoyVAxt rE2m1OPP15bj1XPYkOEbcoxbID+IuvnZ84GmGO5sTu+2BTNuOzrefdZT1a6zOKZD55mwf2 wdFfbgIYyvhqLsOmXhC6cKKHohYQ4QtfL8G9bjg4Zcf2j2AsxPLgx7xrUS6x8oOBUJ5AX4 AESgI0lGEsivAPNmPxiednYXeSn+xeykI5WfkPM7O6P8suAq59Ijm5QUHSXRSRR79gad81 SGTzRMyA2VZSktD6UMrxwbPibAFENNDjhx/wV/ZNquwjh7V8LZRcoJP+eRQf7Q== Message-ID: <8ed1298a-4c29-4db3-b76e-c8d34f91b4c9@bootlin.com> Date: Sat, 26 Sep 2026 18:00:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 00/15] net: stmmac: preserve datapath state across MTU and resume failures To: James Hilliard , Russell King , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Joakim Zhang , "Russell King (Oracle)" , Andrew Lunn , Maxime Coquelin , Alexandre Torgue , Christian Marangi , Tiezhu Yang , Huacai Chen , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Serge Semin , Suraj Jaiswal , Richard Cochran , Joao Pinto , Vladimir Oltean , Ong Boon Leong , Voon Weifeng , "Song, Yoong Siang" , Linus Walleij , Martin Blumenstingl , Magnus Karlsson , Maciej Fijalkowski , Simon Horman , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Thierry Reding , Jonathan Hunter , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Eric Dumazet Cc: Richard Genoud , Alastair D'Silva , Maxime Ripard , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org, ZhaoJinming , Lorenzo Bianconi , Ding Hui , linux-tegra@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20260926-submit-stmmac-reset-fixes-v1-v4-0-ec1c0250b3c9@gmail.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260926-submit-stmmac-reset-fixes-v1-v4-0-ec1c0250b3c9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hello James, On 9/26/26 17:48, James Hilliard wrote: > Keep the stmmac datapath coherent after failed MTU changes or hardware > resume without changing the interface's administrative state. Retain the > working MTU configuration for rollback, and allow ordinary down/up recovery > when hardware cannot be restored. > > The fifteen patches put independent fixes and lifetime prerequisites ahead > of the retained-ring MTU transaction: > > 1. Correct the WoL/safety IRQ unwind order. > 2. Reuse the MDIO reset GPIO across repeated resets. > 3. Allow phylink_stop() to finish a suspended instance. > 4. Freeze deferred AF_XDP pool teardown before device system suspend. > 5. Serialize PHC changes and cache reset-sensitive timestamp settings. > 6. Keep normal-size MTU changes running, including supported AF_XDP MTUs. > 7. Unwind partial DMA allocations and fix saved RX skb ownership. > 8. Keep DMA configurations and IRQ contexts at stable addresses, and > drain timer producers before cancelling their timers. > 9. Track datapath and power ownership across MTU, XDP and ethtool reopen > failures, including noirq clock handling and unpowered-access guards. > 10. Use the tracked restart for XSK pool changes. > 11. Restore TC filters, steering, preemption mapping and EST before DMA. > 12. Allow independent references to AF_XDP DMA mappings and UMEM pages. > 13. Retain DMA memory until hardware confirms shutdown or reset. > 14. Prepare device-local interrupt masking and DMA-handler quiescence. > 15. Retain rings and IRQ registrations across jumbo MTU replacement. Please look at the mailing list, several of these patches are already being worked on and have gone through multiple iterations and reviews. Thanks :) Maxime