Re: [PATCH] drm/amdgpu: fix link error for !PM_SLEEP

["Limonciello, Mario" <Mario.Limonciello@amd.com>]

On 7/14/25 10:01 AM, Arnd Bergmann wrote:
> On Mon, Jul 14, 2025, at 16:59, Limonciello, Mario wrote:
>> On 7/14/25 3:16 AM, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> When power management is not enabled in the kernel build, the newly
>>> added hibernation changes cause a link failure:
>>>
>>> arm-linux-gnueabi-ld: drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o: in function `amdgpu_pmops_thaw':
>>> amdgpu_drv.c:(.text+0x1514): undefined reference to `pm_hibernate_is_recovering'
>>>
>>> Make the power management code in this driver conditional on
>>> CONFIG_PM and CONFIG_PM_SLEEP
>>>
>>> Fixes: 530694f54dd5 ("drm/amdgpu: do not resume device in thaw for normal hibernation")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> We're going to fix it using this stub instead.
>>
>> https://lore.kernel.org/linux-pm/20250712233715.821424-1-superm1@kernel.org/
>>
>> It's in drm-misc-next as of this weekend and it should show up in
>> linux-next in the next day or two.
> 
> That patch makes sense as well, but I think mine is useful as an
> improvement even if it doesn't address a link failure but only
> reduces the object size by reducing the amount of dead code.
> 
>        Arnd

Thanks for pointing it out.  You're right.  I'll get it picked up.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>