From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86350389118 for ; Mon, 29 Jun 2026 05:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711267; cv=none; b=D0FLqE4dgomhWQiS1fJO0yvG5MylUMkLPFuP4Jx3jG4F6xfw4MXM7fc9//tMNYze/huU8zP7mfGhmPbhGf9N2rmNeMJZnM+r0rrf32+wBLphlRVk/yCKoaL2TcWG/Y2HIOQ/+vUQY695yl2105ECYaqoDZNAf5fsuBgUNo9Lbk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782711267; c=relaxed/simple; bh=a86f8R4t+fLWwdQI0IgFLXsc0PI99dNs9xJPvkEy//M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qEk8rj4N0Eme6TPbZr79YM/L4XmsY0NaUOA1cX4fXj3Ox0kN13iwjxY8bzCgsrbJGqx8NLNvev5USmRdkFF8i5MRX+CkNifgX8k9YuVhdFrJ5xMDRj3aBrCwqcxAc1On8c2DELYQMvHp0+czB/4yqA65NRV8AT1jCk0+vDW7Ftk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=Liaht61i; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="Liaht61i" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C94D71A2D; Sun, 28 Jun 2026 22:34:11 -0700 (PDT) Received: from [10.164.19.15] (unknown [10.164.19.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EBC1B3F836; Sun, 28 Jun 2026 22:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782711256; bh=a86f8R4t+fLWwdQI0IgFLXsc0PI99dNs9xJPvkEy//M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Liaht61iOTcEOGbuAo7kQgdPOulUm68gQ1rGBf1CiX6T62Vbs4U/kRTa91X9IbaH9 pMujISxup9Dhkr5Lra9KRo0/uaUOzDcxazn3eOYj5aYMffHQ68077Vfoh2P0QVHHTF bQWVYP1ScOX0/N405atZRUOj8Oxz40uoya7QKXhU= Message-ID: <8ed36f5b-7421-4dcc-9ea1-29e8f0f15824@arm.com> Date: Mon, 29 Jun 2026 11:04:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/6] arm64/hugetlb: Extend batching of multiple CONT_PTE in a single PTE setup To: Wen Jiang , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, urezki@gmail.com Cc: baohua@kernel.org, Xueyuan.chen21@gmail.com, rppt@kernel.org, david@kernel.org, ryan.roberts@arm.com, anshuman.khandual@arm.com, ajd@linux.ibm.com, linux-kernel@vger.kernel.org, jiangwen6@xiaomi.com, shanghaoqiang@xiaomi.com References: <20260618084726.1070022-1-jiangwen6@xiaomi.com> <20260618084726.1070022-2-jiangwen6@xiaomi.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20260618084726.1070022-2-jiangwen6@xiaomi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/06/26 2:17 pm, Wen Jiang wrote: > From: "Barry Song (Xiaomi)" > > For sizes aligned to CONT_PTE_SIZE and smaller than PMD_SIZE, > we can handle CONT_PTE_SIZE groups together. > > Signed-off-by: Barry Song (Xiaomi) > Signed-off-by: Wen Jiang > Tested-by: Xueyuan Chen > --- > arch/arm64/mm/hugetlbpage.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index a42c05cf56408..c4d8b226126cb 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -110,6 +110,12 @@ static inline int num_contig_ptes(unsigned long size, size_t *pgsize) > contig_ptes = CONT_PTES; > break; > default: > + if (size > 0 && size < PMD_SIZE && > + IS_ALIGNED(size, CONT_PTE_SIZE)) { > + contig_ptes = size >> PAGE_SHIFT; > + *pgsize = PAGE_SIZE; Nit: *pgsize update can go before contig_ptes, to keep the pattern elsewhere. Reviewed-by: Dev Jain > + break; > + } > WARN_ON(!__hugetlb_valid_size(size)); > } > > @@ -359,6 +365,10 @@ pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, vm_flags_t flags) > case CONT_PTE_SIZE: > return pte_mkcont(entry); > default: > + if (pagesize > 0 && pagesize < PMD_SIZE && > + IS_ALIGNED(pagesize, CONT_PTE_SIZE)) > + return pte_mkcont(entry); > + > break; > } > pr_warn("%s: unrecognized huge page size 0x%lx\n",