From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from meesny.iki.fi (meesny.iki.fi [195.140.195.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C830C579805 for ; Tue, 22 Sep 2026 17:24:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=195.140.195.201 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790097896; cv=pass; b=Zns2M/oZFXyyZNSgDiKQLb7TBOPd2j/rWZxhrjUgZpzQrOOo1Mp2yP79vFXCl9AsJHQD1hz9ly1tGlrAAjSWCFpiPyYiCr5ACNgZx+ObKiu3kYMVzVnUyomAM7XFhvrVdcM6jVmWNAd/0LNW3beMtp5as/wCgx9vM/Z7DO9IhiQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790097896; c=relaxed/simple; bh=HHFUJjRx9PILiAJgW+PPi+mo2/L/wFoyjksNl22C0XI=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=nfZGLiq164yZXSvURqA+czZdYJogYzQSlN7SbmqzkyzzmndM4OmCrYfgxg4zGhONaH/30rHlZVruo+FP3ewfmWYgL0rgy6etbsImX2vc20GbsLP2mY4/dIKGFOTzUIafcG7EAyke0dIxzbPLtrzXzqHdvh3fG00gXyn+rxLxJiU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi; spf=pass smtp.mailfrom=iki.fi; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b=HHHAi5pT; arc=pass smtp.client-ip=195.140.195.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iki.fi Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iki.fi Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=iki.fi header.i=@iki.fi header.b="HHHAi5pT" Received: from fauth-c1-smtp.messagingengine.com (fauth-c1-smtp.messagingengine.com [204.75.18.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jmtilli) by meesny.iki.fi (Postfix) with ESMTPSA id 4hq6RL3rmpzyQq; Tue, 22 Sep 2026 20:24:46 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1790097887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HDJ3kpUsd0EZIs2+o3fDTdQpM9JrBURLXPpPlz86z4A=; b=HHHAi5pTIyfNLPhHWJffqmLZ0tYOg/8rNLgWU9Pak2sgCSXEV5H8chEtoMa7IUZG25vzQZ iexYcoQ5qMrEXOuXDcdWzEo1UN+iGHeZUd12KhfqJ2ZYBh9s0yWj0RMlZhkvnmSW2V618U B7xWUaJIRYQ2ZTix4eS5vdl7r/0JhzI= ARC-Seal: i=1; a=rsa-sha256; d=iki.fi; s=meesny; cv=none; t=1790097887; b=npOCs6kg6dbMUd5ONKwNo34npWd+kgAp1JDU0xo7LqMtlWxBJPO8mfrbcg9DogoGJqUK8V 0P5et+HdKL8YAnagSSVNWkvdAotcE/FceXukAOY7P5sQt1rF2KvPMtI4VhZ3n31ODvhVRi m3dact53s4GGBsJMcVj3jgFy1825y5s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=meesny; t=1790097887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HDJ3kpUsd0EZIs2+o3fDTdQpM9JrBURLXPpPlz86z4A=; b=Ib79IEXVQMinzM81lAzeJY4pnozl1wdKlWWFFhhatOltbtUpnI4o0mNiSreTN81HRdYdq8 TFSDP3fMl+x6JKv+R3/JLKnq7aOT+FRoF+evsGrGUvTcxEyJYt+F8NH800aTgMaKLjZhoG u+fpJTYWBd09Ayct7Ult/MXi2/r4Bpk= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=jmtilli smtp.mailfrom=juha-matti.tilli@iki.fi Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfauth.ams.internal (Postfix) with ESMTP id 79ED4198004A; Tue, 22 Sep 2026 13:24:45 -0400 (EDT) Received: from ams-imap-13 ([10.64.2.33]) by ams-compute-02.internal (MEProxy); Tue, 22 Sep 2026 13:24:45 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTExBE7TvAv+Zlf649UCtMysU4jgxLizrL/IBJYd7zHzxzT0E//+kCYwyYrOvTbdX7 thiX6uwyBdaqKYLIfeZJ3RcvzLm/3F257FpQsxcIGc0IR8IeUn+JveJzBAUm26dusdHpHb 4rCDP6SW6PPxmAGHkJcp96m2+dumXAK9SzB1cqw6pj3h/jjfwcGQLm32LmrT4r8T0dyLe6 LJng2/+kgbJToCdXVDqepDpT2QJ7XXUfsqi34Egv4IOJoLl14yXPc6ANLbyChYO7LNigZt jwUsH17joUGk+1NTUjGVgWQTPO0oLx3fVKrwmfDei61P4V0PWrnvZXm79oiL4aLRajiMPp mSHnzPlhvLSufXQNeYF6/Ba9VLhI6tZCz54Iz1NKZgs3fSxXq3eYBasca9fA+B8bAF8Wgs UiKvZD1UVDYM3Zw5plFc57o4OA1N8YaSnibSXFrs5/GbuEsHfD14izqu+QWqh5nukYUVBA Y4nc7u5V9DS+k2IB/m2oTQmtoS8g15v7OsBsTYha0Wsh/yf/IbN20v7hHPSSpB6J7yZxwn E74pAgoYA8v9K4jch1QYz8XqdeZlDGOV/m1b/J96h5QpgVEsf3QZdeOYd8l4Btsaz4uhiv TjC9xdad21b1uuwvGdayX4uQsJDh5bas8KDmcN7kYDevZIFYgraxIAWKFRyA X-ME-Proxy: Feedback-ID: i02414972:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 3C3C5F8008B; Tue, 22 Sep 2026 13:24:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: A_PuV4p-mAYk Date: Tue, 22 Sep 2026 20:24:21 +0300 From: "Juha-Matti Tilli" To: "Youssef Samir" , "Manivannan Sadhasivam" , "Manivannan Sadhasivam" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , "Jeff Johnson" Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, "Bjorn Andersson" , "Chris Lew" , "Deepak Kumar Singh" , "Raj Kumar Bhagat" , "Jeff Hugo" Message-Id: <8ed398ba-2ebe-488a-a213-8ca7ecbe861d@app.fastmail.com> In-Reply-To: References: <20260921-qrtr-multi-ep-v2-0-27dd80d841a0@oss.qualcomm.com> <20260921-qrtr-multi-ep-v2-2-27dd80d841a0@oss.qualcomm.com> Subject: Re: [PATCH v2 2/4] net: qrtr: Assign unique node id for MHI endpoints Content-Type: text/plain Content-Transfer-Encoding: 7bit On Tue, Sep 22, 2026, at 20:14, Youssef Samir wrote: > On 9/21/2026 12:23 PM, Manivannan Sadhasivam via B4 Relay wrote: > > + > > +/* The offset is chosen carefully to not collide with the node ids allocated by > > + * the remote nodes. All the remote nodes use node ids in range 0 to 0xffff. > This assumption does not hold up for QRTR V1 headers where the node ids are 32bit. > QAIC devices use BHI_SERIALNUM as the node ID, and it is definitely larger than > 0xFFFF.> + */ Does that mean we have to go back to my endpoint id patchset? It's an option, but a quite complex one. However, what is the likelihood that serial number would clash with these host node id values? Maybe just adjusting the comment could be acceptable. Also, rewriting QRTR node_id for more than just MHI devices could help here. If all are rewritten, the problem goes away. BR, Juha-Matti