From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbeAOSBe (ORCPT + 1 other); Mon, 15 Jan 2018 13:01:34 -0500 Received: from mail-wr0-f171.google.com ([209.85.128.171]:39541 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbeAOSBc (ORCPT ); Mon, 15 Jan 2018 13:01:32 -0500 X-Google-Smtp-Source: ACJfBosuf1d/EOnLxX2/8H4Di7iDoj3h6zL1n22devfNjn+nIRO8jI1fi9wZGinKF9weF4IhpSDIZA== Subject: Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support To: Christoph Hellwig Cc: Arnd Bergmann , Greg Kroah-Hartman , Michael Thayer , Alexander Viro , Larry Finger , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20180115175116.4130-1-hdegoede@redhat.com> <20180115175116.4130-2-hdegoede@redhat.com> <20180115175508.GA18966@infradead.org> From: Hans de Goede Message-ID: <8ed7e4d5-4d21-b5b0-a96f-94d856f4f506@redhat.com> Date: Mon, 15 Jan 2018 19:01:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180115175508.GA18966@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Hi, On 15-01-18 18:55, Christoph Hellwig wrote: > The mount uabi stuff is a red flag - all filesystems should use > text options only these days. From a 20 second view it seems like > this one does that, and the header can just be removed, but if not > a lot more work will be needed. Thank you for the quick feedback. I already expected this would be a problem, but I kept it around for 100% compatibility with the out of tree version of the vboxsf driver. I will fix this for v3 and coordinate with vbox upstream what to do about the compatibility issue. Regards, Hans