From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12A0C2F60CC for ; Tue, 25 Aug 2026 11:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787657036; cv=none; b=N0C40Xe5gDrC9c2Yu/GrGTu50JOU6r/vKUx8+KXis6MQdf4cQ2890/MnGLMFQxSEbuxSk8v9+t/sqZk7nmJNCKTr4ebsN4QFYl8XJAVwKymkW4P6exHX5arphof3+ZBMMZdjFGDk2lkzlWUWXIIDh64imnbDKwQZKwWFkcTKjtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787657036; c=relaxed/simple; bh=WxL8H/92OVMDn/7gIRvDapUZQDOBxDSojzIoAr58wE4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FId4oSJdW7/9qQzv6yjE32eOam9pR/qfwnUVy7Sm4RiN2gP6JcGip+hXvJ/QmBSJytxDPwX8SI0M/qUyw6otCQSnaVgszWE6g/1mKWtGn72tAnqDylfYeZJt16skPFigfICXl6paYB2+YFkwb0vF/OU92qoVAZs2U8zuiO0qvxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=uaWLs6Vi; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=KzN2bed0; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=rhXpJgau; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=0L2ZD8nA; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="uaWLs6Vi"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="KzN2bed0"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="rhXpJgau"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="0L2ZD8nA" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ADAD986DDE; Tue, 25 Aug 2026 11:23:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787657028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MTM3Bbz8nV+5uj6ljrjm8iMkA/uAv04uo4kkUl8ZpqM=; b=uaWLs6VidVHNdMw0QB5m50S8bPlxeYe/V/8a8N8xvI9c/rhwil4TKidtzAFr4d+flyC2Bd DLHwHTvZhoUIQQ+SU9khwOgYS0a8DRnNn6SirWVzdBxH7tCLkIq8bkvfBkG9ZNjdS4cBOd RevS+cId3KeFMSg4Z3zh7wNpFnZbSoQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787657028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MTM3Bbz8nV+5uj6ljrjm8iMkA/uAv04uo4kkUl8ZpqM=; b=KzN2bed0orWJzU7iRLUuFS2KeDs8XHfLGgRfAQFwUoz2TPB4a7Wh7fAXPyH7CGpI8u82pE 38X1k+Z/lJCMIVDg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787657024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MTM3Bbz8nV+5uj6ljrjm8iMkA/uAv04uo4kkUl8ZpqM=; b=rhXpJgauhlnnia2BlT5R6XLicjJDmVaiRNzLDuj0Qt4r39VJNlygQTuhYAAc+bzBxStRyL IgrtvbAiQZNBuDoqWt/MUW2Od3Ydyg1cP4Hq0dIsMqo1h30MTUl6KN68TrFV0msH6LpzJJ QPTiny6QaUYBVdA5tMD/GA+b6H+0pXs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787657024; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=MTM3Bbz8nV+5uj6ljrjm8iMkA/uAv04uo4kkUl8ZpqM=; b=0L2ZD8nAXh2nHUeml/r98yr5Ex3NPCeoBh//xPSvEOkarWvfiMhYeQraTdytVitVQRHxaQ avW9NeNfqvruW2CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7327713335; Tue, 25 Aug 2026 11:23:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gzvlGkB7jWoZPAAAD6G6ig (envelope-from ); Tue, 25 Aug 2026 11:23:44 +0000 Message-ID: <8edbb638-4031-4df2-ad93-ae82d66d7b64@suse.de> Date: Tue, 25 Aug 2026 13:23:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/sysfb: ofdrm: Fix is_avivo() constant comparison bug To: oushixiong1025@163.com Cc: Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Shixiong Ou References: <20260825104152.670588-1-oushixiong1025@163.com> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <20260825104152.670588-1-oushixiong1025@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.30 X-Spam-Level: X-Spam-Flag: NO X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[163.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; FREEMAIL_ENVRCPT(0.00)[163.com,gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[redhat.com,linux.intel.com,kernel.org,gmail.com,ffwll.ch,lists.freedesktop.org,vger.kernel.org,kylinos.cn]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.com:url,imap1.dmz-prg2.suse.org:helo,kylinos.cn:email] Hi Am 25.08.26 um 12:41 schrieb oushixiong1025@163.com: > From: Shixiong Ou > > The is_avivo() function has a logic error where it compares a constant > to another constant instead of checking the device parameter: > > (PCI_VENDOR_ID_ATI_R600 >= 0x9400) > > Signed-off-by: Shixiong Ou I see this is a recent of an earlier patch I missed. I've r-b'ed that one and will merged it soon. Thanks for the fix. Best regards Thomas > --- > drivers/gpu/drm/sysfb/ofdrm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sysfb/ofdrm.c b/drivers/gpu/drm/sysfb/ofdrm.c > index 819aed466727..1d95df522ad5 100644 > --- a/drivers/gpu/drm/sysfb/ofdrm.c > +++ b/drivers/gpu/drm/sysfb/ofdrm.c > @@ -238,7 +238,7 @@ static bool is_avivo(u32 vendor, u32 device) > /* This will match most R5xx */ > return (vendor == PCI_VENDOR_ID_ATI) && > ((device >= PCI_VENDOR_ID_ATI_R520 && device < 0x7800) || > - (PCI_VENDOR_ID_ATI_R600 >= 0x9400)); > + (device >= PCI_VENDOR_ID_ATI_R600)); > } > > static enum ofdrm_model display_get_model_of(struct drm_device *dev, struct device_node *of_node) -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)