From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 159AC23EABC for ; Sat, 7 Feb 2026 16:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770481601; cv=none; b=OhH2CKAJfI9ShuIvDsT0/vuT1XeW9DGXXMsn3UeyaKl4B0UUe9WwV7dmrS8sW7erfHYFEtC+8yHUMVKVzNORqYBElgcT3x8Xun1hTYzN6eVXOLvblcwlCbPvjrSID6U8RQ5yOu5T78sXvK0KOlxhKzlxS8rJpr/f0FLaNfMrtvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770481601; c=relaxed/simple; bh=j3FECyiAxmmI2wfYqKh+xI5b3YmNdh1kx4eKSlBEKS8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=M7oBNQITSr8pfggZP7y/VpkGqHSPOaPBJ5F3ggw3BRp1MoMUZu2ckF7r23MP8XrdndJrvm/RLYWndDSLvYTdfze3r/2yh/L1pkHKvy8Ijd8zqEekQBgJgPqYBzHFgdu1fQ2ZtT6JQxG1mfuMOZU5xtveMQDAkChtZwHT7a/hl0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FyTt4dZz; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FyTt4dZz" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-124a635476fso4414393c88.0 for ; Sat, 07 Feb 2026 08:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770481600; x=1771086400; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=qaeQT/JB5eRckxUqHu4WMqba4+b/1vOahlNS4W+Ftz0=; b=FyTt4dZzQ1gy5pmHLZsxNH4BlRu5OzqJ4pegmVSpYdCn9o57neRd71NxxfIk/SQYXx hYpsQfF6mXB5xq4AAKPu/HmU6Mnb//wsos09AvJAEnX6/TH00xPqi1455oNiZOGQyLdp hhf2urSU9XNYB8t2p5aBu+YDiqu4+VB9EbRPt9n2WoA7wtkhWkpBEA3N3V3AChcCi0wX ytQefNCePbMFlqir3H3PCaLbMIogRswL8Q+PmFLskrPKr7D+SdyUT65bkf5lJdZJdVE2 qAhbTRLZtJIL5FC385bQSugwrMGVpUOoVk0zOKX1qpIIbIsnNAccDIpnrFgw9ZNMiSVG lV+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770481600; x=1771086400; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qaeQT/JB5eRckxUqHu4WMqba4+b/1vOahlNS4W+Ftz0=; b=UNT/xYu0aKBE/NgVg1UY+sP9y0HioWuMdaGGO7WMrmAvNyKX2MZiDcFjZKHuP62pYW qMNz1uIV9g2WZ1Dk6Pejigbgaxx4EniadpsAHzWFftIGGzI9EtNexA2KjEGmjviZXYAl 6BeM7ZqyZ+PeFDjdsPgmfdoYpZbdyz1xsHMfyIxxb6qGpKe84QSHEBDRekEBgMOTHgEh AJ2Dpa4dEf4lS7i5v/HetET2IgnYhkMJubnLk2f++D5mJnfvLpJFZPWWJyPk2Qa864dA xZ+LajaWw05b6UIEaAO2CpOcWuKJIJoHSJnVPNCi/xSfm8QtgmU7lw7HUGAAy+LMhd22 mx5w== X-Forwarded-Encrypted: i=1; AJvYcCWFP1fAwxLXPeeDaOeWped33a57x3j90NzLtyAFZlKWwpzcllj1IRvgvQilFwABDi1e6P1zQPRDD1QYfkk=@vger.kernel.org X-Gm-Message-State: AOJu0YzHxKCtXXggIceAvCR8T0isLc70TmBxXj3Z8oU1wWp7JwUlewh6 48tXk6ZX2tM/ZKUoCHhh8rKspeZ26oFQ6vKFGi13jRR9qwUIg1JQEaS1 X-Gm-Gg: AZuq6aLrXGYTvOy/DbynQeNcEooWyx1Qq+BvX9aPy6bDFsJBLvBu9ruSw+RPnUWrl1d NA2+3LLu2gMCUdqYDWB/z02EHJig/SA4jtsFZdtSoGdpDOw3WUBfjksdcN3b2hSum0vox5+zues xdluhSgxA2DxSLWan6/NFxY9t/EGROXWm3TIgAQ1+Tw94/QCc8fWz6zAsnBSpldn3FVFc3roj8W AGYIdvDaV9gkQ1ZG5MyGqo2r5Xmu0VPUIlB0Z3+Azi+K1H0HI9e7MM4VciroTvixjZ+Wmrxw1tW +r7oIO0qF122IBGCjV/4dl+A6CE1F13wFpceP/tmnmqFdm/pkkFX/OE1iAOjyPLeWNVoETkYGXo +pRsm8gkv7IBNbIK7EmSCjGxL72Md8jqdkGQ6ZgX15PBUJFGBdLSeXkF0lFIdRuo3CvvkJaUBTN jKdUFxiXt1TraxMi6RJmTSYYCao9FOOP90wiX5ESFjVOijEqXhFV4F+TxIld1F X-Received: by 2002:a05:7022:6293:b0:122:33e:6d41 with SMTP id a92af1059eb24-12704074eebmr2950792c88.23.1770481600007; Sat, 07 Feb 2026 08:26:40 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041d94cesm4499975c88.3.2026.02.07.08.26.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 08:26:39 -0800 (PST) Sender: Guenter Roeck Message-ID: <8edcc901-04aa-4d8d-a357-8653e29327e4@roeck-us.net> Date: Sat, 7 Feb 2026 08:26:37 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 10251/12094] drivers/hwmon/cros_ec_hwmon.o: error: objtool: cros_ec_hwmon_read+0x6c: can't find jump dest instruction at .text+0xd2d To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Tzung-Bi Shih , linux-kernel@vger.kernel.org References: <202602071311.Q6tATiyh-lkp@intel.com> <4db66fc2-dc8a-4499-bc9d-c1f85e2ba4c1@t-8ch.de> <957068ee-7368-4fd1-9e55-1449414238be@roeck-us.net> <317af5ed-fc8b-42d7-aa4a-143f8cf3ab04@t-8ch.de> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <317af5ed-fc8b-42d7-aa4a-143f8cf3ab04@t-8ch.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/7/26 07:33, Thomas Weißschuh wrote: > On 2026-02-07 07:07:13-0800, Guenter Roeck wrote: >> On 2/7/26 02:56, Thomas Weißschuh wrote: >>> On 2026-02-07 13:14:53+0800, kernel test robot wrote: >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>>> head: 9845cf73f7db6094c0d8419d6adb848028f4a921 >>>> commit: 165c14597d53cfa7bc97b4ff8bc85f7bd98262b7 [10251/12094] hwmon: (cros_ec) Add support for temperature thresholds >>>> config: x86_64-randconfig-071-20260207 (https://download.01.org/0day-ci/archive/20260207/202602071311.Q6tATiyh-lkp@intel.com/config) >>>> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 >>>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260207/202602071311.Q6tATiyh-lkp@intel.com/reproduce) >>>> >>>> If you fix the issue in a separate patch/commit (i.e. not just a new version of >>>> the same patch/commit), kindly add following tags >>>> | Reported-by: kernel test robot >>>> | Closes: https://lore.kernel.org/oe-kbuild-all/202602071311.Q6tATiyh-lkp@intel.com/ >>>> >>>> All errors (new ones prefixed by >>): >>>> >>>>>> drivers/hwmon/cros_ec_hwmon.o: error: objtool: cros_ec_hwmon_read+0x6c: can't find jump dest instruction at .text+0xd2d >>> >>> This is due to the call to unreachable() in cros_ec_hwmon_attr_to_thres(). >>> Replacing it with BUG() avoids the issue. >>> >>> Guenter, do you want to drop the patches for now and I'll resend them >>> next cycle? I can also send an incremental patch. Or you just fix it up >>> in your branch. >>> >> >> I strongly dislike BUG() because it means "I don't trust my own code". > > Agreed, I am not a fan either, which is why I used unreachable() > originally. > >> The final "else" in the code is not really necessary and should be dropped. > > That will trigger a compiler warning: > > drivers/hwmon/cros_ec_hwmon.c:170:1: error: control reaches end of non-void function [-Werror=return-type] > 170 | } > | ^ > I meant something like diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c index 5b998cd5e506..6cf5ab0f4b73 100644 --- a/drivers/hwmon/cros_ec_hwmon.c +++ b/drivers/hwmon/cros_ec_hwmon.c @@ -165,10 +165,7 @@ static enum ec_temp_thresholds cros_ec_hwmon_attr_to_thres(u32 attr) return EC_TEMP_THRESH_WARN; else if (attr == hwmon_temp_crit) return EC_TEMP_THRESH_HIGH; - else if (attr == hwmon_temp_emergency) - return EC_TEMP_THRESH_HALT; - else - unreachable(); + return EC_TEMP_THRESH_HALT; /* attr == hwmon_temp_emergency */ } Guenter