From: Sergey Suloev <ssuloev@orpaltech.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 5/6] spi: sun4i: introduce register set/unset helpers
Date: Tue, 3 Apr 2018 13:27:57 +0300 [thread overview]
Message-ID: <8edccc63-9729-ff4c-b272-1916e7794bc7@orpaltech.com> (raw)
In-Reply-To: <20180403081458.lyilg3yu3n2e54fd@flea>
On 04/03/2018 11:14 AM, Maxime Ripard wrote:
> On Thu, Mar 29, 2018 at 09:59:06PM +0300, Sergey Suloev wrote:
>> Two helper functions were added in order to update
>> registers easily.
>>
>> Signed-off-by: Sergey Suloev <ssuloev@orpaltech.com>
> I'm not really sure what's easier about this one.
>
> Maxime
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
well, just seems more readable vs doing "read, or, write" every time
next prev parent reply other threads:[~2018-04-03 10:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 18:59 [PATCH 0/6] spi: Add support for DMA transfers in sun4i SPI driver Sergey Suloev
2018-03-29 18:59 ` [PATCH 1/6] spi: core: handle timeout error from transfer_one() Sergey Suloev
2018-03-29 18:59 ` [PATCH 2/6] spi: sun4i: restrict transfer length in PIO-mode Sergey Suloev
2018-04-03 8:10 ` Maxime Ripard
2018-04-03 10:26 ` Sergey Suloev
2018-04-03 11:08 ` Sergey Suloev
2018-04-03 11:40 ` Maxime Ripard
2018-04-03 12:12 ` Sergey Suloev
2018-03-29 18:59 ` [PATCH 3/6] spi: sun4i: coding style/readability improvements Sergey Suloev
2018-03-29 18:59 ` [PATCH 4/6] spi: sun4i: use completion provided by SPI core driver Sergey Suloev
2018-03-29 18:59 ` [PATCH 5/6] spi: sun4i: introduce register set/unset helpers Sergey Suloev
2018-04-03 8:14 ` Maxime Ripard
2018-04-03 10:27 ` Sergey Suloev [this message]
2018-03-29 18:59 ` [PATCH 6/6] spi: sun4i: add DMA transfers support Sergey Suloev
2018-04-03 8:17 ` Maxime Ripard
2018-04-03 13:03 ` Sergey Suloev
2018-04-04 6:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8edccc63-9729-ff4c-b272-1916e7794bc7@orpaltech.com \
--to=ssuloev@orpaltech.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®