From: Florian Fainelli <f.fainelli@gmail.com>
To: Pierre Gondois <pierre.gondois@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
William Zhang <william.zhang@broadcom.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom
Date: Mon, 7 Nov 2022 09:31:55 -0800 [thread overview]
Message-ID: <8ee17547-30ef-bc85-b163-f0d9efe70fcc@gmail.com> (raw)
In-Reply-To: <20221107155825.1644604-7-pierre.gondois@arm.com>
(way too many recipients, gmail's SMTP server would not allow me to
respond unless I moved most people to BCC now done).
On 11/7/22 07:56, Pierre Gondois wrote:
> The DeviceTree Specification v0.3 specifies that the cache node
> 'compatible' and 'cache-level' properties are 'required'. Cf.
> s3.8 Multi-level and Shared Cache Nodes
> The 'cache-unified' property should be present if one of the
> properties for unified cache is present ('cache-size', ...).
>
> Update the Device Trees accordingly.
>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> Acked-by: William Zhang <william.zhang@broadcom.com>
This looks fine, but incomplete, you seem to have missed:
- adding 'cache-unified' to all of the cache nodes modified in this
patch set that did not have one already
- bcm63148.dtsi, bcm63178.dtsi, bcm6756.dtsi, bcm6846.dtsi,
bcm6855.dtsi, bcm6878.dtsi, bcm47622.dtsi
Thanks
--
Florian
next prev parent reply other threads:[~2022-11-07 17:32 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 15:56 [PATCH v2 00/23] Update cache properties for arm64 DTS Pierre Gondois
2022-11-07 15:56 ` [PATCH v2 01/23] arm64: dts: Update cache properties for amazon Pierre Gondois
2023-01-12 8:34 ` Pierre Gondois
2022-11-07 15:56 ` [PATCH v2 02/23] arm64: dts: Update cache properties for amd Pierre Gondois
2023-01-12 8:34 ` Pierre Gondois
2023-01-12 15:31 ` Tom Lendacky
2022-11-07 15:56 ` [PATCH v2 03/23] arm64: dts: Update cache properties for amlogic Pierre Gondois
2022-11-07 15:56 ` [PATCH v2 04/23] arm64: dts: Update cache properties for apm Pierre Gondois
2023-01-12 8:33 ` Pierre Gondois
2022-11-07 15:56 ` [PATCH v2 05/23] arm64: dts: Update cache properties for arm Pierre Gondois
2022-11-11 15:56 ` Sudeep Holla
2022-11-07 15:56 ` [PATCH v2 06/23] arm64: dts: Update cache properties for broadcom Pierre Gondois
2022-11-07 17:31 ` Florian Fainelli [this message]
2022-11-07 17:58 ` Pierre Gondois
2022-11-16 18:22 ` Florian Fainelli
2022-11-17 9:39 ` Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 07/23] arm64: dts: Update cache properties for exynos Pierre Gondois
2022-11-07 17:55 ` Krzysztof Kozlowski
2022-11-07 18:24 ` Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 08/23] arm64: dts: Update cache properties for freescale Pierre Gondois
2022-11-14 11:41 ` Shawn Guo
2022-11-07 15:57 ` [PATCH v2 09/23] arm64: dts: Update cache properties for hisilicon Pierre Gondois
2022-11-16 2:17 ` Wei Xu
2022-11-07 15:57 ` [PATCH v2 10/23] arm64: dts: Update cache properties for lg Pierre Gondois
2023-01-12 8:34 ` Pierre Gondois
2023-01-13 1:12 ` Chanho Min
2022-11-07 15:57 ` [PATCH v2 11/23] arm64: dts: Update cache properties for marvell Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 12/23] arm64: dts: Update cache properties for mediatek Pierre Gondois
2022-11-08 11:42 ` Matthias Brugger
2022-11-07 15:57 ` [PATCH v2 13/23] arm64: dts: Update cache properties for microchip Pierre Gondois
2023-01-12 8:33 ` Pierre Gondois
2023-01-18 8:21 ` Steen Hegelund
2022-11-07 15:57 ` [PATCH v2 14/23] arm64: dts: Update cache properties for nuvoton Pierre Gondois
2023-01-12 8:34 ` Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 15/23] arm64: dts: Update cache properties for nvidia Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 16/23] arm64: dts: Update cache properties for qcom Pierre Gondois
2022-12-29 12:47 ` Krzysztof Kozlowski
2022-12-29 17:23 ` (subset) " Bjorn Andersson
2022-11-07 15:57 ` [PATCH v2 17/23] arm64: dts: Update cache properties for realtek Pierre Gondois
2023-01-12 8:33 ` Pierre Gondois
2023-01-12 8:51 ` Andreas Färber
2022-11-07 15:57 ` [PATCH v2 18/23] arm64: dts: Update cache properties for renesas Pierre Gondois
2022-11-08 8:34 ` Geert Uytterhoeven
2022-11-07 15:57 ` [PATCH v2 19/23] arm64: dts: Update cache properties for rockchip Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 20/23] arm64: dts: Update cache properties for socionext Pierre Gondois
2023-01-12 8:33 ` Pierre Gondois
2023-01-12 10:27 ` Kunihiko Hayashi
2022-11-07 15:57 ` [PATCH v2 21/23] arm64: dts: Update cache properties for synaptics Pierre Gondois
2023-01-12 8:32 ` Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 22/23] arm64: dts: Update cache properties for tesla Pierre Gondois
2022-11-07 17:56 ` Krzysztof Kozlowski
2022-11-07 18:23 ` Pierre Gondois
2022-11-07 15:57 ` [PATCH v2 23/23] arm64: dts: Update cache properties for ti Pierre Gondois
2023-01-17 13:41 ` (subset) " Raghavendra, Vignesh
2022-11-07 18:03 ` [PATCH v2 00/23] Update cache properties for arm64 DTS Krzysztof Kozlowski
2022-11-07 23:11 ` Rob Herring
2022-11-22 22:34 ` (subset) " Heiko Stuebner
2023-01-12 8:33 ` Pierre Gondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee17547-30ef-bc85-b163-f0d9efe70fcc@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=robh+dt@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome