From: Randy Dunlap <rdunlap@infradead.org>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
jikos@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: x86: kernel: Mundane spelling fixes throughout the file apm_32.c
Date: Wed, 3 Feb 2021 08:49:00 -0800 [thread overview]
Message-ID: <8ee5a8bf-d9dd-d756-0522-abef96f1b062@infradead.org> (raw)
In-Reply-To: <20210203144837.30246-1-unixbhaskar@gmail.com>
On 2/3/21 6:48 AM, Bhaskar Chowdhury wrote:
>
> s/messges/messages/
> s/powermanagement/power management/
> s/secodnds/seconds/
> s/powerdown/poer down/
>
> Capitalize and truncate space in start of the sentence.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> arch/x86/kernel/apm_32.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
> index 660270359d39..04204e01ff7c 100644
> --- a/arch/x86/kernel/apm_32.c
> +++ b/arch/x86/kernel/apm_32.c
> @@ -2366,7 +2366,7 @@ static int __init apm_init(void)
> /*
> * Note we don't actually care if the misc_device cannot be registered.
> * this driver can do its job without it, even if userspace can't
> - * control it. just log the error
> + * control it.Just log the error
missing space and period:
* control it. Just log the error.
The rest of the changes look good.
Thanks.
> */
> if (misc_register(&apm_device))
> printk(KERN_WARNING "apm: Could not register misc device.\n");
> --
> 2.26.2
>
--
~Randy
next prev parent reply other threads:[~2021-02-03 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 14:48 Bhaskar Chowdhury
2021-02-03 16:49 ` Randy Dunlap [this message]
2021-02-04 0:08 ` Bhaskar Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ee5a8bf-d9dd-d756-0522-abef96f1b062@infradead.org \
--to=rdunlap@infradead.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=unixbhaskar@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®