From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE5B6C433EF for ; Fri, 24 Jun 2022 01:27:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231138AbiFXB1C (ORCPT ); Thu, 23 Jun 2022 21:27:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiFXB1A (ORCPT ); Thu, 23 Jun 2022 21:27:00 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8437A60C55; Thu, 23 Jun 2022 18:26:59 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LTfZb4zCfzkWmn; Fri, 24 Jun 2022 09:25:43 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 24 Jun 2022 09:26:57 +0800 Received: from [10.67.111.205] (10.67.111.205) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 24 Jun 2022 09:26:57 +0800 Subject: Re: [RFC 00/13] perf: Add perf kwork To: "Paul A. Clarke" CC: , , , , , , , , References: <20220613094605.208401-1-yangjihong1@huawei.com> <3cccc03a-c2bc-91d9-60b9-daf180c6b108@huawei.com> From: Yang Jihong Message-ID: <8ee806af-7ced-6f8f-ef66-a75819f19375@huawei.com> Date: Fri, 24 Jun 2022 09:26:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.205] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 2022/6/23 22:25, Paul A. Clarke wrote: > On Thu, Jun 23, 2022 at 09:02:45AM +0800, Yang Jihong wrote: >> On 2022/6/22 22:59, Paul A. Clarke wrote: >>> On Mon, Jun 13, 2022 at 05:45:52PM +0800, Yang Jihong wrote: >>>> Sometimes, we need to analyze time properties of kernel work such as irq, >>>> softirq, and workqueue, such as delay and running time of specific interrupts. >>>> Currently, these events have kernel tracepoints, but perf tool does not >>>> directly analyze the delay of these events >>>> >>>> The perf-kwork tool is used to trace time properties of kernel work >>>> (such as irq, softirq, and workqueue), including runtime, latency, >>>> and timehist, using the infrastructure in the perf tools to allow >>>> tracing extra targets >>>> >>>> test case: >>>> >>>> # perf kwork report >>>> >>>> Kwork Name | Cpu | Total Runtime | Frequency | Max runtime | Max runtime start | Max runtime end | >>>> --------------------------------------------------------------------------------------------------------------------------- >>>> (s)RCU:9 | 0007 | 3.488 ms | 1258 | 0.145 ms | 3398384.220013 s | 3398384.220157 s | >>>> (s)NET_RX:3 | 0003 | 1.866 ms | 156 | 0.042 ms | 3398385.629764 s | 3398385.629806 s | >>>> (s)TIMER:1 | 0000 | 1.799 ms | 117 | 0.055 ms | 3398385.568033 s | 3398385.568088 s | >>>> (w)0xffff9c66e563ee98 | 0006 | 1.561 ms | 5 | 0.351 ms | 3398384.060021 s | 3398384.060371 s | >>> >>> What units are used for "Frequency"? It would be helpful to include somewhere. > >> This refers to the number of event in the trace period. > > I see. I suggest changing the column heading to say that. > "Count", "Number of Events", "Occurrences", something like that. > > "Frequency" is a count-per-time-unit, like hertz, which doesn't > match well here. OK, I'll fix in next version. Thanks, Jihong