mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: WANG Wenhu <wenhu.wang@vivo.com>,
	Russell King <linux@armlinux.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: trivial@kernel.org
Subject: Re: [PATCH] serial: pl011: format long message string into lines
Date: Fri, 13 Mar 2020 08:03:05 +0100	[thread overview]
Message-ID: <8eee8b07-3cc3-6ab8-b50f-89cbac0f69ae@suse.cz> (raw)
In-Reply-To: <20200313065618.60196-1-wenhu.wang@vivo.com>

On 13. 03. 20, 7:56, WANG Wenhu wrote:
> Separate the message string into lines for pl011_probe_dt_alias()
> to make it better comply with kernel coding style, and also, make
> it more readable.
> 
> It would still be grep friendly for the separated format.
> 
> Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
> ---
>  drivers/tty/serial/amba-pl011.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
> index 2296bb0f9578..e693b7ac5a3a 100644
> --- a/drivers/tty/serial/amba-pl011.c
> +++ b/drivers/tty/serial/amba-pl011.c
> @@ -2523,7 +2523,8 @@ static int pl011_probe_dt_alias(int index, struct device *dev)
>  	}
>  
>  	if (seen_dev_with_alias && seen_dev_without_alias)
> -		dev_warn(dev, "aliased and non-aliased serial devices found in device tree. Serial port enumeration may be unpredictable.\n");
> +		dev_warn(dev, "aliased and non-aliased serial devices found in device tree." \
> +			"Serial port enumeration may be unpredictable.\n");

1) You removed a space after the dot
2) the backslash is superfluous
3) CodingStyle clearly states:
"""
However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.
"""

So, sorry:
Nacked-by: Jiri Slaby <jslaby@suse.cz>

>  
>  	return ret;
>  }
> 


-- 
js
suse labs

  reply	other threads:[~2020-03-13  7:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-13  6:56 WANG Wenhu
2020-03-13  7:03 ` Jiri Slaby [this message]
2020-03-13  7:30   ` 王文虎

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eee8b07-3cc3-6ab8-b50f-89cbac0f69ae@suse.cz \
    --to=jslaby@suse.cz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=trivial@kernel.org \
    --cc=wenhu.wang@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®