From: Alan Stern <stern@rowland.harvard.edu>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tim Guttzeit <t.guttzeit@tuxedocomputers.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb/core/quirks: Add Huawei ME906S to wakeup quirk.
Date: Wed, 15 Oct 2025 10:21:39 -0400 [thread overview]
Message-ID: <8ef4550b-a958-4fa4-88df-89b3d4b1117d@rowland.harvard.edu> (raw)
In-Reply-To: <20251014153049.91722-1-wse@tuxedocomputers.com>
On Tue, Oct 14, 2025 at 05:30:05PM +0200, Werner Sembach wrote:
> From: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
>
> The list of Huawei LTE modules needing the quirk fixing spurious wakeups
> was missing the IDs of the Huawei ME906S module, therefore suspend did not
> work.
>
> Signed-off-by: Tim Guttzeit <t.guttzeit@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/usb/core/quirks.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index f5bc538753301..39fbbc31e9a41 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -469,6 +469,8 @@ static const struct usb_device_id usb_quirk_list[] = {
> USB_QUIRK_DISCONNECT_SUSPEND },
> { USB_DEVICE(0x12d1, 0x15c3), .driver_info =
> USB_QUIRK_DISCONNECT_SUSPEND },
> + { USB_DEVICE(0x12d1, 0x15c1), .driver_info =
> + USB_QUIRK_DISCONNECT_SUSPEND },
Please pay attention to the comment at the start of the array's
definition. Entries should be sorted by vendor ID and product ID.
Alan Stern
next prev parent reply other threads:[~2025-10-15 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 15:30 Werner Sembach
2025-10-15 14:21 ` Alan Stern [this message]
2025-10-15 15:48 ` Werner Sembach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ef4550b-a958-4fa4-88df-89b3d4b1117d@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=t.guttzeit@tuxedocomputers.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®