From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2539E32E143 for ; Tue, 16 Dec 2025 10:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765880137; cv=none; b=hJOato7Sj9dE9maEKjErR9MB1Zp3LGm91/u7NHDZYeUWV5So5OpWxcbw0t3ZyC6fTocZ+j8SjKPwNtPHVNqIBzdo6vR48uUNRaQVq0vs8+lyY63y7SSGTuIrjzuEVaaitbMGyNcV1I5Se/uc7zxYAfa+yXTTD6iMI03mwJk4HgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765880137; c=relaxed/simple; bh=C0LHt2ilHMb3OdV5L9EiEB040sAf+NLl3wwA2pBeNzI=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=EG58/e61S2j+BPYbV1x01KCXmqYZu17/nIJ+CsRHzC4vzBhqZEDERDTHn51H22+s7SFipNBSuYSyVRfHAa2WvxB1X7Kip8V5v3VAONtxfUeHCFDYn7VMyut2fZq+/jICEyW/g+l+/p5ETBds6s10G4xPgMOH5/jYueqHhe3Dg+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BKtB/WUj; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BKtB/WUj" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47a8195e515so35838865e9.0 for ; Tue, 16 Dec 2025 02:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765880133; x=1766484933; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=TC7nDl1wifuEDkf59f4yFIQZTBJ14bBd1H1iofC4YrY=; b=BKtB/WUjF+AWtFvE64KxScLjNTZU6cJDVeDP3/nUxeZSz1W1U9ol0lqnAOxDuMsmIm lYayzKGCdJXaMD1IeQ76zbDv33i6L64uIKz55/RhjjxGL7a53H8X//Muty7Wog+4WSC9 eMZHjiZutGAIedRAlEVuhNUE14jhs/HJUi7KZBTk5EIpeHn5gXzHiRntOVufSDWu+w4B S6nFdeer6O5OuPPXVQl96gxdLUJorvF4/7seEmBMxWjQf6q69uvB1LCSBeCNJAF6pr+U 3s5fdicqsXV9sGGhA4cXGxVWgR3K/4BDPaYJ/nzzxqGNmMD/66DnMyR4WuL0AQ2XfQV5 tSjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765880133; x=1766484933; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TC7nDl1wifuEDkf59f4yFIQZTBJ14bBd1H1iofC4YrY=; b=PcLsE2nQp01uRnLP0xjVpJuOfVMOApggXtpCW0xEnt/E7CgMDQ/LFdLZ6403ojQkT0 QmgExY4o2Ard4BY7uv+ahFzxAtzjSFQ0fZdx06tz0K38y7fWOtZ1QXB4bxgdr/e5cIIz I42HQZ9rqA13z9I+sNOejw9rlBnrsU+45RxejVg9XFPp2RXvo89cNPsaxQ098x9Ftuxf +obr58nklOwY/qZMmk7ihQsGDqx7DO0c9rpLEFOboNVbErl6r8PXI6pyxbq7/jaMfSHA HjflxO7zOsV9SKUPoLn5fi2NysgJzG9ge/oRnLXP2Z/HZRQ0NGVzdmtk2dnyqtFhSnyT N4Aw== X-Forwarded-Encrypted: i=1; AJvYcCWjsu67Ora9BDuzd15ajVARAC9d0JpZlf6srO2OTsrTCs8GlZ6uC38P3KODZbQEfBvUYu6wJdSLRfUyZW8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7JvQ8/8hFK2KvT2jPJqVGoRuKHIRnIB931BW33Q9JaXWO7ykr AfyL/AZcumQfVKGDO88ZH+KeI2Vd+0EMs3mbsd25ypbyCV+cvw+nW/Dro5glAivHTXQ= X-Gm-Gg: AY/fxX7aAqnVmYjmG99d0OZ7jEACFthiywQ1/p5rS2uwKkCaqbc0q7Ek2TEJRPpR3zi Jyht81DpoXqmTIXTeACIDaoiNzkx3taQF96eVVBZxUvPOrf2Hg8H1vEQYTFZTC0tHRqsFb+A4OO sX+T2Xhr1bzezSU6uX3yzgalRwUAWGTVLIWSQmL099AwH6+SVAz6qzCOjHnjtqQLsr5NUQucME+ PrTst+q5DWEfzCHmD1s1/k71VewTibLZLkbezZ4iZbE2mGJBQmdWU8fzlST7S9F+SJejCZ0avMR lm/37VSZ9F6SuNGXEgYgayz4BsQophzCNvPc0zpXJqGFT16a9mXEcBZAj2DBp16J0hgHs3BQXSD WT6MOr0x9FABHQSr3z6HeIIBcBK/9c7XVpH4KUBT95nF5pCCdhOxf2IpQedjxDS8RAKtB2QwjIb bDhb+2LLD5FE4TajgZfusFCHCoXeZmhkEk22CzsjXU8BeTU4b2+MtpBEEcpPdWUTc= X-Google-Smtp-Source: AGHT+IFNmWmeVfREbnlawrLbiJWYchJrdkbwmJ5e2QA/GyR67dJoN5aj8rejIsQe3Lih0MgLxHiC9A== X-Received: by 2002:a05:6000:4010:b0:430:f2ee:b219 with SMTP id ffacd0b85a97d-430f2eeb65emr10561462f8f.25.1765880133260; Tue, 16 Dec 2025 02:15:33 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:2913:9c11:b7b9:c6d2? ([2a01:e0a:3d9:2080:2913:9c11:b7b9:c6d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-430f4126477sm18772676f8f.10.2025.12.16.02.15.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Dec 2025 02:15:32 -0800 (PST) Message-ID: <8ef57d2e-9a43-434f-89d6-e99c0892abef@linaro.org> Date: Tue, 16 Dec 2025 11:15:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel: osd-osd101t2587-53ts: migrate to mipi_dsi_turn_on_peripheral_multi From: Neil Armstrong To: Matt Smith Cc: Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/20/25 08:52, Neil Armstrong wrote: > On 11/20/25 03:25, Matt Smith wrote: >> Documentation/gpu/todo.rst lists to transition away from using >> deprecated methods in drm_mipi_dsi.c, so migrating from >> mipi_dsi_turn_on_peripheral to mipi_dsi_turn_on_peripheral_multi. >> >> Used commit e139c0eb22ce ("drm/panel: mantix-mlaf057we51: transition >> to mipi_dsi wrapped functions") as a reference. >> >> Signed-off-by: Matt Smith >> --- >>   drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c | 11 ++++++----- >>   1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c >> index 2334b77f348c..45baf2c238d2 100644 >> --- a/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c >> +++ b/drivers/gpu/drm/panel/panel-osd-osd101t2587-53ts.c >> @@ -58,13 +58,14 @@ static int osd101t2587_panel_prepare(struct drm_panel *panel) >>   static int osd101t2587_panel_enable(struct drm_panel *panel) >>   { >>          struct osd101t2587_panel *osd101t2587 = ti_osd_panel(panel); >> -       int ret; >> >> -       ret = mipi_dsi_turn_on_peripheral(osd101t2587->dsi); >> -       if (ret) >> -               return ret; >> +       struct mipi_dsi_multi_context dsi_ctx = { >> +               .dsi = osd101t2587->dsi >> +       }; >> >> -       return ret; >> +       mipi_dsi_turn_on_peripheral_multi(&dsi_ctx); >> + >> +       return dsi_ctx.accum_err; >>   } >> >>   static const struct drm_display_mode default_mode_osd101t2587 = { >> -- >> 2.49.0 >> > > Reviewed-by: Neil Armstrong This doesn't apply anymore, please rebase. Neil