From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F8A5324B33 for ; Fri, 29 May 2026 07:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780039893; cv=none; b=tsbPvzEj2Rn2tsDW8384z32lveAD/ZGssYQMNN0Z/kWRTrEPqK4NHxOoyf6igU531K8X402+k9wWrM+hpKrMr9EwMEBG4Yqx0qgdAhY5xxdWb0stWviJwN9vi3wjwltf8N7jHvyLSDTgRfUZVQ3Wsy8K9X9Db0/Edjjbn9QANlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780039893; c=relaxed/simple; bh=kiKQdNo0DDcBdFP9nkKVecmzFIK7XiBxcfgs65fn7G4=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=FzCrE4cL91PpfHgpsvt9l1Grl/ZX9P4a0uIZ7cUMwhMzhISWMnBg/GIgLjmVkLN3xC53Mm1H8Ei8ROZ1yGjORDWGZlqomOgKtTsUu3T9wYSyaVkIaP7EGbfIHU+HgRZ5UBDM6ZvjeYUjsfQy2CSGVCYRAAKf0Rmqn2HBBv6YSxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a9ssjUro; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a9ssjUro" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-45ef41adbc1so68478f8f.0 for ; Fri, 29 May 2026 00:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780039890; x=1780644690; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=rbf61mTeeb5+bPzWqAJNBcq8SFoXoM6zULZJ7jvwjCw=; b=a9ssjUroTOgUJ3Dll1LNsnkexTdmTVwSGInpSeLKyEcJHYaSwalRRa6KoX8377RMIc Lv/tsdo6rmF2SZXa/SoxxNZ9GbwdtiNgCItBGfY4clnrpLfyTkWD05BkdNixqKFvYBKE cxXZ/3zobPXtnAHO5pfZRM3g/EugdocicEHQBq/KZ/XkYD0drz4E/vefVcsnV6elL8Pr YpoXdN+EGzR8okik5K5NKZwJZI+zsLF7Zinb1CCnWntrC7GsInLp2n9hpZDGwLx8DI34 4+2835R/J41yeS53kVbyRLrRNcIXmudtDQ90dn/7jJz6zZ8d3Ki9yvgGx5WmP8nS3X9H DWpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780039890; x=1780644690; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rbf61mTeeb5+bPzWqAJNBcq8SFoXoM6zULZJ7jvwjCw=; b=XekKBarB23ip7QwZJZFveVPMEX/iCrbbBG0aA9IwZA9eaNKTgd/Hg4mZc8g5SekyNZ d+wnrgvaswVbJEXYJPNgELzVeBsrwxH3C0zuPffM+pROSCVBK5moEedXqbGH3HxeP70s cqNETttsZbMxqq02Qcb+pfBGqMnuiHKRiF1zG4KsgWj5YK7MKZXGHWeyOMGtHDjhg2/G 7cKFEuggAE1n56nEnrMemf7mM+JnLLMRlhxmeGjTRXV6AF9qDYlIpDl8z9kmvCR+di0O O8FEKU32NvsGi7NN+ZiYRNW1yYT20zKowCDqDlQfjj+hR+MLN5AVFlThTOhxPmIHXXIJ en8A== X-Forwarded-Encrypted: i=1; AFNElJ+xYL4j07NKPMs5oesoBoXJJNFj6u9Ajs0zjSLq7ivwqULjxk/S6BBxzWJYJgQ+Jszc5yD4O7ehdo3Qbq8=@vger.kernel.org X-Gm-Message-State: AOJu0YxlC3/6Wtc69ZY1Y6u81FM4xiC7koUB1iX44lO51c8iWPd+hbCQ 7WzivgNQDhj4I2fupCc77TO0IwwFyNFl2LdkUbU/K/kEk1GaioIhZn0KI6mpBiz2hwU= X-Gm-Gg: Acq92OGw14CetcUcPmGDJGTTvYl7luWVqDNBO28baUFVabQbAPgW3wLIRPqwVC3UwHd 8tAbP+I+BdyN1qw2hR2e9ztPkNfJebNNjDYmn1DTu7+1dVaEukGpgnGNgg2xA0/LT6rXpMaj0qW 8c7AlDevzl27oKbC42laEdQVTB6cuwQWgAKYX076AVAvJ2Il5hGKIUd6JCD4bv1ChW/gHF6nsxt 6S/YvBIT7pO3Bj+6pTS5FEq6k2HF1pqCm+VaB/vMvu2/qcnwlJEz4H4x9FKkCPVM0BLdt5dlgkO EjBgiE40dna9brfPxUuWJ38D2avZAiENEpSJjluuxEwbyBkJa7IaF233B3UQsZet8m1RW4ogj6w 8HiAnXU/zgW04I+vF5jJQ3ps4S108+ztE/Vc/kHP3hOVrmZSDrGslYMBF2K/C02v4WIY3z+Xfjo mYGYg15sA9rjzLrnobdOwxfokZxBFcEGyf5zgGWORJVw== X-Received: by 2002:a05:6000:4b07:b0:45e:ec27:b4b1 with SMTP id ffacd0b85a97d-45ef140cc1bmr2805286f8f.12.1780039890330; Fri, 29 May 2026 00:31:30 -0700 (PDT) Received: from [172.20.10.3] ([37.167.96.43]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34a090dsm1495768f8f.3.2026.05.29.00.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 00:31:29 -0700 (PDT) Message-ID: <8ef7a26d-8e32-4684-b0ff-dc0c3ff4af73@linaro.org> Date: Fri, 29 May 2026 09:31:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] media: cec: meson: ao-cec-g12a: name the CEC core regmap to avoid debugfs clash To: Yi Ding , Hans Verkuil , Mauro Carvalho Chehab Cc: Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260529060005.94700-1-yi.s.ding@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260529060005.94700-1-yi.s.ding@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/29/26 08:00, Yi Ding wrote: > The driver registers two regmaps on the same platform device: an MMIO > regmap for the AO CEC registers, and an indirect regmap (using > reg_read()/reg_write() callbacks) for the CEC controller core registers. > Neither regmap_config sets a .name, so both default their debugfs > directory to the device name and collide: > > debugfs: 'ff800280.cec' already exists in 'regmap' > > Because of the clash the second regmap's debugfs directory fails to > register, so its registers can no longer be inspected via debugfs. > > Give the indirect CEC core regmap a distinct name. The two debugfs > directories then become ".cec" and ".cec-core". This only > affects debugfs naming; register access is unchanged. > > Tested on an ODROID-N2 (Amlogic S922X): the warning is gone and both > /sys/kernel/debug/regmap/ff800280.cec and ff800280.cec-core are present. > > Fixes: b7778c46683c ("media: platform: meson: Add Amlogic Meson G12A AO CEC Controller driver") > Assisted-by: Claude:claude-opus-4-8 > Signed-off-by: Yi Ding > --- > drivers/media/cec/platform/meson/ao-cec-g12a.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/cec/platform/meson/ao-cec-g12a.c b/drivers/media/cec/platform/meson/ao-cec-g12a.c > index 41f5b8669..2c914f000 100644 > --- a/drivers/media/cec/platform/meson/ao-cec-g12a.c > +++ b/drivers/media/cec/platform/meson/ao-cec-g12a.c > @@ -405,6 +405,7 @@ static int meson_ao_cec_g12a_write(void *context, unsigned int addr, > } > > static const struct regmap_config meson_ao_cec_g12a_cec_regmap_conf = { > + .name = "core", > .reg_bits = 8, > .val_bits = 8, > .reg_read = meson_ao_cec_g12a_read, Good catch Reviewed-by: Neil Armstrong Thanks, Neil