mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bernd Schubert <bernd@bsbernd.com>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	"Miklos Szeredi" <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] fuse: uapi: use UAPI types
Date: Fri, 2 Jan 2026 23:27:16 +0100	[thread overview]
Message-ID: <8efcbf41-7c74-4baf-9d75-1512f4f3fb03@bsbernd.com> (raw)
In-Reply-To: <20251230-uapi-fuse-v2-1-5a8788d62525@linutronix.de>



On 12/30/25 13:10, Thomas Weißschuh wrote:
> Using libc types and headers from the UAPI headers is problematic as it
> introduces a dependency on a full C toolchain.
> 
> Use the fixed-width integer types provided by the UAPI headers instead.
> To keep compatibility with non-Linux platforms, add a stdint.h fallback.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Changes in v2:
> - Fix structure member alignments
> - Keep compatibility with non-Linux platforms
> - Link to v1: https://lore.kernel.org/r/20251222-uapi-fuse-v1-1-85a61b87baa0@linutronix.de
> ---
>  include/uapi/linux/fuse.h | 626 +++++++++++++++++++++++-----------------------
>  1 file changed, 319 insertions(+), 307 deletions(-)

I tested this and it breaks libfuse compilation

https://github.com/libfuse/libfuse/pull/1410

Any chance you could test libfuse compilation for v3? Easiest way is to
copy it to <libfuse>/include/fuse_kernel.h and then create PR. That
includes a BSD test.


libfuse3.so.3.19.0.p/fuse_uring.c.o -c
../../../home/runner/work/libfuse/libfuse/lib/fuse_uring.c
../../../home/runner/work/libfuse/libfuse/lib/fuse_uring.c:197:5: error:
format specifies type 'unsigned long' but the argument has type '__u64'
(aka 'unsigned long long') [-Werror,-Wformat]
  196 |                 fuse_log(FUSE_LOG_DEBUG, "    unique: %" PRIu64
", result=%d\n",
      |                                                       ~~~~~~~~~
  197 |                          out->unique, ent_in_out->payload_sz);
      |                          ^~~~~~~~~~~
1 error generated.


I can certainly work it around in libfuse by adding a cast, IMHO,
PRIu64 is the right format.


Thanks,
Bernd

  parent reply	other threads:[~2026-01-02 22:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-30 12:10 Thomas Weißschuh
2025-12-30 21:09 ` Arnd Bergmann
2026-01-02 22:27 ` Bernd Schubert [this message]
2026-01-03 12:44   ` Bernd Schubert
2026-01-05  8:40     ` Thomas Weißschuh
2026-01-05  8:50       ` Bernd Schubert
2026-01-05  9:57         ` Thomas Weißschuh
2026-01-05 12:09         ` Arnd Bergmann
2026-01-08 22:12           ` Bernd Schubert
2026-01-09  8:11             ` Thomas Weißschuh
2026-01-09 10:38               ` David Laight
2026-01-09 10:45                 ` Bernd Schubert
2026-01-09 10:55                   ` Thomas Weißschuh
2026-01-09 11:36                     ` Bernd Schubert
2026-01-09 13:11                     ` David Laight
2026-01-09 13:46                       ` Bernd Schubert
2026-01-09 19:13                         ` David Laight
2026-01-08 22:14           ` Bernd Schubert
2026-01-03 14:10   ` David Laight
2026-01-03 16:47     ` Bernd Schubert
2026-01-05 12:45 ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8efcbf41-7c74-4baf-9d75-1512f4f3fb03@bsbernd.com \
    --to=bernd@bsbernd.com \
    --cc=arnd@arndb.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®