From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757025AbdESUhV (ORCPT ); Fri, 19 May 2017 16:37:21 -0400 Received: from mout.web.de ([212.227.15.14]:63045 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752608AbdESUhU (ORCPT ); Fri, 19 May 2017 16:37:20 -0400 To: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Julia Lawall Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: SF Markus Elfring Subject: [PATCH] ezusb: Delete an error message for a failed memory allocation in ezusb_writememory() Message-ID: <8f0123de-6703-4c9c-5a34-b3930262aaec@users.sourceforge.net> Date: Fri, 19 May 2017 22:37:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:oIALcu50OaHlMt795oqNUIVF6y1plwOZvIPxbSDOxIOPYBWFYaX Ocfvcoq1QhqDXntFkgO81LQpHpEuHigtRqyU1igKZjnGzxb7bCm1H8PiWIP8nEEoUS/9+Yh BDGKtpwhtEhCDVCDz1AGTYzaaLAhNnGQoGZYIO6fzTk40QBTToevvuC/sFtdQQHJ6BwDRZL PJarBlsG4g+0Xo3yPdxxQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:1S3F1Z6zCDg=:bHvcsM5lYP9OKR/ZZ+0aCL vcBO/AE/fofZs50EL3eVHziHJ7aLuOIOYqPQeWFlwTpLRIg2F7Qnz8DKvBN6IGc1LUC4+UgRr TbBewCI6WBl8Mq3lSW9NpPKbNsi8aqX/2VyBs7Psh1+FFwa4nbZ/5vZQ9+RFF4hRJiIsAsWsj oWST7MBH3G05jkrSHQTe4RyWq9JaINiHbw1MAr0wjQSAeN/XsKPOyVCaVrkuO1uOCE2iXXEl0 miZlrWtLxJaSedxD1zb0qFDu77XAFcDaGt3K3y8wHST1xIaL+prpMoUYN4BcD64cfACmS77z3 kamxRk3Su7Js+Ih2J0VsEzBGdmxMxF3kypSxCdYoU4w70X45Tmi2QngD9MvkNFMLrBH1GCshP ZcT/vLQrwCNYOqhuGyXVgbGJCCU78YZMBDbzvf2Bm30NujQfvzZPz9TwCVrO6GbDZ5gnEWof5 v77DgCrNZM9auNv5QP3CmUlpfkvxeZUIFdRFKsFij3E6PBA/vyl5MajSz2iJj8XZ/9A12CJ8O QlDkPLGEC31gNQyfpGfaVfwG+UjG+YZRnbTP7PQSOO++BEh/w+eJ/IZDaASSYNz98BxAfvETj m/0ZH34TuLUm+Ee6r5orD1suE6DAk59MP+YyoeQ8GIj7TcbJsquDZwgTCzdJWHlRS09Hl/SZ0 ckcSTtWVU7zJm8GVt4JXqzPFhYRkFc45PFajpQsPFRDnIi3+/90ZcZECLUs+bGzBsGgDLMem5 RWUsp/HT+Va6zZQ3rW4S6rUAVjNIH4Vuwv1ptSVGXSfNlvMNnpbTd8dIAd/xQRlZFpLk5i5yt aC1b4rZ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 19 May 2017 22:30:21 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/usb/misc/ezusb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/misc/ezusb.c b/drivers/usb/misc/ezusb.c index 837208f14f86..6d5e468dc897 100644 --- a/drivers/usb/misc/ezusb.c +++ b/drivers/usb/misc/ezusb.c @@ -41,11 +41,9 @@ static int ezusb_writememory(struct usb_device *dev, int address, return -ENODEV; transfer_buffer = kmemdup(data, length, GFP_KERNEL); - if (!transfer_buffer) { - dev_err(&dev->dev, "%s - kmalloc(%d) failed.\n", - __func__, length); + if (!transfer_buffer) return -ENOMEM; - } + result = usb_control_msg(dev, usb_sndctrlpipe(dev, 0), request, USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE, address, 0, transfer_buffer, length, 3000); -- 2.13.0