From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: dj76.yang@samsung.com,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
전문기 <moonki.jun@samsung.com>
Subject: Re: [PATCH] dt-bindings: net: snps: remove duplicate name
Date: Fri, 1 Apr 2022 09:48:22 +0200 [thread overview]
Message-ID: <8f02c5fc-5ded-b589-19ca-2b419c4664ab@linaro.org> (raw)
In-Reply-To: <20220401030847epcms1p8cf7a8e1d8cd7d325dacf30f78da36328@epcms1p8>
On 01/04/2022 05:08, 양동진 wrote:
> snps,dwmac has duplicated name for loongson,ls2k-dwmac and
> loongson,ls7a-dwmac.
Your "From" name seems to be different than Signed-off-by. These should
be the same, so can you fix the commit author to be the same as SoB?
>
> Signed-off-by: Dongjin Yang <dj76.yang@samsung.com>
Fixes: 68277749a013 ("dt-bindings: dwmac: Add bindings for new Loongson
SoC and bridge chip")
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2d5248f..36c85eb 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -53,20 +53,18 @@ properties:
> - allwinner,sun8i-r40-gmac
> - allwinner,sun8i-v3s-emac
> - allwinner,sun50i-a64-emac
> - - loongson,ls2k-dwmac
> - - loongson,ls7a-dwmac
> - amlogic,meson6-dwmac
> - amlogic,meson8b-dwmac
> - amlogic,meson8m2-dwmac
> - amlogic,meson-gxbb-dwmac
> - amlogic,meson-axg-dwmac
> - - loongson,ls2k-dwmac
> - - loongson,ls7a-dwmac
> - ingenic,jz4775-mac
> - ingenic,x1000-mac
> - ingenic,x1600-mac
> - ingenic,x1830-mac
> - ingenic,x2000-mac
> + - loongson,ls2k-dwmac
> + - loongson,ls7a-dwmac
> - rockchip,px30-gmac
> - rockchip,rk3128-gmac
> - rockchip,rk3228-gmac
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-01 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220401030847epcms1p8cf7a8e1d8cd7d325dacf30f78da36328@epcms1p8>
2022-04-01 3:08 ` 양동진
2022-04-01 7:48 ` Krzysztof Kozlowski [this message]
[not found] <CGME20220404022313epcms1p6767800dd9ff1f238f2ff0b560a495316@epcms1p6>
2022-04-04 2:23 ` Dong-Jin Yang
[not found] <CGME20220404022857epcms1p6e6af1a6a86569f339e50c318abde7d3c@epcms1p6>
2022-04-04 2:28 ` Dongjin Yang
2022-04-04 6:08 ` Krzysztof Kozlowski
2022-04-06 17:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f02c5fc-5ded-b589-19ca-2b419c4664ab@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dj76.yang@samsung.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moonki.jun@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®