From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 901FE29C321 for ; Sun, 8 Feb 2026 09:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770543324; cv=none; b=rstWafrO6e1cg4pAy509uF86sksw4TRA2ZqWwsoj5jEEy+i/rLhuVwgXvZhFfPNMoPmyTNLn7JMx+BcF44wR8PbDdesZH9pebpw0WFcvg/TTMGwt882bwv8eLTARzTSNMtIO3jpGFsO07ybl217oPeWFO5QrnWghNI81Fb4gJOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770543324; c=relaxed/simple; bh=d9U6GwSQ/7vFpEejYgiYa8ahEc/yyszDZ1xLAcBPuj8=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Ub/4LVYhGKBibBpqW2AAmfjILhWxt1YujcUJ/QhgUoasOFC5wSOPrE98EZgGZ+ZbK21REpAD5oXfks5mkZ4ngf+eeaoEy/D4pyxOBZQiMqYv284j8qIDkoFzFrO35bTZDzivQifaflJQexZoXt4oflg5aQLO/LGHRr9HFtm9X/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A9GeZYyB; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A9GeZYyB" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4806e0f6b69so26483215e9.3 for ; Sun, 08 Feb 2026 01:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770543323; x=1771148123; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=pyYL76OcCTb3+tyPFMjf25Mn3aXA80ZOjq+Jte1NcP8=; b=A9GeZYyBKTDJ/DoRYtAS86f8NyZACVeA5fBF4yAIVP/BbxV8XLfQMZdaz4hx5oZ/NS dMHFWxuqHC5VPed1/CXP91bbC+kUnaIl507dpfMbrlxVQErZ1X8E+kv6niSOJOSN1rJt JN77CRlGmTZFlGpZoxzr3leIGNeHdtIpL6sosxAk1SKNPOj58Rg9qS+9Ztm+/0ahuqd4 AHYhdieTKBp7v9IreVHL23zyNyqHgcHhkovVLMoAkUQpxdndtmf1pN19G6mMQ/L+/dCx aAfsp0RZsquXO/WL4T91vy8964FdSwcmE0jEDcS4wEpyLHemdwNhcNYPPb4FM/ZjP73h WCWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770543323; x=1771148123; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pyYL76OcCTb3+tyPFMjf25Mn3aXA80ZOjq+Jte1NcP8=; b=e5VLG+7JVUBBLxvbngNu2Zs5ewFo2wHg6l0boOX+fi8g33073z1z6wqWENFC41K6I1 nj40G99Z7Sp9IOa57E0aSCNxorv0Jova7ynVejd79uI8n3tTpT7xLxhSsqoVZ+NgVOSK xB2Cpn61h6R+Neh5yFE73SM6hKsee/Dsx8NPRZY4OcoIU2KMke1c5188jiJitdxBBNmE 4Lup5aNYjVdhJ6RJNGBbJvztbKJL46sq95aNewr2fIRWE3y3h6nJKSJ4Q0dDkI3xyE/6 yK2bJF6oyfsrNVK2MssPn4pfV0vpLUGD7rTSm11gwJlf7y20Tas2tfhFP2AsFTPSdoyx sW/w== X-Forwarded-Encrypted: i=1; AJvYcCXdWeB561KaZEoyUTZiSj5O8MHOR9aN77C3MO7nrBfF/C9gaEkp+q/0yMzCcY/YPfAFgFjJSK4ktuEV6zA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywf9og23d7apHp1SyOFaNAJBAm0hnL8MZE4WbzN1+3wHwRg3+DN gW7svBwwcd59056TMNXXQIY74pgGqO0lCYVGq/pv2FFq7um1GvhE5qt2 X-Gm-Gg: AZuq6aL43dkcGO5ZmR2dINsrWqCitcMJ6MGBlu3S0ABK9hECLdrmUzbo5phZkdNE6N8 Ihql7qx3bZwm/JxLA+mDH+ScQpKfn0OLWT5qCh23boXRLyPGQWul522mxUAbBB2q2u87qwLjCwd 4wf2dCboCjcAEWH9zeUaDQVAUCQ3FyzNUI7aVKRVjR8n74XQhoUETeSf3uPoCrJ6ip72YpnhGrf Eh9GfSoMBj7RGh2NJGF+jB/mrgXhaz8gPBQ+HwIByoF5RBQgiZ4zkR+5XEa75h5tVaPtSpijNWm YYjG7ltS87mGbBqL2u6xLQ3r2+ZwJegAh8cRd6PZKYWdNXz7AEeJ5W8VYEmzDKxKlzv09czY3dg 4g/5kcXlEduKLin5J+PRzLG4/XXZNLdRuiqrU34KwfVmNRfgBmybvc+0wS4VEY0AhSySqhUGfWw Rtr2iJGnqGtsA+9cP7n1YMs23csj2Dtr3hkEGme5roKjOGeRhwnfG5x+J4NLY= X-Received: by 2002:a05:600c:81ca:b0:480:68ed:1e70 with SMTP id 5b1f17b1804b1-483202282c4mr131276045e9.35.1770543322861; Sun, 08 Feb 2026 01:35:22 -0800 (PST) Received: from ?IPv6:2001:818:ea56:d000:94c4:fb0e:28f:2a8d? ([2001:818:ea56:d000:94c4:fb0e:28f:2a8d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483203f529bsm67359295e9.4.2026.02.08.01.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Feb 2026 01:35:22 -0800 (PST) Message-ID: <8f0d63a6d2a4cfca52ea6c80595a2f1eda3713cf.camel@gmail.com> Subject: Re: [PATCH 4/6] iio: adc: ad4080: add support for AD4085 From: Nuno =?ISO-8859-1?Q?S=E1?= To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 08 Feb 2026 09:36:26 +0000 In-Reply-To: <587dbc9c21b49c7d99b6b5b8dad419fad415e040.1770382796.git.antoniu.miclaus@analog.com> References: <587dbc9c21b49c7d99b6b5b8dad419fad415e040.1770382796.git.antoniu.miclaus@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-02-06 at 15:08 +0200, Antoniu Miclaus wrote: > Add support for AD4085 16-bit SAR ADC. The AD4085 has the same > resolution as AD4084 (16-bit) but differs in LVDS CNV clock count > maximum (8 vs 2). >=20 > Changes: > - Add AD4085_CHIP_ID definition (0x0055) > - Create ad4085_channel with 16-bit resolution and 16-bit storage > - Add ad4085_chip_info with lvds_cnv_clk_cnt_max =3D 8 > - Register AD4085 in device ID and OF match tables >=20 > Signed-off-by: Antoniu Miclaus > --- I do agree with Andy that the commit is too verbose. With that handled: Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/iio/adc/ad4080.c | 15 +++++++++++++++ > =C2=A01 file changed, 15 insertions(+) >=20 > diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c > index 7cbbe284dea7..728df626f09e 100644 > --- a/drivers/iio/adc/ad4080.c > +++ b/drivers/iio/adc/ad4080.c > @@ -130,6 +130,7 @@ > =C2=A0#define AD4082_CHIP_ID 0x0052 > =C2=A0#define AD4083_CHIP_ID 0x0053 > =C2=A0#define AD4084_CHIP_ID 0x0054 > +#define AD4085_CHIP_ID 0x0055 > =C2=A0#define AD4086_CHIP_ID 0x0056 > =C2=A0#define AD4087_CHIP_ID 0x0057 > =C2=A0 > @@ -449,6 +450,8 @@ static const struct iio_chan_spec ad4083_channel =3D > AD4080_CHANNEL_DEFINE(16, 16) > =C2=A0 > =C2=A0static const struct iio_chan_spec ad4084_channel =3D AD4080_CHANNEL= _DEFINE(16, 16); > =C2=A0 > +static const struct iio_chan_spec ad4085_channel =3D AD4080_CHANNEL_DEFI= NE(16, 16); > + > =C2=A0static const struct iio_chan_spec ad4086_channel =3D AD4080_CHANNEL= _DEFINE(14, 16); > =C2=A0 > =C2=A0static const struct iio_chan_spec ad4087_channel =3D AD4080_CHANNEL= _DEFINE(14, 16); > @@ -503,6 +506,16 @@ static const struct ad4080_chip_info ad4084_chip_inf= o =3D { > =C2=A0 .lvds_cnv_clk_cnt_max =3D 2, > =C2=A0}; > =C2=A0 > +static const struct ad4080_chip_info ad4085_chip_info =3D { > + .name =3D "ad4085", > + .product_id =3D AD4085_CHIP_ID, > + .scale_table =3D ad4080_scale_table, > + .num_scales =3D ARRAY_SIZE(ad4080_scale_table), > + .num_channels =3D 1, > + .channels =3D &ad4085_channel, > + .lvds_cnv_clk_cnt_max =3D 8, > +}; > + > =C2=A0static const struct ad4080_chip_info ad4086_chip_info =3D { > =C2=A0 .name =3D "ad4086", > =C2=A0 .product_id =3D AD4086_CHIP_ID, > @@ -682,6 +695,7 @@ static const struct spi_device_id ad4080_id[] =3D { > =C2=A0 { "ad4082", (kernel_ulong_t)&ad4082_chip_info }, > =C2=A0 { "ad4083", (kernel_ulong_t)&ad4083_chip_info }, > =C2=A0 { "ad4084", (kernel_ulong_t)&ad4084_chip_info }, > + { "ad4085", (kernel_ulong_t)&ad4085_chip_info }, > =C2=A0 { "ad4086", (kernel_ulong_t)&ad4086_chip_info }, > =C2=A0 { "ad4087", (kernel_ulong_t)&ad4087_chip_info }, > =C2=A0 { } > @@ -694,6 +708,7 @@ static const struct of_device_id ad4080_of_match[] = =3D { > =C2=A0 { .compatible =3D "adi,ad4082", &ad4082_chip_info }, > =C2=A0 { .compatible =3D "adi,ad4083", &ad4083_chip_info }, > =C2=A0 { .compatible =3D "adi,ad4084", &ad4084_chip_info }, > + { .compatible =3D "adi,ad4085", &ad4085_chip_info }, > =C2=A0 { .compatible =3D "adi,ad4086", &ad4086_chip_info }, > =C2=A0 { .compatible =3D "adi,ad4087", &ad4087_chip_info }, > =C2=A0 { }