From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f99.google.com (mail-oa1-f99.google.com [209.85.160.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D1B031716E for ; Tue, 5 May 2026 15:34:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.99 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777995290; cv=none; b=UuLa1ToGPgGDE7E3+jMMtCtqbcsv6rs5CiTpqU3yowEaps3jAxzhy9GKzs+zaGcbeEfs9o0lqFphpx4yc2oA1YTiF1iQcdMOjexLP3AMmH/IH9xsz9Dyzip43PvgJPxTLIqdtH5t5OsLkvYyxedksjlSyQ7y86aOsAjPBVqwNw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777995290; c=relaxed/simple; bh=g50FWd240XxxeHR0wZZltMJw7SH0rpOeuhOkFOG+fy4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=PZgYyHfwmCj4CWLFvxqRO2LmMGm+88lYUOWfRmXWhMfImvpTqNdA12YOo02+TfgRInq2jggcS4SQg2YDJ8iQuADwzz6C9/MGpVWu2xwiPhjaAaQjKWDC/TtztRznj1qKC5bHhwa+fyaBKWIMiVIAuqK5DMR90xjlkhN5YxHezMw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ULPnBneo; arc=none smtp.client-ip=209.85.160.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ULPnBneo" Received: by mail-oa1-f99.google.com with SMTP id 586e51a60fabf-42fdab683b7so2828922fac.3 for ; Tue, 05 May 2026 08:34:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777995287; x=1778600087; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kA0xbWBKz7CEhEmimLuZzTtRlEkl5OY8Zl0ZAfchvHM=; b=OzNz4k7TJM4FIndH41aN69BSX+ztzWk9ExncTmXSb9UITTdLLcJbSzx5MtY6AnQHqm zkgGXTaVQ4GLmSITwEEVgS1LOHida8EMtiu2+OYvH8Xviq1I6+SAnTWXnNfLDcysrjUL kG1NSFwVNsGkeeXnCNfXtHQDlo8E9/WtNd9WTcT+RCbzrAEYDkiY382GD8e4MHfgVDe5 IaEDrfYeLeHI1Nw0ctwWCGIN0AGEduZFdWh6f7dvKutK5qM3lzsucmIJeIS3ZhYGz8TY /LMopF9SYGe7Zl9Sfru7BdcYOJdGzfDf9EZGjqH6yvTjF7h4TMPc/fOEC5Tq+jA2W5I8 IGnw== X-Forwarded-Encrypted: i=1; AFNElJ/5zOqhRwZHGwhAG1uiahaLwZRneiXMCLv4yjIdRhbqlneDHFCyJDBDUpJfkAO5h5YmaM3qBtU6Do40JpY=@vger.kernel.org X-Gm-Message-State: AOJu0YzxvMC7pEZ8KJ8FMkihayYXwTumpVkCzw/R7AqF+3mHyldBaU6N ymFUsLUN6lJtsQG5WjU5y3heL1BcYu1tIVwfqiKLS0bWueL0Jo3vkrXQqs8qMND14kCylHqCVLK q/6SajapDIWeQAT/17RSOFBgSnJXwdvdqTpY7azpmlw3v6QhG1SR2epbGXom6EhbsmPoERZWyRF P0aboX0WEVD+lsq6aVLR0c8NNmwzjljQv/DQS7LwJHe4O6SgAH+S4hQ6nZ50E2OUuWMw+xvFvJy WqsiYinn3inSHbpD8x5H7hD X-Gm-Gg: AeBDievBK1/pd/cCVSc7b8AQ5Q3g0eazrTQOOdUe1INZDhCJYdQSkOkrqLStk9WC0Mo SWH5heZbkISslSdAyCjUzHpGgRwqv3XnFYdC68DnKuCVvc0iIR8z5CK+3/IJYh2s1f76lZoEmL9 I1HojwngbHWUSZ6xo5l6h1RByXs/xI4TZL3XGLQkgWaLvuwVfuZKJnL8cjRfm7+FYQNp/xTKoG2 Dx9apAPHnTfuc8srNB2UPZREuGBOCSN69Vemtg0ZSYPNOlWfjb6q2zXaydp25B4iz3TPx5FwMnn uWYOaLvkeYhwnBzlKZtr0GZeaUXZIiWYiDehPwmTIA4+o507tG9wZvANns6gaU9VQpsI/+lAW/J ae8Efx+uiplH9dX50Z7TfhYgyf8uVOJO1HUs4q/ghxGotM81LNSMZKIK/Fxox43qX32V+VyH6fF 7Q4W/Oj98KaIrwxlu797L+ya0f1HnjxuduuxBe95O03zCuOss5O0ar2RkcV6m8SyNcHULkZe/E X-Received: by 2002:a05:6820:1508:b0:694:8f3a:3f36 with SMTP id 006d021491bc7-69697a0cc2amr7551755eaf.27.1777995287342; Tue, 05 May 2026 08:34:47 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-21.dlp.protect.broadcom.com. [144.49.247.21]) by smtp-relay.gmail.com with ESMTPS id 006d021491bc7-696894ce61esm884628eaf.17.2026.05.05.08.34.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2026 08:34:47 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2ba9a744f7dso9086739eec.0 for ; Tue, 05 May 2026 08:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1777995286; x=1778600086; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=kA0xbWBKz7CEhEmimLuZzTtRlEkl5OY8Zl0ZAfchvHM=; b=ULPnBneovLPsIe+Naua8d5UHN8jWZsR7DbQ7yxyjmC66Ag/SOH6r4TujUdLH2KflJd Xr/p0831FtheR5GmYXFZy+Hf3kN/XkDp3/3nxmnH+6LfGAvVeGh7FdanBGQHk6yhFnho c9ch4X0uqt64HqZYpw82QPlH6gSF+UvEg9ho8= X-Forwarded-Encrypted: i=1; AFNElJ/fFcDA6Z3wZHsUFgvhy5PCE6XM9QUsz5TB55BSpqeBKLz9iLQzrozHyMA/+JEzpJJfUnH8uj15MUnSkvo=@vger.kernel.org X-Received: by 2002:a05:7301:1001:b0:2dd:2d70:8aba with SMTP id 5a478bee46e88-2efb78d70ccmr6578839eec.4.1777995285424; Tue, 05 May 2026 08:34:45 -0700 (PDT) X-Received: by 2002:a05:7301:1001:b0:2dd:2d70:8aba with SMTP id 5a478bee46e88-2efb78d70ccmr6578827eec.4.1777995284858; Tue, 05 May 2026 08:34:44 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3bc6a79esm24306770eec.26.2026.05.05.08.34.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 08:34:43 -0700 (PDT) Message-ID: <8f1380f4-6ef8-4fc8-b72e-4df7b6b3cbad@broadcom.com> Date: Tue, 5 May 2026 08:34:41 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] leds: Move MODULE_DEVICE_TABLE next to the table itself To: Krzysztof Kozlowski , Lee Jones , Pavel Machek , William Zhang , Anand Gore , Kursad Oney , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Broadcom internal kernel review list , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Benson Leung , Guenter Roeck , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev References: <20260505102846.186219-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260505102846.186219-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 5/5/26 03:28, 'Krzysztof Kozlowski' via BCM-KERNEL-FEEDBACK-LIST,PDL wrote: > By convention MODULE_DEVICE_TABLE() immediately follows the ID table it > exports, because this is easier to read and verify. It also makes more > sense since #ifdef for ACPI or OF could hide both of them. > > Most of the privers already have this correctly placed, so adjust > the missing ones. No functional impact. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/leds/blink/leds-bcm63138.c | 2 +- For the above: Reviewed-by: Florian Fainelli -- Florian