From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6D90C7EE2D for ; Wed, 31 May 2023 15:21:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234389AbjEaPVA (ORCPT ); Wed, 31 May 2023 11:21:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234376AbjEaPUq (ORCPT ); Wed, 31 May 2023 11:20:46 -0400 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFBCEC0; Wed, 31 May 2023 08:20:45 -0700 (PDT) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34VFAMQ9016533; Wed, 31 May 2023 15:20:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=oEEcKiFgY9vra52CwE7tjULdms9UfcoallSLp2b3u8o=; b=bwl0FPHM/4ntUomgRjHM3WD4YDk93aTNRmJMsc3qO3MoHC1jVlLdH6dcaOG4XjTCSPp1 yoeAQwE4gxcH1m2MbEi0E+chMugn4sJFs0ALtqGWuk2Rf8BB9uK1eNabCl4MbSE4CYuO g3OS6lkDm4xRSsJvFCtsZ4B0pGVAcC421dduJC0V3raF1q4x2BGZb3/QpEudH4q024Bt MAGMCzJxK+dbDLgFkUgL2YM3ncmBFjUrz2fwcck+TQWDeQQOVkfRqaT4Ze0YAdBPDkSg 6Yy3oE8KDn1KdgTcQxIunWsKNHoZbyNWrlNIbK+IjxYhyB/AmOP7It5irqWJZGdVzfW+ gw== Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qx88f1duv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 May 2023 15:20:34 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34VEA7xP016838; Wed, 31 May 2023 15:20:32 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3qu9g6qch2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 May 2023 15:20:32 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34VFKVRg7996012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 May 2023 15:20:31 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 67F6A58055; Wed, 31 May 2023 15:20:31 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9FB915804B; Wed, 31 May 2023 15:20:30 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 31 May 2023 15:20:30 +0000 (GMT) Message-ID: <8f15feb5-7c6e-5a16-d9b4-008b7b45b01a@linux.ibm.com> Date: Wed, 31 May 2023 11:20:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] tpm: factor out the user space mm from tpm_vtpm_set_locality() Content-Language: en-US To: Jarkko Sakkinen , linux-integrity@vger.kernel.org Cc: Jason Gunthorpe , Alejandro Cabrera , Jarkko Sakkinen , stable@vger.kernel.org, Stefan Berger , linux-kernel@vger.kernel.org References: <20230530205001.1302975-1-jarkko@kernel.org> From: Stefan Berger In-Reply-To: <20230530205001.1302975-1-jarkko@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: stsieOlycXYqpPzetXMRnHjT128JFlko X-Proofpoint-ORIG-GUID: stsieOlycXYqpPzetXMRnHjT128JFlko X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-31_10,2023-05-31_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 suspectscore=0 mlxlogscore=709 spamscore=0 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305310128 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/23 16:50, Jarkko Sakkinen wrote: > From: Jarkko Sakkinen > > vtpm_proxy_fops_set_locality() causes kernel buffers to be passed to > copy_from_user() and copy_to_user(). And what is the problem with that? Is it not working? > > Factor out the crippled code away with help of an internal API for > managing struct proxy_dev instances. What is crippled code? Stefan