From: Johannes Berg <johannes@sipsolutions.net>
To: Masahiro Yamada <masahiroy@kernel.org>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: remove object duplication in Makefile
Date: Mon, 06 Jan 2020 16:51:25 +0100 [thread overview]
Message-ID: <8f17a0bca11604d9818326b01267186bd91236c9.camel@sipsolutions.net> (raw)
In-Reply-To: <20200106075439.20926-1-masahiroy@kernel.org> (sfid-20200106_090403_620011_D178F66E)
On Mon, 2020-01-06 at 16:54 +0900, Masahiro Yamada wrote:
> The objects in $(iwlwifi-objs) $(iwlwifi-y) $(iwlwifi-m) are linked to
> iwlwifi.ko .
>
> This line adds $(iwlwifi-m) to iwlwifi-objs, so the objects from
> $(iwlwifi-m) are listed twice as the dependency of the module.
Are you sure? We have
obj-$(CONFIG_IWLWIFI) += iwlwifi.o
and then "iwlwifi-y += ...", but I was under the impression that
iwlwifi.o didn't really pick up iwlwifi-m automatically, that's not
something that you'd normally do, normally -m only makes sense to build
a module using "obj-m", just here we do it for the mvm sub level
stuff...
johannes
next prev parent reply other threads:[~2020-01-06 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 7:54 Masahiro Yamada
2020-01-06 15:51 ` Johannes Berg [this message]
2020-01-06 17:11 ` Masahiro Yamada
2020-01-06 17:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f17a0bca11604d9818326b01267186bd91236c9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®