mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jijie Shao <shaojijie@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <shaojijie@huawei.com>,
	Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <shenjian15@huawei.com>,
	<wangpeiyang1@huawei.com>, <liuyonglong@huawei.com>,
	<chenhao418@huawei.com>, <sudongming1@huawei.com>,
	<xujunsheng@huawei.com>, <shiyongbang@huawei.com>,
	<libaihan@huawei.com>, <zhuyuan@huawei.com>,
	<forest.zhouchang@huawei.com>, <jdamato@fastly.com>,
	<horms@kernel.org>, <jonathan.cameron@huawei.com>,
	<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V8 net-next 05/11] net: hibmcge: Implement some .ndo functions
Date: Tue, 10 Sep 2024 14:26:10 +0800	[thread overview]
Message-ID: <8f17b1be-cf69-4701-ab62-40141b1cbf99@huawei.com> (raw)
In-Reply-To: <49166f60-bf25-4313-bacb-496103086d40@lunn.ch>


on 2024/9/9 22:48, Andrew Lunn wrote:
>> No, HBG_NIC_STATE_OPEN is not intended to ensure that hbg_net_open() and
>> hbg_net_stop() are mutually exclusive.
>>
>> Actually, when the driver do reset or self-test(ethtool -t or ethtool --reset or FLR).
>> We hope that no other data is transmitted or received at this time.
> That is an invalid assumption. You could be receiving line rate
> broadcast traffic for example, because there is a broadcast storm
> happening.
>
> I assume for testing, you are configuring a loopback somewhere? PHY
> loopback or PCS loopback? I've seen some PHYs do 'broken' loopback
> where egress traffic is looped back, but ingress traffic is also still
> received. Is this true for your hardware? Is this why you make this
> assumption?
>
> What is your use case for ethtool --reset? Are you working around
> hardware bugs? Why not simply return -EBUSY if the user tries to use
> --reset when the interface is admin up. You then know the interface is
> down, you don't need open/close to be re-entrant safe.
>
> Same for testing. Return -ENETDOWN if the user tries to do self test
> on an interface which is admin down.
>
> 	Andrew

Good idea. I'll remove priv->state first in v9. We'll discuss this 
internally. Thank you very much. Jiji Shao


  reply	other threads:[~2024-09-10  6:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09  2:31 [PATCH V8 net-next 00/11] Add support of HIBMCGE Ethernet Driver Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 01/11] net: hibmcge: Add pci table supported in this module Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 02/11] net: hibmcge: Add read/write registers supported through the bar space Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 04/11] net: hibmcge: Add interrupt " Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 05/11] net: hibmcge: Implement some .ndo functions Jijie Shao
2024-09-09  3:05   ` Kalesh Anakkur Purayil
2024-09-09  4:04     ` Jijie Shao
2024-09-09 12:19       ` Andrew Lunn
2024-09-09 14:30         ` Jijie Shao
2024-09-09 14:48           ` Andrew Lunn
2024-09-10  6:26             ` Jijie Shao [this message]
2024-09-09  2:31 ` [PATCH V8 net-next 06/11] net: hibmcge: Implement .ndo_start_xmit function Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 07/11] net: hibmcge: Implement rx_poll function to receive packets Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 08/11] net: hibmcge: Implement some ethtool_ops functions Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 09/11] net: hibmcge: Add a Makefile and update Kconfig for hibmcge Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 10/11] net: hibmcge: Add maintainer " Jijie Shao
2024-09-09  2:31 ` [PATCH V8 net-next 11/11] net: add ndo_validate_addr check in dev_set_mac_address Jijie Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f17b1be-cf69-4701-ab62-40141b1cbf99@huawei.com \
    --to=shaojijie@huawei.com \
    --cc=andrew@lunn.ch \
    --cc=chenhao418@huawei.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=forest.zhouchang@huawei.com \
    --cc=horms@kernel.org \
    --cc=jdamato@fastly.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=libaihan@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=salil.mehta@huawei.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=shiyongbang@huawei.com \
    --cc=sudongming1@huawei.com \
    --cc=wangpeiyang1@huawei.com \
    --cc=xujunsheng@huawei.com \
    --cc=zhuyuan@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®