From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2604A3191B8 for ; Wed, 7 Jan 2026 10:27:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781653; cv=none; b=bjgZOGI1D2MX7retTbSlD1QrTihacpqKioKwI3mkP0DsA7VY3GV54uTzyaDcwDepVRBFKe6INrKHFGxReKBKOtdcqvxwgS3qYkT/id5E/reNNVT2++UXUtPew+F5gcJDtW8qcjMvLjeYImYRXa69wiFSuncZ3l/xm8+xi2M9bfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781653; c=relaxed/simple; bh=jxxOLKWQy24X1JdBxMKRyeqBnPRYT3VXTWPuCnAcFg8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jpk0qdTSuHPfMa3sH1m7jRekF3BOYfSEds5ySr+NJwjKNnFbeWLhEyklUE6zlRYxybmrZbWBWo9PpJFI5lvTXFLomlrN2Z3e1MUpVL+X+FVbETaqkjh10joB5N8JZLFoHTl/7eYBC3AOwOKE/IshIc4acFGwqrp+GW1CLHJPvwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DEmx6uct; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EhM3qbFU; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DEmx6uct"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EhM3qbFU" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6076tHVD2378918 for ; Wed, 7 Jan 2026 10:27:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Dd18Z1YzmeXBFzrrg4MrKCKtq5jjlT4LY/xzF2U61z4=; b=DEmx6uctIURqOGQd XRdYb+08Y8JQmg/rLOTTmrSD1uhlH5Ob1Kb5pK2A0IYCRoORBmZ1iKfllPakWBhu ZcwFV9DFMqMRhm0skF/dg7jvFCLIrq+H/2Pjl/on6xJQWI76tH851JzRabgosyoJ w5zyOzOLMAtd7S3une893xP7VwIqwqnDBEim5XuvMvyqMxWC6A7xidugtDykGF6d d4rVqvlBCHCiRwNyIE7fMIx0m/byPvFBW1/K3n5mxagf7lX2x7Ut+wnzbwvw4DYQ v3sAxQNpMTKrEQiFX5zoC9/DNw9DCq61duLcAV3K3ua12GEf9d7KrX+RZEy73ElC io54sg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhjn4rpb8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 10:27:30 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2a089575ab3so23739385ad.0 for ; Wed, 07 Jan 2026 02:27:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767781650; x=1768386450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Dd18Z1YzmeXBFzrrg4MrKCKtq5jjlT4LY/xzF2U61z4=; b=EhM3qbFU6/V+y3hvPh8AumYHRCbmFLQyoDk3YL/MtDn3FAnZ7VTaFvruJ52HUX7jLP kzqilUjvADwVuxPllhnZTxngLys+l+/iYE0U6eq5NfPy1Z/h0nH0luwkK+s71GJbJqo3 Tf+u9sWk08UQIT0KiuMmX4IyJJH2RDF2r0baYfMs3GRcfmq6JstOL97Fiq/wqacfEGIH Vs1wU5zdOoW0qDJgMNdBvJzRLMX/7myqvLDYYujnzMMUWfR4SNghHkHwXkZglMsufRvS 7cCYfnXkdUJ8buJJpsOuIa5vyxHmcfX4bMljq/dujyg7MCFRQS6Bs3UnN2s9amZD0Rmm ipIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767781650; x=1768386450; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dd18Z1YzmeXBFzrrg4MrKCKtq5jjlT4LY/xzF2U61z4=; b=Rpy2R2R3ME7YrCbHrsTvJ+pt/0guloBSjO14WcIgOedltr1VlDp8mxpFNsCheJKGQZ aGmA5+KOSHDBVM6dM28PuYbwMQFHoCRsNQq9hq6PiUMmOFAwOXn1CsVMsYRcSfpw13im 4BPWqBc9YsFlJg6VJ0V6OTFrNY8KiRLHaPjXdYr22W0w3GjFU0VYaQd5jqPGYh/TxxFD 3lXvUNxIKs+rb9ogPghLa2CeJhKjdI9aS9ZOKjocaCRUizhT+D4vESVt1JYbGUobWrx4 IsiV/aEerRw82oQAQiTQx9dzyt+uUWOdEq+yPEU/so4O3O9IkGHOkx0f0oNAfg1WgP1W Sz+Q== X-Forwarded-Encrypted: i=1; AJvYcCWzTn8TP7eLrMFjAsFInCW/5dVnmMQuPwbRtAP7Et6HBr5BhdwDvytblnthBQuskvdOe3TneAl9HFcyUuA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu3NMm88qrdQY00eN6fNenaq4q2cLMw/dmyliXYnbnIskz5YnN v4QyMl4zm4gmmZHBtQKU43aVnS3SnAkFJm7ZMZU01eEqzo3bez1mSrIWHa/i7Z2G4gggtHweAF2 dULaoxTeG+PflMZkkDEFQt54v6K+c3qgXiRBLF1kCmHptEk9XADx3rX3rxXCHpDbTHDE= X-Gm-Gg: AY/fxX5X/QvvE/tkKdCgotBWps5Or4cZ29Xzz6TnB+BIsJAQqhDeygLVpGuMuTZlt6R R5WRuX3+IUS98lljjlyClOOIRucXyNpq6qaHrCmsm3pbabbYX/2CN0sGOkZNu96P9eruS2k0Z7G EmwgX9SLYqaK2pZJZGV8DzdjuTAFXQa/l9zNp7NIcdFAFag97L1RZr5sjvNjggzG0uZ2iUXP/lU ZH3W4rW0/gbla0AH9RtPNG+0VmNWj/oZpexGnejdKD4LnH5FE/q7D4WNRSXGS89F0m7PMVhIeDQ tmhx98KpYMU2JCCHySmwARC3rXAJ1ADADGauewBoYfU2n5mY12aLMgv300RHrV+7pOQ0R65WoKF qa9949WM7EMZWoNcVhZ/hpfLh1BjQxLtZ7Zii6J1HDA== X-Received: by 2002:a17:902:ce08:b0:2a0:34ee:3725 with SMTP id d9443c01a7336-2a3ee4456c1mr19470415ad.14.1767781649718; Wed, 07 Jan 2026 02:27:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9ywrDhvBZ0wnU7MYSCgeUFZYxYnTIlc0Ny6WlDiHewTpQIXm6yQb6LXotIU6yBAibh93cyw== X-Received: by 2002:a17:902:ce08:b0:2a0:34ee:3725 with SMTP id d9443c01a7336-2a3ee4456c1mr19470135ad.14.1767781649225; Wed, 07 Jan 2026 02:27:29 -0800 (PST) Received: from [10.206.101.19] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cd2ac2sm47256485ad.90.2026.01.07.02.27.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 02:27:28 -0800 (PST) Message-ID: <8f1b8d75-e3db-42e6-ba47-ce4d26aa6987@oss.qualcomm.com> Date: Wed, 7 Jan 2026 15:57:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] media: iris: Skip resolution set on first IPSC To: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Wangao Wang Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue References: <20251229-iris-fixes-v2-0-6dce2063d782@oss.qualcomm.com> <20251229-iris-fixes-v2-2-6dce2063d782@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20251229-iris-fixes-v2-2-6dce2063d782@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=LJhrgZW9 c=1 sm=1 tr=0 ts=695e3512 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=R43CkeNY5TQw8y71x44A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDA4NSBTYWx0ZWRfX66NIoGEfJ/jA wf9fqND4Wi9NE0xZSgoOz1ebMIEv3t7USdPwDrcqZZPsAJTu4gcuDmPI2mYeuC8AXzaztGndRi7 ocCodrwVmflKsMBrTu0KiUyzaUgiGPeBN2twXwGI9E0OLH/GCI+a2KHwHLp0+eZD3UH9FiRKKBJ lNVccrRfKxp31QRUyeu+qM27fw04yR/+5AzoZdrAlFYqgqXsmSFMRwaNnt3mkbw1sIaHtAC0vAK Str/jGlEIc4aMYh/xjO0XV2WyLiLOo8DUmF6VhoJHXVOORrVdoNcENvRQh67KVY/5zzXY0sab0q 8u0rr/90AlEY9uw4+oo8eLPYDIiuJiBsBrTSMBiYGLbFDzPdsjO3DhoHWmi1ayZCzWrRLD/lIS6 Vt8gqOV/i6Ca7wdZBGCEfiBqOlCZqZWN/pPOW1nlSr9Mpp0g4yNfKqHBmgngtk8S364KpeYHeFm wRKMLvAtFAi9Yp4Qhtw== X-Proofpoint-GUID: Rw588P6XaMwkjvbUWo9AO6XhYk_j39Rv X-Proofpoint-ORIG-GUID: Rw588P6XaMwkjvbUWo9AO6XhYk_j39Rv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070085 On 12/29/2025 12:01 PM, Dikshita Agarwal wrote: > The resolution property is not supposed to be set during reconfig. > Existing iris_drc_pending(inst) check is insufficient, as it doesn't > cover the first port setting change. > > Extend the conditional check to also skip resolution setting when > the instance is in IRIS_INST_SUB_FIRST_IPSC. > > Fixes: caf205548769 ("media: iris: Avoid updating frame size to firmware during reconfig") > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dikshita Agarwal > --- > drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > index 52da7ef7bab08fb1cb2ac804ccc6e3c7f9677890..5087e51daa842515e9d62730680fb237bf274efa 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c > @@ -733,7 +733,7 @@ static int iris_hfi_gen1_set_resolution(struct iris_inst *inst, u32 plane) > struct hfi_framesize fs; > int ret; > > - if (!iris_drc_pending(inst)) { > + if (!iris_drc_pending(inst) && !(inst->sub_state & IRIS_INST_SUB_FIRST_IPSC)) { > fs.buffer_type = HFI_BUFFER_INPUT; > fs.width = inst->fmt_src->fmt.pix_mp.width; > fs.height = inst->fmt_src->fmt.pix_mp.height; > Reviewed-by: Vikash Garodia