From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754574AbcICAIn (ORCPT ); Fri, 2 Sep 2016 20:08:43 -0400 Received: from smtprelay.synopsys.com ([198.182.60.111]:35588 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551AbcICAIl (ORCPT ); Fri, 2 Sep 2016 20:08:41 -0400 Subject: Re: cmsg newgroup alt.sex.fetish.bool (was Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions) To: Chen Gang , Al Viro References: <1472362755-26776-1-git-send-email-chengang@emindsoft.com.cn> <201608291503.41630.arnd@arndb.de> <80e3ae6c-e81d-3541-9051-07ad726b59cd@synopsys.com> <57C4ADD1.6020609@emindsoft.com.cn> <20160901204348.GQ2356@ZenIV.linux.org.uk> <57CA0C5D.1080701@emindsoft.com.cn> CC: Arnd Bergmann , "akpm@linux-foundation.org" , "minchan@kernel.org" , "vbabka@suse.cz" , "gi-oh.kim@profitbricks.com" , "iamjoonsoo.kim@lge.com" , "hillf.zj@alibaba-inc.com" , "mgorman@techsingularity.net" , "mhocko@suse.com" , "rientjes@google.com" , "linux-kernel@vger.kernel.org" , "rth@twiddle.net" , "ink@jurassic.park.msu.ru" , "mattst88@gmail.com" , "linux@armlinux.org.uk" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "hskinnemoen@gmail.com" , "egtvedt@samfundet.no" , "realmz6@gmail.com" , "ysato@users.sourceforge.jp" , "rkuo@codeaurora.org" , "tony.luck@intel.com" , "fenghua.yu@intel.com" , "geert@linux-m68k.org" , "james.hogan@imgtec.com" , "ralf@linux-mips.org" , "dhowells@redhat.com" , "deller@gmx.de" , "benh@kernel.crashing.org" , "paulus@samba.org" , "mpe@ellerman.id.au" , "schwidefsky@de.ibm.com" , "heiko.carstens@de.ibm.com" , "dalias@libc.org" , "David S. Miller" From: Vineet Gupta Message-ID: <8f1f06e3-0ca1-dfec-3ccf-ca155c61fdc6@synopsys.com> Date: Fri, 2 Sep 2016 17:07:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57CA0C5D.1080701@emindsoft.com.cn> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.130.78] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2016 04:33 PM, Chen Gang wrote: > On 9/2/16 04:43, Al Viro wrote: >> > On Tue, Aug 30, 2016 at 05:49:05AM +0800, Chen Gang wrote: >> > >>> >> Could you provide the related proof? >>> >> >>> >> Or shall I try to analyze about it and get proof? >> > >> > Can you show a proof that it actually improves anything? He who proposes >> > a patch gets to defend it, not the other way round... >> > >> > Al, bloody annoyed >> > > OK, what you said sounds reasonable to me. > > It makes the code more readable since they are really pure Boolean > functions, and let the functions are precisely same in all archs. But > really, I shall try to prove that it has no negative effect. > > e.g. for arc arch. now, I have built the arc raw compiler to build arc > kernel, but excuse me, I plan to finish proof next week, because during > these days, I have to work, buy house, and focus on my father's health. Since you seem to be have so much stuff to do I decided to help. I did a quick compile of kernel with and w/o your changes bloat-o-meter vmlinux-v4.8rc4-baseline vmlinux-v4.8rc4-bool-in-atomics add/remove: 0/0 grow/shrink: 1/0 up/down: 6/0 (6) function old new delta vermagic 49 55 +6 Total: Before=5967447, After=5967453, chg 0.000000% I'm mildly surprised that there is no difference so yeah this change is fine as far as I'm concerned. -Vineet