From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933166AbcFQDbw (ORCPT ); Thu, 16 Jun 2016 23:31:52 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:34789 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754906AbcFQDbu (ORCPT ); Thu, 16 Jun 2016 23:31:50 -0400 From: Geliang Tang To: Minchan Kim , Nitin Gupta , Sergey Senozhatsky Cc: Geliang Tang , linux-kernel@vger.kernel.org Subject: [PATCH] zram: use writer semaphores in device attributes store Date: Fri, 17 Jun 2016 11:31:29 +0800 Message-Id: <8f203f0623625f4c2065557c7bc8f3b6fd8b6ed2.1466134116.git.geliangtang@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the device attributes store provides write access. This patch uses down_write()/up_write() instead of down_read()/up_read() in mem_used_max_store() and compact_store(). Signed-off-by: Geliang Tang --- drivers/block/zram/zram_drv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 7454cf1..cfed743 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -293,13 +293,13 @@ static ssize_t mem_used_max_store(struct device *dev, if (err || val != 0) return -EINVAL; - down_read(&zram->init_lock); + down_write(&zram->init_lock); if (init_done(zram)) { struct zram_meta *meta = zram->meta; atomic_long_set(&zram->stats.max_used_pages, zs_get_total_pages(meta->mem_pool)); } - up_read(&zram->init_lock); + up_write(&zram->init_lock); return len; } @@ -372,15 +372,15 @@ static ssize_t compact_store(struct device *dev, struct zram *zram = dev_to_zram(dev); struct zram_meta *meta; - down_read(&zram->init_lock); + down_write(&zram->init_lock); if (!init_done(zram)) { - up_read(&zram->init_lock); + up_write(&zram->init_lock); return -EINVAL; } meta = zram->meta; zs_compact(meta->mem_pool); - up_read(&zram->init_lock); + up_write(&zram->init_lock); return len; } -- 1.9.1