From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EADCC41513 for ; Sun, 13 Aug 2023 18:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231472AbjHMS5Q (ORCPT ); Sun, 13 Aug 2023 14:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231269AbjHMS5O (ORCPT ); Sun, 13 Aug 2023 14:57:14 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 218EBE6F; Sun, 13 Aug 2023 11:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=W7EIIuZzsehMGN3s+UAQBvOzjEu52WA2JojWJigcSms=; b=Cal8smpornabFrJuyHgkGGOJE4 xg/njPb8MnOs9kjEK5EWSUuF4AIA8ckEv6CaIT808qjZ51aSDnw/Hml0/31BHgPYIQZOlfW1T0eSr T+loO3q5MF4ckLFlNkWgHOAdpldZQJ2X1gpbseXtK4PkaCRzwV67HdJK84iV4ijs8DJQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qVGGr-003z6E-SR; Sun, 13 Aug 2023 20:57:01 +0200 Date: Sun, 13 Aug 2023 20:57:01 +0200 From: Andrew Lunn To: Daniel Golle Cc: Qingfang Deng , SkyLake Huang , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs Message-ID: <8f20d427-91cc-4fbc-b263-dfc76df855f9@lunn.ch> References: <32e534441225c62e3bf9384b797d9beda7475053.1691943605.git.daniel@makrotopia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <32e534441225c62e3bf9384b797d9beda7475053.1691943605.git.daniel@makrotopia.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 13, 2023 at 05:24:55PM +0100, Daniel Golle wrote: > Implement netdev trigger and primitive bliking offloading as well as > simple set_brigthness function for both PHY LEDs of the in-SoC PHYs > found in MT7981 and MT7988. > > For MT7988, read boottrap register and apply LED polarities accordingly Should this be bootstrap? With an S? boottrap appears quite often in the code, so maybe the datasheet does say boottrap? Andrew