From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 573A4C77B70 for ; Sat, 15 Apr 2023 16:07:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230013AbjDOQHT (ORCPT ); Sat, 15 Apr 2023 12:07:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjDOQHS (ORCPT ); Sat, 15 Apr 2023 12:07:18 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A7D030F3 for ; Sat, 15 Apr 2023 09:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=iOOY7GW2UBk9WjCP7xXDj2jg0qV4VAat3v70pYg3MRw=; b=0/iI5/qjKHSmYgkx8meEs8sCgT 5/3PRCFyCFPx2AaCKQI9jlR4JhJTPcYD1dc2D03wYOASCm2y9i7ArvyCWykdftHIZUPwPwzt5C7RK BdfZ6dS9yK4ngZi2PDK6wQypBdq//pNXqQopKcNaeLIcm20Ef6Z70jsFYOv6enEE/2wJzU8iqSyI8 LgTmbsWmBwBtUmFbeJtztGOHmw0n+GW+pJiCUKrAEI14enY4OCuiUmf9ZQ8d1NUywpuL29ucFUpl/ MOVL0Vn1IivJEawIX04U4NfjENumsuzTfgx6TWUJrn8tQwwmLFDSMMcAleWHWPsEnnoYvTm84YDnt 4MX3eWfA==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pniQm-00CPy6-2K; Sat, 15 Apr 2023 16:07:16 +0000 Message-ID: <8f2c8d58-f43d-c606-b20e-2c4d8eba5067@infradead.org> Date: Sat, 15 Apr 2023 09:07:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 03/15] w1: ds28e04: correct kerneldoc annotation Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> <20230415104304.104134-3-krzysztof.kozlowski@linaro.org> From: Randy Dunlap In-Reply-To: <20230415104304.104134-3-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/15/23 03:42, Krzysztof Kozlowski wrote: > Correct kerneldoc comments (or drop annotation) to fix: > > w1_ds28e04.c:57: warning: This comment starts with '/**', but isn't a kernel-doc comment. > w1_ds28e04.c:149: warning: This comment starts with '/**', but isn't a kernel-doc comment. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Randy Dunlap Thanks. > --- > drivers/w1/slaves/w1_ds28e04.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/w1/slaves/w1_ds28e04.c b/drivers/w1/slaves/w1_ds28e04.c > index 6cef6e2edb89..f54d6afd79c3 100644 > --- a/drivers/w1/slaves/w1_ds28e04.c > +++ b/drivers/w1/slaves/w1_ds28e04.c > @@ -53,7 +53,7 @@ struct w1_f1C_data { > u32 validcrc; > }; > > -/** > +/* > * Check the file size bounds and adjusts count as needed. > * This would not be needed if the file size didn't reset to 0 after a write. > */ > @@ -146,16 +146,17 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, > } > > /** > - * Writes to the scratchpad and reads it back for verification. > + * w1_f1C_write() - Writes to the scratchpad and reads it back for verification. > + * @sl: The slave structure > + * @addr: Address for the write > + * @len: length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) > + * @data: The data to write > + * > * Then copies the scratchpad to EEPROM. > * The data must be on one page. > * The master must be locked. > * > - * @param sl The slave structure > - * @param addr Address for the write > - * @param len length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) > - * @param data The data to write > - * @return 0=Success -1=failure > + * Return: 0=Success, -1=failure > */ > static int w1_f1C_write(struct w1_slave *sl, int addr, int len, const u8 *data) > { -- ~Randy