mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sia Jee Heng <jeeheng.sia@starfivetech.com>,
	kernel@esmil.dk, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, krzk@kernel.org,
	conor+dt@kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu,
	daniel.lezcano@linaro.org, tglx@linutronix.de, conor@kernel.org,
	anup@brainfault.org, gregkh@linuxfoundation.org,
	jirislaby@kernel.org, michal.simek@amd.com,
	michael.zhu@starfivetech.com, drew@beagleboard.org
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, leyfoon.tan@starfivetech.com
Subject: Re: [PATCH v2 5/6] dt-bindings: serial: cdns: Add new compatible string for StarFive JH8100 UART
Date: Wed, 29 Nov 2023 09:26:13 +0100	[thread overview]
Message-ID: <8f2f241d-580a-4906-949a-b99b5a600868@linaro.org> (raw)
In-Reply-To: <20231129060043.368874-6-jeeheng.sia@starfivetech.com>

On 29/11/2023 07:00, Sia Jee Heng wrote:
> Add new compatible string for UART in the StarFive JH8100 SoC.
> 
> Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>

The patch is quite different than v1. Are you sure the review is
applicable? If it was given for v2, where is it?

> ---
>  Documentation/devicetree/bindings/serial/cdns,uart.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> index e35ad1109efc..0d05305778f2 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> @@ -20,6 +20,10 @@ properties:
>          items:
>            - const: xlnx,zynqmp-uart
>            - const: cdns,uart-r1p12
> +      - description: UART controller for StarFive JH8100 SoC

This is duplicating compatible, drop.

> +        items:
> +          - const: starfive,jh8100-uart
> +          - const: cdns,uart-r1p8

Don't add things to the end of the list, but keep order. I would suggest
to put it at the beginning, so before Xilinx.


Best regards,
Krzysztof


  reply	other threads:[~2023-11-29  8:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29  6:00 [PATCH v2 0/6] Initial device tree support for StarFive JH8100 SoC Sia Jee Heng
2023-11-29  6:00 ` [PATCH v2 1/6] dt-bindings: riscv: Add StarFive Dubhe compatibles Sia Jee Heng
2023-11-29 14:45   ` Conor Dooley
2023-11-30  6:04     ` JeeHeng Sia
2023-11-30 15:08       ` Conor Dooley
2023-11-29  6:00 ` [PATCH v2 2/6] dt-bindings: riscv: Add StarFive JH8100 SoC Sia Jee Heng
2023-11-29  8:26   ` Krzysztof Kozlowski
2023-11-29 10:35     ` JeeHeng Sia
2023-11-29 14:46   ` Conor Dooley
2023-11-29 14:47     ` Conor Dooley
2023-11-29  6:00 ` [PATCH v2 3/6] dt-bindings: timer: Add StarFive JH8100 clint Sia Jee Heng
2023-11-29 14:50   ` Conor Dooley
2023-11-29  6:00 ` [PATCH v2 4/6] dt-bindings: interrupt-controller: Add StarFive JH8100 plic Sia Jee Heng
2023-11-29 14:48   ` Conor Dooley
2023-11-29  6:00 ` [PATCH v2 5/6] dt-bindings: serial: cdns: Add new compatible string for StarFive JH8100 UART Sia Jee Heng
2023-11-29  8:26   ` Krzysztof Kozlowski [this message]
2023-11-29 10:33     ` JeeHeng Sia
2023-11-29 10:53       ` Krzysztof Kozlowski
2023-11-29 13:15         ` JeeHeng Sia
2023-11-29  6:00 ` [PATCH v2 6/6] riscv: dts: starfive: Add initial StarFive JH8100 device tree Sia Jee Heng
2023-11-30 17:58   ` Leyfoon Tan
2023-12-01  1:34     ` JeeHeng Sia
2023-12-01  7:02 ` [PATCH v2 0/6] Initial device tree support for StarFive JH8100 SoC JeeHeng Sia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f2f241d-580a-4906-949a-b99b5a600868@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drew@beagleboard.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeeheng.sia@starfivetech.com \
    --cc=jirislaby@kernel.org \
    --cc=kernel@esmil.dk \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leyfoon.tan@starfivetech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=michael.zhu@starfivetech.com \
    --cc=michal.simek@amd.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®