From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751710AbeAQBTB (ORCPT + 1 other); Tue, 16 Jan 2018 20:19:01 -0500 Received: from mga03.intel.com ([134.134.136.65]:23314 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbeAQBTA (ORCPT ); Tue, 16 Jan 2018 20:19:00 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,369,1511856000"; d="scan'208";a="196232150" Subject: Re: [PATCH v1 0/8] perf: Follow-up patches to improve time slice To: Arnaldo Carvalho de Melo Cc: jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1515596433-24653-1-git-send-email-yao.jin@linux.intel.com> <20180116115519.GA18544@krava> <20180116144844.GB16107@kernel.org> From: "Jin, Yao" Message-ID: <8f31954a-1589-6639-d9dd-67c826b76938@linux.intel.com> Date: Wed, 17 Jan 2018 09:18:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180116144844.GB16107@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 1/16/2018 10:48 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 16, 2018 at 12:55:19PM +0100, Jiri Olsa escreveu: >> On Wed, Jan 10, 2018 at 11:00:25PM +0800, Jin Yao wrote: >>> It's follow-up patches to improve the perf time slice feature >>> (perf report/script --time xxx) >>> >>> 1. Improve the error message >>> perf report: Improve error msg when no first/last sample time found >>> perf script: Improve error msg when no first/last sample time found >>> >>> 2. Fix an issue that illegal percent was accepted previously (e.g. 1abc%) >>> perf util: Improve error checking for time percent input >>> >>> 3. Omit the slice index if possible. For example, >>> perf report --stdio --time 10%/1 is equivalent to >>> perf report --stdio --time 10% >>> >>> perf util: Support no index time percent slice >>> >>> 4. Add indication of time slices in perf report header. >>> perf report: Add an indication of what time slices are used >>> >>> 5. Remove the time slices number limitation in perf report/script >>> perf util: Allocate time slices buffer according to number of comma >>> perf report: Remove the time slices number limitation >>> perf script: Remove the time slices number limitation >>> >>> Jin Yao (8): >>> perf report: Improve error msg when no first/last sample time found >>> perf script: Improve error msg when no first/last sample time found >>> perf util: Improve error checking for time percent input >>> perf util: Support no index time percent slice >>> perf report: Add an indication of what time slices are used >>> perf util: Allocate time slices buffer according to number of comma >>> perf report: Remove the time slices number limitation >>> perf script: Remove the time slices number limitation >> >> from quick look it looks ok >> >> Reviewed-by: Jiri Olsa > > Thanks, applied, now test building with 'make -C tools/perf build-test', > containers, etc. > > - Arnaldo > Thanks Arnaldo! Thanks Jin Yao