From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1312638E124 for ; Mon, 16 Mar 2026 10:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656963; cv=none; b=fb3LPLSvV5DIQDWI1SCNdHGQo+wun6YjcF0s4zB1zh/4/0pJMAm9J8AP7PLTVcGLhKr5ImlRLG1keVojXkRSj+0xE/hhLYOG6IiRsL1y/3IENV0zz/IHd1cMzsBTZF61SQKsFOmHmyvjkKbqHzAx1wzIhiDXBi8piQE68USXELw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773656963; c=relaxed/simple; bh=IhdOlK3xkSHwS/HmxmDn+XxtxUPS5lYZZxAzx5EX3qY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QPL/djPK/jdaIzQAWSZzYLaabM8Sh+g3g0m0q00MzmMUWvoj+25qsdJOfefVioWSCIjZWXpy/89Aot0yqbzCnA02mT8WXONTSaw8a3VbUnTAKPZG7UxuXRXgxXm98leivKyh5n5jgEuxJ4+UgMuA/H/4786jMkdgJhg+ZeL9Oag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UpJ+1mC2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AOQfjAMh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UpJ+1mC2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AOQfjAMh" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64oQY744240 for ; Mon, 16 Mar 2026 10:29:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6oES8Gpa9IGsbE249rQxahJVZ5GFUEVg0kZsqaGmBSo=; b=UpJ+1mC28jUirm/Q xUVgEBXbh0nPKCvxJyaNOIwptSMaak2rKSQByPKauElcFPa7X5I6DpZHe/dMUe9Q FANqBQ22Mhgb2i9l5a8b+sNgiPJTB5+N9oNiQ9P2wdJ4bn3BszYEwBjzXbSf9PBz TcvDMhynX0oj37YPBZk4GU6rESXDiEHklYVYj5x92pfLS7sDc+0mTHuuI/ClArom E1e7ch/jGBa/HSfgNV7OXHGsbogZ04FADbzt732aG1mTp2N2/tTDn0ftoDTi7rEO 5w+0dUPinQmEZxahsFm2DkIoApnnsNkaOiWS6GtFARXQe7KB9EYtCM860sPYtxh+ vnq8Gw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cw00bdavr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 10:29:20 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2aec07e8aafso28125325ad.1 for ; Mon, 16 Mar 2026 03:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773656960; x=1774261760; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6oES8Gpa9IGsbE249rQxahJVZ5GFUEVg0kZsqaGmBSo=; b=AOQfjAMhAbvfZq0ALdAnv7qr25q66QqJtjUMVLi+279xswIPwQNan5q+Qfhzl0I5RP 2rYc/uXMyt8qW1b5/ZtSdD7o3gol1nEbB3tAntN5DzzKn0GoqHCixNBGM6MaDDk5Q77/ oVMUbuO/8+4oq/GK0BFAJx0XzVwsaxa9+qbdqzn5QLFQo61or/8G5g6TZ3252Y4X5dvW 6zvsqX4YeEgfwOGj1XGOjSmrvSzsFgh2S+DhXMVJR8ubVsOX1BZC0NeF86jYC6wyfj4H HtW2Lm5IMADfkc+7GDCwt2rg56bjxYp7jMESTLYaBI6boZZUAKP9FWXYI76n572qVDyd yxFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773656960; x=1774261760; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6oES8Gpa9IGsbE249rQxahJVZ5GFUEVg0kZsqaGmBSo=; b=Btgc/Wi1EPmABElOjlITcd3Xh1LFkUSur3k1qjB+9X3pFsFlnigq8K31ro/FhHdtSX d4ysBFIXUUCARWmJYA1fuRMZq+jxOAbZQ8dowMIrDi3uTzUcnirtct+ioJgA5d3CWLCI NHgvdCMfhTeCCXfj/4SfYLUXaN+1KZ+MQVTFVxv/U918eWiwDulTWWBuEVdiw3roI9HL nHEy4MJHRebJXU4R4JAtOhxy+1DOTNNwJ9YLtucsU9lP4vmbrS9+Go3NTFchszfEEQOV gGGZYowbCO/g78OhtMlUVCJXTo2B0IAOALcxKQxqpnNqPIV7kSGrdNo0JAWKd+o58JOH bECw== X-Forwarded-Encrypted: i=1; AJvYcCW9WO3cH8xjUF4vNRxWAq2oDeznwVzgRttC9j2W+jM5lkB+OS+oDQiydt5T8N/YvNNf43dEnbdLOjN4QH4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz33qcZAvy46cw58CqSMTsGkx+Z+ipuXRpMc9Tpls6W8H+UiO0d UM4z1UO+9o6GW8eJ4Fx/qhpxL0FIX+NaMLaevG5fJ00z6qokoR9RMp3p7R/wsaIkFuIDNGM/Xfm 3A0Ol0fFiY0LiW3DnLreKvIFOZNQqMUAJQ6roh9ysEkBmOglxf/ViV/x0VKSQ+ytO6Z0= X-Gm-Gg: ATEYQzzGrsnfZO/WcNyVtw1uC6wUxR0UABZgqMmu4B2qiKyWYU6E5cMFOmNMQ6ijTax caiKnyAXeavYDVBdU4jI/Ef+B7EZ7sJ7V6F6BmJB++k2WBXJxzBL9erh+cl72GaqZBx7l66hUiO l9FYGl3jeJc9PyqQocVLBxgQEeJS4nv812dJrCkX6HCbYV6hIRJDSLu8+4/XrhZA4WXqeX+4mxG xNZfAgX8pamxx+x4FWzqVV65bs3EcapYsBLEIwGZaqNi0pTS2xFaQvH8Upvbc+mwqV5i9j9b3BS 68ATxD5eU7l7LdG2TG1Uo7dUj9ZGMbbYQV0Ex1hAIwRFtfoMkZ/mxNEK8VXkeHm2S/bBqIXs0ER ejljC9F4FhT4cGHm4wdL3QlsXfHTR2D45N3lMOseumIAqyAzCE/Oz5GRsHwSPyseuF/EoVFYbiY nJnDoGjkXrI3A= X-Received: by 2002:a17:903:3c4f:b0:2ae:aad7:5811 with SMTP id d9443c01a7336-2aeca9a908amr142064445ad.11.1773656959799; Mon, 16 Mar 2026 03:29:19 -0700 (PDT) X-Received: by 2002:a17:903:3c4f:b0:2ae:aad7:5811 with SMTP id d9443c01a7336-2aeca9a908amr142064155ad.11.1773656959317; Mon, 16 Mar 2026 03:29:19 -0700 (PDT) Received: from [10.133.33.135] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0542909d8sm48209605ad.31.2026.03.16.03.29.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:29:18 -0700 (PDT) Message-ID: <8f37ae07-f211-4d43-bc01-4ab17a0d1f32@oss.qualcomm.com> Date: Mon, 16 Mar 2026 18:29:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] coresight: tpdm: add traceid_show for checking traceid To: Suzuki K Poulose , Jie Gan , Mike Leach , James Clark , Leo Yan , Alexander Shishkin , Tingwei Zhang Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260316-add-traceid-show-for-tpdm-v2-1-1dec2a67e4ed@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=IsATsb/g c=1 sm=1 tr=0 ts=69b7db80 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=bGktN_mo5dDm-SOVuGEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA4MCBTYWx0ZWRfX+rhv79uK/lOI WRzwYCGGHzOu/m5ncgCFnwUQaE3Zu9pIfdvT+k9bODg1hqzrnpfxJRd+Dx6ouVjBXroXQej4UzH Ds0ZEUHk+nZG0xQwN0fZBMHF1jqh/Oz9Scg4GjHYJ80I6ZFy9yVCr2yi0SW1SSaN/GpUvYYK65E HZTpMjWsRuU9E6xvvhoaCaLIf+GJPWb+/qdYyRflEJE8crpTkrNCCM+5DD7ub4AUb4oKVxw4DCy lIxAp4xpuLHOUZUIlt1ELmpr1iyPYw0q6k+s98Ia7yr6dLyqcOEGg8iciQvRRia1D1IgOEFavT+ ZK1FVgoyw5aSDfD5ojmk6HdCiH+8NIUK8uDc0W4I0rtqC4wlvoLeNB0br8drxq7FnuDajsgnwWv k0b0Ghwqm3JXyV9I8uwii6k9tDnHUbCSkJ+ECQZPlSqHSX3wnE747+IirAyk54+3qGH/SvDvg3l 8B04P5y5tb1Rrsb1pug== X-Proofpoint-GUID: Y2UGSZeHMZxMK9KeqB4y4TFjOh40lVi5 X-Proofpoint-ORIG-GUID: Y2UGSZeHMZxMK9KeqB4y4TFjOh40lVi5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160080 Hi Suzuki, On 3/16/2026 5:32 PM, Suzuki K Poulose wrote: > On 16/03/2026 07:23, Jie Gan wrote: >> Save the trace ID in drvdata during TPDM enablement and expose it >> to userspace to support trace data parsing. >> >> The TPDM device’s trace ID corresponds to the trace ID allocated >> to the connected TPDA device. >> >> Signed-off-by: Jie Gan >> --- >> Changes in V2: >> 1. Use sysfs_emit instead of sprintf. >> Link to V1 - https://lore.kernel.org/all/20260306-add-traceid-show- >> for-tpdm-v1-1-0658a8edb972@oss.qualcomm.com/ > > Why is this patch required even ? For each TPDM there is a single It's taking effort to retrieve the trace ID of the TPDA device because it's not a source device. The trace ID is required to identify the origin of the trace data and is essential for parsing the received data. > port in a single TPDA in the system where it can reach and that is > fixed for a platform. Can we not get this from there ? Also, there > is not TraceID technically for a TPDM, right ? It is all a property Yes, we dont allocate trace ID for a TPDM device. The TraceID is allocated to the TPDA device. Thanks, Jie > of the TPDA ? > > Suzuki > > >> --- >>   drivers/hwtracing/coresight/coresight-tpdm.c | 31 ++++++++++++++++++ >> +++++++++- >>   drivers/hwtracing/coresight/coresight-tpdm.h |  2 ++ >>   2 files changed, 32 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/ >> hwtracing/coresight/coresight-tpdm.c >> index da77bdaad0a4..774a63def817 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpdm.c >> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c >> @@ -481,7 +481,7 @@ static void __tpdm_enable(struct tpdm_drvdata >> *drvdata) >>   static int tpdm_enable(struct coresight_device *csdev, struct >> perf_event *event, >>                  enum cs_mode mode, >> -               __maybe_unused struct coresight_path *path) >> +               struct coresight_path *path) >>   { >>       struct tpdm_drvdata *drvdata = dev_get_drvdata(csdev->dev.parent); >> @@ -497,6 +497,7 @@ static int tpdm_enable(struct coresight_device >> *csdev, struct perf_event *event, >>       } >>       __tpdm_enable(drvdata); >> +    drvdata->traceid = path->trace_id; >>       drvdata->enable = true; >>       spin_unlock(&drvdata->spinlock); >> @@ -693,6 +694,26 @@ static struct attribute_group tpdm_attr_grp = { >>       .attrs = tpdm_attrs, >>   }; >> +static ssize_t traceid_show(struct device *dev, >> +                struct device_attribute *attr, char *buf) >> +{ >> +    unsigned long val; >> +    struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent); >> + >> +    val = drvdata->traceid; >> +    return sysfs_emit(buf, "%#lx\n", val); >> +} >> +static DEVICE_ATTR_RO(traceid); >> + >> +static struct attribute *traceid_attrs[] = { >> +    &dev_attr_traceid.attr, >> +    NULL, >> +}; >> + >> +static struct attribute_group traceid_attr_grp = { >> +    .attrs = traceid_attrs, >> +}; >> + >>   static ssize_t dsb_mode_show(struct device *dev, >>                    struct device_attribute *attr, >>                    char *buf) >> @@ -1367,6 +1388,12 @@ static const struct attribute_group >> *tpdm_attr_grps[] = { >>       &tpdm_cmb_patt_grp, >>       &tpdm_cmb_msr_grp, >>       &tpdm_mcmb_attr_grp, >> +    &traceid_attr_grp, >> +    NULL, >> +}; >> + >> +static const struct attribute_group *static_tpdm_attr_grps[] = { >> +    &traceid_attr_grp, >>       NULL, >>   }; >> @@ -1425,6 +1452,8 @@ static int tpdm_probe(struct device *dev, struct >> resource *res) >>       desc.access = CSDEV_ACCESS_IOMEM(base); >>       if (res) >>           desc.groups = tpdm_attr_grps; >> +    else >> +        desc.groups = static_tpdm_attr_grps; > > >       drvdata->csdev = coresight_register(&desc);>       if > (IS_ERR(drvdata->csdev)) >>           return PTR_ERR(drvdata->csdev); >> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.h b/drivers/ >> hwtracing/coresight/coresight-tpdm.h >> index 2867f3ab8186..befecbb896f4 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpdm.h >> +++ b/drivers/hwtracing/coresight/coresight-tpdm.h >> @@ -300,6 +300,7 @@ struct cmb_dataset { >>    * @cmb         Specifics associated to TPDM CMB. >>    * @dsb_msr_num Number of MSR supported by DSB TPDM >>    * @cmb_msr_num Number of MSR supported by CMB TPDM >> + * @traceid    trace ID of the path. >>    */ >>   struct tpdm_drvdata { >> @@ -313,6 +314,7 @@ struct tpdm_drvdata { >>       struct cmb_dataset    *cmb; >>       u32            dsb_msr_num; >>       u32            cmb_msr_num; >> +    u8            traceid; >>   }; >>   /* Enumerate members of various datasets */ >> >> --- >> base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900 >> change-id: 20260316-add-traceid-show-for-tpdm-88d040651f00 >> >> Best regards, > >