From: Kyle Switch <kyle.switch@motor-comm.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, mmyangfl@gmail.com,
horms@kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.xu@motor-comm.com,
xiaolin.xu@motor-comm.com, jianmin.wang@motor-comm.com,
wei.zhang@gl-inet.com, sijia.huang@gl-inet.com
Subject: Re: [PATCH net-next v5 3/6] net: dsa: motorcomm: relocate MIB polling initialization to dsa_setup()
Date: Sun, 6 Sep 2026 09:54:08 +0800 [thread overview]
Message-ID: <8f3ba571-28f3-42da-9797-612589db0d07@motor-comm.com> (raw)
In-Reply-To: <69b0cc5b-0b67-4eec-89e3-b4c788febdbb@lunn.ch>
On 9/4/26 21:48, Andrew Lunn wrote:
> On Fri, Sep 04, 2026 at 05:54:13PM +0800, Kyle Switch wrote:
>> Move MIB polling start from probe() to dsa_setup()
> Actually, having thread the following patches...
>
> For every start, there is generally a stop.
>
> You move start from probe() to dsa_setup().
>
> Should you not move stop from remove() to dsa_teardown()?
> You want to keep the driver symmetrical.
Ans, yes, in the next version, we will optimize the handling
of MIB polling enable by moving into setup(), and remove MIB
polling disable into teardown(). From the current perspective, the
mib_init flag is no longer needed.
> Andrew
next prev parent reply other threads:[~2026-09-06 1:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 9:54 [PATCH net-next v5 1/6] net: dsa: motorcomm: refactor registration path for upcoming switch families Kyle Switch
2026-09-04 9:54 ` [PATCH net-next v5 2/6] net: dsa: motorcomm: use max_ports from series_info for port bounds checking Kyle Switch
2026-09-04 13:32 ` Andrew Lunn
2026-09-06 1:47 ` Kyle Switch
2026-09-04 9:54 ` [PATCH net-next v5 3/6] net: dsa: motorcomm: relocate MIB polling initialization to dsa_setup() Kyle Switch
2026-09-04 13:37 ` Andrew Lunn
2026-09-06 1:56 ` Kyle Switch
2026-09-04 13:48 ` Andrew Lunn
2026-09-06 1:54 ` Kyle Switch [this message]
2026-09-04 17:13 ` David Yang
2026-09-06 2:12 ` Kyle Switch
2026-09-04 9:54 ` [PATCH net-next v5 4/6] net: dsa: motorcomm: introduce mib_init to control MIB polling initialization Kyle Switch
2026-09-04 13:45 ` Andrew Lunn
2026-09-06 2:00 ` Kyle Switch
2026-09-04 9:54 ` [PATCH net-next v5 5/6] net: dsa: tag_922x: add support for Motorcomm YT922x tags Kyle Switch
2026-09-04 17:22 ` David Yang
2026-09-04 13:14 ` [PATCH net-next v5 1/6] net: dsa: motorcomm: refactor registration path for upcoming switch families Andrew Lunn
2026-09-04 17:03 ` David Yang
2026-09-06 2:08 ` Kyle Switch
2026-09-06 18:31 ` David Yang
2026-09-07 3:00 ` Andrew Lunn
2026-09-07 6:44 ` Kyle Switch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f3ba571-28f3-42da-9797-612589db0d07@motor-comm.com \
--to=kyle.switch@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jianmin.wang@motor-comm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ming.xu@motor-comm.com \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=sijia.huang@gl-inet.com \
--cc=wei.zhang@gl-inet.com \
--cc=xiaolin.xu@motor-comm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®