mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: lizhe <sensor1010@163.com>
Cc: jirislaby@kernel.org, gregkh@linuxfoundation.org,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial: linflexuart: remove redundant uart type _assignment_
Date: Tue, 3 Jan 2023 20:56:40 +0200 (EET)	[thread overview]
Message-ID: <8f433e5-fb46-d3b8-431b-4bddcc938f6b@linux.intel.com> (raw)
In-Reply-To: <20230103170948.3777-1-sensor1010@163.com>

On Tue, 3 Jan 2023, lizhe wrote:

> 	in linflex_config_port() the member variable type will be

Rmoeve these extra spaces and start right from the leftmost column. 

And don't include the underscores (_) into the shortlog around assignment. 
Jiri just used the underscores to highlight for you what he considered 
important part to be corrected.


> assigned again. see linflex_connfig_port()
> 
> Signed-off-by: lizhe <sensor1010@163.com>
> Acked-by: Jiri Slaby <jslaby@suse.com>
> ---

When sending version xx, please remember to include the list of changes 
made per version (they go here below the first --- marker, see mailinglist 
archives for format examples if you don't know that alread).

-- 
 i.

>  drivers/tty/serial/fsl_linflexuart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
> index 6fc21b6684e6..34400cc6ac7f 100644
> --- a/drivers/tty/serial/fsl_linflexuart.c
> +++ b/drivers/tty/serial/fsl_linflexuart.c
> @@ -837,7 +837,6 @@ static int linflex_probe(struct platform_device *pdev)
>  		return PTR_ERR(sport->membase);
>  
>  	sport->dev = &pdev->dev;
> -	sport->type = PORT_LINFLEXUART;
>  	sport->iotype = UPIO_MEM;
>  	sport->irq = platform_get_irq(pdev, 0);
>  	sport->ops = &linflex_pops;
> 

      reply	other threads:[~2023-01-03 18:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03 17:09 lizhe
2023-01-03 18:56 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f433e5-fb46-d3b8-431b-4bddcc938f6b@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sensor1010@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®