From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH net v1] net: dsa: qca: ar9331: fix sleeping function called from invalid context bug
Date: Fri, 4 Dec 2020 16:00:35 +0100 [thread overview]
Message-ID: <8f44d5cb-fa99-b004-078e-078241f265a0@pengutronix.de> (raw)
In-Reply-To: <20201204145751.13166-1-o.rempel@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 959 bytes --]
On 12/4/20 3:57 PM, Oleksij Rempel wrote:
[...]
> +static void ar9331_sw_irq_bus_sync_unlock(struct irq_data *d)
> {
> struct ar9331_sw_priv *priv = irq_data_get_irq_chip_data(d);
> struct regmap *regmap = priv->regmap;
> int ret;
>
> ret = regmap_update_bits(regmap, AR9331_SW_REG_GINT_MASK,
> - AR9331_SW_GINT_PHY_INT,
> - AR9331_SW_GINT_PHY_INT);
> + AR9331_SW_GINT_PHY_INT, priv->irq_mask);
> if (ret)
> - dev_err(priv->dev, "could not unmask IRQ\n");
> + dev_err(priv->dev, "could not mask IRQ\n");
Technically this could be a mask or unmask operation. What about changing the
error message to: "faild to change IRQ mask"?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-04 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 14:57 Oleksij Rempel
2020-12-04 15:00 ` Marc Kleine-Budde [this message]
2020-12-09 13:09 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f44d5cb-fa99-b004-078e-078241f265a0@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®