From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexey Klimov <alexey.klimov@linaro.org>,
linux-sound@vger.kernel.org, srinivas.kandagatla@linaro.org,
bgoswami@quicinc.com, lgirdwood@gmail.com, broonie@kernel.org
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org, perex@perex.cz,
tiwai@suse.com, linux-arm-msm@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
elder@linaro.org, dmitry.baryshkov@linaro.org,
caleb.connolly@linaro.org, linux-kernel@vger.kernel.org,
a39.skl@gmail.com
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: qrb4210-rb2: add description of lpi_i2s2 pins
Date: Wed, 2 Oct 2024 07:44:00 +0200 [thread overview]
Message-ID: <8f460d95-3994-49df-a355-612d3d5c4c92@linaro.org> (raw)
In-Reply-To: <20241002022015.867031-7-alexey.klimov@linaro.org>
On 02/10/2024 04:20, Alexey Klimov wrote:
> This is required to enable to HDMI audio playback on
> QRB4210 RB2 board.
>
> Signed-off-by: Alexey Klimov <alexey.klimov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 36 ++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> index 1888d99d398b..7731681688d5 100644
> --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> @@ -634,6 +634,42 @@ sdc2_card_det_n: sd-card-det-n-state {
> };
> };
>
> +&lpass_tlmm {
> + lpi_i2s2_active: lpi-i2s2-active-state {
> + sck-pin {
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-02 5:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 2:20 [PATCH v2 0/7] qrb4210-rb2: add HDMI audio playback support Alexey Klimov
2024-10-02 2:20 ` [PATCH v2 1/7] ASoC: dt-bindings: qcom,sm8250: add qrb4210-rb2-sndcard Alexey Klimov
2024-10-02 6:22 ` Krzysztof Kozlowski
2024-10-02 2:20 ` [PATCH v2 2/7] ASoC: qcom: sm8250: add qrb4210-rb2-sndcard compatible string Alexey Klimov
2024-10-06 20:30 ` Dmitry Baryshkov
2024-10-02 2:20 ` [PATCH v2 3/7] ASoC: qcom: sm8250: add handling of secondary MI2S clock Alexey Klimov
2024-10-06 20:31 ` Dmitry Baryshkov
2024-10-02 2:20 ` [PATCH v2 4/7] arm64: dts: qcom: sm6115: add apr and its services Alexey Klimov
2024-10-02 2:20 ` [PATCH v2 5/7] arm64: dts: qcom: sm4250: add LPASS LPI pin controller Alexey Klimov
2024-10-06 20:34 ` Dmitry Baryshkov
2024-10-02 2:20 ` [PATCH v2 6/7] arm64: dts: qcom: qrb4210-rb2: add description of lpi_i2s2 pins Alexey Klimov
2024-10-02 5:44 ` Krzysztof Kozlowski [this message]
2024-10-02 2:20 ` [PATCH v2 7/7] arm64: dts: qcom: qrb4210-rb2: add HDMI audio playback support Alexey Klimov
2024-10-06 20:37 ` Dmitry Baryshkov
2024-10-02 3:52 ` [PATCH v2 0/7] " Rob Herring (Arm)
2024-10-02 18:22 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f460d95-3994-49df-a355-612d3d5c4c92@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a39.skl@gmail.com \
--cc=alexey.klimov@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=elder@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®