From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F16B2FD1B3 for ; Mon, 17 Nov 2025 17:32:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763400742; cv=none; b=EGMH882jkKgC41RBFbEfEG7sVNMg3MHKPF5KmuqCtGLAxsojIf+yyO493YlSOsKHO85Lql+cLYCik/1HdusfBdf2dGVeoXMC8NqMcZi1rOBTtpYJVeMWAfwfAtVTEQisY7h0qnbrxQXUG9UnowhQEb3Vb0Stcv9SveoWdPoE338= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763400742; c=relaxed/simple; bh=p7UoWhSASKIFM9N8KEMQsy+JJvpT3vPnVBj279wToy4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JZ+L+wseNAKIXT3fMecbS63TA61thV6Ap1foWOYsRDWvvqs3mog4HHttgWgRYnDSCd5PSr8klpcEJb9gH1aixv69u+H5HLUnbXL8cN6/ZwaCoj74H5WFLPMNJlhwHFqTVpBUMON/MJpoYcFfO6G+aa189f646GCMdpHZ4W08iFQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R4YUPSr6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R4YUPSr6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0D67C2BCC4; Mon, 17 Nov 2025 17:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763400740; bh=p7UoWhSASKIFM9N8KEMQsy+JJvpT3vPnVBj279wToy4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=R4YUPSr601WVdNpuA3i7oRljTsOUFQiDfSzCsz8spsNXDIYLK+rbEFMbhEHJ/tb5N mdPOmWDl7QdROB6UOXtygsocqj4MIXlrwijvCPPZirdSH9iuODmjs2io91zCrf/RQW bSstdD2UD6Q2GX2ncM50q1tkGAMkwCtKTj2xdS09FOoXsxyC/2FgqBJeSj7NqMfrbJ Vk89MkQFXbl6xWUp92IbqjL4EvU0s7YIJQNDEfcDDATarK8vYHYqFyZSlz5aaj5SFV 6WORQJVNtQL2rICqXnj5YA1Hr+iD+TYfh/0QoEd5vaqCuRNbbWBUjGns/PAho/tpf9 Zvqnv2nnuz2Gw== Message-ID: <8f4876a6-796d-4d08-9944-730be05b7088@kernel.org> Date: Mon, 17 Nov 2025 18:32:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 05/10] drivers: nvdimm: use pgtable_has_pmd_leaves() To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com References: From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06.11.25 22:28, Luiz Capitulino wrote: > nd_pfn_supported_alignments() and nd_pfn_supported_alignments() use > has_transparent_hugepage() to check if PMD-sized pages are supported, > use pgtable_has_pmd_leaves() instead. > > Signed-off-by: Luiz Capitulino > --- > drivers/nvdimm/pfn_devs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvdimm/pfn_devs.c b/drivers/nvdimm/pfn_devs.c > index 42b172fc5576..989f87f07e0c 100644 > --- a/drivers/nvdimm/pfn_devs.c > +++ b/drivers/nvdimm/pfn_devs.c > @@ -94,7 +94,7 @@ static unsigned long *nd_pfn_supported_alignments(unsigned long *alignments) > > alignments[0] = PAGE_SIZE; > > - if (has_transparent_hugepage()) { > + if (pgtable_has_pmd_leaves()) { > alignments[1] = HPAGE_PMD_SIZE; > if (has_transparent_pud_hugepage()) Yeah, that should become pgtable_has_pud_leaves() later. > alignments[2] = HPAGE_PUD_SIZE; > @@ -109,7 +109,7 @@ static unsigned long *nd_pfn_supported_alignments(unsigned long *alignments) > static unsigned long nd_pfn_default_alignment(void) > { > > - if (has_transparent_hugepage()) > + if (pgtable_has_pmd_leaves()) > return HPAGE_PMD_SIZE; > return PAGE_SIZE; > } Similar question, what if the kernel would be built without CONFIG_TRANSPARENT_HUGEPAGE, would it matter here? In that case, an additional eary "if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE))" might do the trick. -- Cheers David