From: Dave Hansen <dave.hansen@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: sathyanarayanan.kuppuswamy@linux.intel.com, hpa@zytor.com,
seanjc@google.com, elena.reshetova@intel.com,
rick.p.edgecombe@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 4/4] x86/tdx: Enable ENUM_TOPOLOGY
Date: Wed, 24 Apr 2024 15:20:54 -0700 [thread overview]
Message-ID: <8f4c664e-665b-495c-b6d0-04899a3c216b@intel.com> (raw)
In-Reply-To: <20240325104607.2653307-5-kirill.shutemov@linux.intel.com>
On 3/25/24 03:46, Kirill A. Shutemov wrote:
> + if ((features & TDX_FEATURES0_ENUM_TOPOLOGY) &&
> + tdg_vm_rd(TDCS_TOPOLOGY_ENUM_CONFIGURED)) {
> + if (!tdcs_ctls_set(TD_CTLS_ENUM_TOPOLOGY))
> + pr_warn("Failed to enable ENUM_TOPOLOGY\n");
> + }
This is looking pretty familiar at this point.
I'd almost rather just have it do a plain old:
tdcs_ctls_set(TD_CTLS_ENUM_TOPOLOGY);
... and leave it at that.
*If* there is a generic return code for "invalid" as opposed to a
not-supported tdcs_ctls_set(), then it's arguable that you can spit out
a message for an unexpected "invalid" error.
But seriously, why all the complexity over and over? What does this buy?
next prev parent reply other threads:[~2024-04-24 22:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 10:46 [PATCHv2 0/4] x86/tdx: Adjust TD settings on boot Kirill A. Shutemov
2024-03-25 10:46 ` [PATCHv2 1/4] x86/tdx: Introduce tdg_vm_wr() Kirill A. Shutemov
2024-03-26 10:45 ` Huang, Kai
2024-03-26 14:56 ` Kuppuswamy Sathyanarayanan
2024-04-24 17:53 ` Dave Hansen
2024-03-25 10:46 ` [PATCHv2 2/4] x86/tdx: Rename tdx_parse_tdinfo() to tdx_setup() Kirill A. Shutemov
2024-03-26 10:45 ` Huang, Kai
2024-03-25 10:46 ` [PATCHv2 3/4] x86/tdx: Handle PENDING_EPT_VIOLATION_V2 Kirill A. Shutemov
2024-04-24 18:29 ` Dave Hansen
2024-03-25 10:46 ` [PATCHv2 4/4] x86/tdx: Enable ENUM_TOPOLOGY Kirill A. Shutemov
2024-03-26 10:59 ` Huang, Kai
2024-03-26 12:21 ` kirill.shutemov
2024-04-24 22:20 ` Dave Hansen [this message]
2024-04-27 16:53 ` Kirill A. Shutemov
2024-04-10 14:37 ` [PATCHv2 0/4] x86/tdx: Adjust TD settings on boot Kirill A. Shutemov
2024-04-10 14:41 ` Edgecombe, Rick P
2024-04-12 15:01 ` kirill.shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f4c664e-665b-495c-b6d0-04899a3c216b@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=elena.reshetova@intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®